Applies suggestions from code review.
This commit is contained in:
parent
d4f6a0ef6b
commit
0f91dd03df
|
@ -27,7 +27,7 @@ pub const MAX_NETWORK_NAME_LENGTH: usize = 30;
|
|||
/// Maximum length for a configured human-readable prefix.
|
||||
pub const MAX_HRP_LENGTH: usize = 30;
|
||||
|
||||
/// The block hash of the Testnet genesis block, `zcash-cli -regtest getblockhash 0`
|
||||
/// The block hash of the Regtest genesis block, `zcash-cli -regtest getblockhash 0`
|
||||
const REGTEST_GENESIS_HASH: &str =
|
||||
"029f11d80ef9765602235e1bc9727e3eb6ba20839319f761fee920d63401e327";
|
||||
|
||||
|
@ -161,7 +161,7 @@ impl ParametersBuilder {
|
|||
self
|
||||
}
|
||||
|
||||
/// Parses a hex-encoded block hash and sets the genesis hash to be used in the [`Parameters`] being built.
|
||||
/// Parses the hex-encoded block hash and sets it as the genesis hash in the [`Parameters`] being built.
|
||||
pub fn with_genesis_hash(mut self, genesis_hash: impl fmt::Display) -> Self {
|
||||
self.genesis_hash = genesis_hash
|
||||
.to_string()
|
||||
|
|
|
@ -34,9 +34,9 @@ pub(crate) const REGTEST_SOLUTION_SIZE: usize = 36;
|
|||
|
||||
/// Equihash Solution in compressed format.
|
||||
///
|
||||
/// A wrapper around [u8; 1344] because Rust doesn't implement common
|
||||
/// traits like `Debug`, `Clone`, etc for collections like array
|
||||
/// beyond lengths 0 to 32.
|
||||
/// A wrapper around `[u8; n]` where `n` is the solution size because
|
||||
/// Rust doesn't implement common traits like `Debug`, `Clone`, etc.
|
||||
/// for collections like arrays beyond lengths 0 to 32.
|
||||
///
|
||||
/// The size of an Equihash solution in bytes is always 1344 on Mainnet and Testnet, and
|
||||
/// is always 36 on Regtest so the length of this type is fixed.
|
||||
|
|
Loading…
Reference in New Issue