From 30effa6a46eebd5dab6d26414f59f06642e57a6f Mon Sep 17 00:00:00 2001 From: teor Date: Fri, 10 Jul 2020 16:33:43 +1000 Subject: [PATCH] doc: Improve checkpoint test comments Closes #626. --- zebra-consensus/src/checkpoint/tests.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/zebra-consensus/src/checkpoint/tests.rs b/zebra-consensus/src/checkpoint/tests.rs index ad0f55725..74500eb4e 100644 --- a/zebra-consensus/src/checkpoint/tests.rs +++ b/zebra-consensus/src/checkpoint/tests.rs @@ -108,11 +108,10 @@ async fn multi_item_checkpoint_list() -> Result<(), Report> { // Parse all the blocks let mut checkpoint_data = Vec::new(); for b in &[ + // This list is used as a checkpoint list, and as a list of blocks to + // verify. So it must be continuous. &zebra_test::vectors::BLOCK_MAINNET_GENESIS_BYTES[..], &zebra_test::vectors::BLOCK_MAINNET_1_BYTES[..], - // TODO(teor): not continuous, so they hang - //&zebra_test::vectors::BLOCK_MAINNET_415000_BYTES[..], - //&zebra_test::vectors::BLOCK_MAINNET_434873_BYTES[..], ] { let block = Arc::::zcash_deserialize(*b)?; let hash: BlockHeaderHash = block.as_ref().into(); @@ -584,8 +583,10 @@ async fn checkpoint_drop_cancel() -> Result<(), Report> { // Parse all the blocks let mut checkpoint_data = Vec::new(); for b in &[ + // Continous blocks are verified &zebra_test::vectors::BLOCK_MAINNET_GENESIS_BYTES[..], &zebra_test::vectors::BLOCK_MAINNET_1_BYTES[..], + // Other blocks can't verify, so they are rejected on drop &zebra_test::vectors::BLOCK_MAINNET_415000_BYTES[..], &zebra_test::vectors::BLOCK_MAINNET_434873_BYTES[..], ] {