From 4671efe98c94f40eba6f12b09ec2fe17b69c17d9 Mon Sep 17 00:00:00 2001 From: Arya Date: Thu, 18 Apr 2024 16:34:11 -0400 Subject: [PATCH] Checks that default Mainnet/Testnet/Regtest Sapling HRPs pass validation in `with_sapling_hrps()` --- .../src/parameters/network/tests/vectors.rs | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/zebra-chain/src/parameters/network/tests/vectors.rs b/zebra-chain/src/parameters/network/tests/vectors.rs index 843122d31..b9511dc91 100644 --- a/zebra-chain/src/parameters/network/tests/vectors.rs +++ b/zebra-chain/src/parameters/network/tests/vectors.rs @@ -1,6 +1,9 @@ //! Fixed test vectors for the network consensus parameters. -use zcash_primitives::consensus::{self as zp_consensus, Parameters}; +use zcash_primitives::{ + consensus::{self as zp_consensus, Parameters}, + constants as zp_constants, +}; use crate::{ block::Height, @@ -266,4 +269,23 @@ fn check_configured_sapling_hrps() { expected_hrp_sapling_payment_address, "should return expected Sapling payment address HRP" ); + + // Check that default Mainnet, Testnet, and Regtest HRPs are valid, these calls will panic + // if any of the values fail validation. + testnet::Parameters::build() + .with_sapling_hrps( + zp_constants::mainnet::HRP_SAPLING_EXTENDED_SPENDING_KEY, + zp_constants::mainnet::HRP_SAPLING_EXTENDED_FULL_VIEWING_KEY, + zp_constants::mainnet::HRP_SAPLING_PAYMENT_ADDRESS, + ) + .with_sapling_hrps( + zp_constants::testnet::HRP_SAPLING_EXTENDED_SPENDING_KEY, + zp_constants::testnet::HRP_SAPLING_EXTENDED_FULL_VIEWING_KEY, + zp_constants::testnet::HRP_SAPLING_PAYMENT_ADDRESS, + ) + .with_sapling_hrps( + zp_constants::regtest::HRP_SAPLING_EXTENDED_SPENDING_KEY, + zp_constants::regtest::HRP_SAPLING_EXTENDED_FULL_VIEWING_KEY, + zp_constants::regtest::HRP_SAPLING_PAYMENT_ADDRESS, + ); }