zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add a metric for binding sig errors 

But keep ignoring those errors until we fix binding sigs in #1939
This commit is contained in:
teor 2021-03-25 11:12:32 +10:00 committed by Deirdre Connolly
parent 0bad6bc615
commit 83bdc1a9f3
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
zebra-consensus/src/transaction.rs
View File

@ -264,13 +264,28 @@ where
}
let bvk = shielded_data.binding_verification_key(*value_balance);
// TODO: enable async verification and remove this block - #1939
{
let item: zebra_chain::primitives::redjubjub::batch::Item = (bvk, shielded_data.binding_sig, &shielded_sighash).into();
item.verify_single().unwrap_or_else(|binding_sig_error| {
let binding_sig_error = binding_sig_error.to_string();
tracing::warn!(%binding_sig_error, "ignoring");
metrics::counter!("zebra.error.sapling.binding",
1,
"kind" => binding_sig_error);
});
// Ignore errors until binding signatures are fixed
//.map_err(|e| BoxError::from(Box::new(e)))?;
}
let _rsp = redjubjub_verifier
.ready_and()
.await?
.call((bvk, shielded_data.binding_sig, &sighash).into())
.call((bvk, shielded_data.binding_sig, &shielded_sighash).into())
.boxed();
// Disable pending sighash check #1377
// TODO: stop ignoring binding signature errors - #1939
// async_checks.push(rsp);
}