From 8d58dd804f36b3fd6b2b80e6afab3462988dcf2b Mon Sep 17 00:00:00 2001 From: Henry de Valence Date: Wed, 5 Feb 2020 12:31:03 -0800 Subject: [PATCH] Note that tracing causes clippy false positives Thanks @hawkw for pointing this out. --- zebra-network/src/lib.rs | 4 ++++ zebra-network/src/peer_set/set.rs | 1 - zebra-network/src/protocol/external/codec.rs | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/zebra-network/src/lib.rs b/zebra-network/src/lib.rs index e0bc5b78e..021c8d027 100644 --- a/zebra-network/src/lib.rs +++ b/zebra-network/src/lib.rs @@ -28,6 +28,10 @@ #![deny(missing_docs)] +// Tracing causes false positives on this lint: +// https://github.com/tokio-rs/tracing/issues/553 +#![allow(clippy::cognitive_complexity)] + #[macro_use] extern crate pin_project; #[macro_use] diff --git a/zebra-network/src/peer_set/set.rs b/zebra-network/src/peer_set/set.rs index 1dbf2d439..6db759e68 100644 --- a/zebra-network/src/peer_set/set.rs +++ b/zebra-network/src/peer_set/set.rs @@ -220,7 +220,6 @@ where type Future = Pin> + Send + 'static>>; - #[allow(clippy::cognitive_complexity)] fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll> { // Process peer discovery updates. let _ = self.poll_discover(cx)?; diff --git a/zebra-network/src/protocol/external/codec.rs b/zebra-network/src/protocol/external/codec.rs index 1cbb2bc44..9006701b7 100644 --- a/zebra-network/src/protocol/external/codec.rs +++ b/zebra-network/src/protocol/external/codec.rs @@ -293,7 +293,6 @@ impl Decoder for Codec { type Item = Message; type Error = Error; - #[allow(clippy::cognitive_complexity)] fn decode(&mut self, src: &mut BytesMut) -> Result, Self::Error> { use Error::Parse; match self.state {