Commit Graph

4 Commits

Author SHA1 Message Date
teor 694390c50b
change(dev): Add CHANGELOG checks to PR review template (#5202)
* Ask PR reviewer to check name, labels, and CHANGELOG

* Re-phrase extra CHANGELOG info
2022-09-21 18:47:28 +00:00
teor 3d2fb1c13e
Update GitHub and RFC templates based on retrospectives (#2242)
Updates:
- GitHub Issue templates
- GitHub PR templates
- RFC template

Focusing on:
- consensus rule / network reference sections
- design sections
- review/test checklist

Process changes:
- add new team members to RFC approval
- change RFC approval to "most of the team"

And general cleanup:
- delete docs from the checklist, because we now `warn(missing_docs)`
- shorter explanations
- consistent headings
- consistent order
- consistent formatting
2021-06-04 14:40:53 +10:00
teor adbd338d6d
Add Review and Follow Up to PR Template (#1235)
* Add review guidelines to the default PR template

* Apply suggestions

Co-authored-by: teor <teor@riseup.net>

* Add a Follow Up Work section to the PR template

* Mention design RFCs in the PR template

* Put key PR review questions in bold

* Tweak PR review "skip task" process

* Update .github/pull_request_template.md

Co-authored-by: teor <teor@riseup.net>

* Shorter alternative pull request template

Add Review and Follow Up sections
Add a checklist for documentation and tests

Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
2020-10-30 14:42:04 -07:00
teor 8def574bc2 Activate the standard pull request template by default
Non-default pull request templates can be used via the CLI,
or a URL query parameter:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/about-automation-for-issues-and-pull-requests-with-query-parameters
2020-10-17 17:20:41 -04:00