e2989e3edf
Update zebra-chain/src/orchard/keys.rs
...
Co-authored-by: teor <teor@riseup.net>
2021-04-30 00:48:23 -04:00
e4fe8bb320
Update zebra-chain/src/orchard/note/nullifiers.rs
...
Co-authored-by: teor <teor@riseup.net>
2021-04-30 00:48:23 -04:00
81da8363a8
Update zebra-chain/src/orchard/sinsemilla.rs
...
Co-authored-by: teor <teor@riseup.net>
2021-04-30 00:48:23 -04:00
dbd2ce6dd8
Update zebra-chain/src/orchard/sinsemilla.rs
...
Co-authored-by: teor <teor@riseup.net>
2021-04-30 00:48:23 -04:00
ebe0c002a9
Update zebra-chain/src/orchard/sinsemilla.rs
...
Co-authored-by: teor <teor@riseup.net>
2021-04-30 00:48:23 -04:00
8461c2153e
Update diversify_hash and its use to match spec updates
2021-04-30 00:48:23 -04:00
73e0f4f98a
Orchard: fix some tests, etc
2021-04-30 00:48:23 -04:00
87f65b8b01
Orchard: update merkle_crh_orchard to use the appropriate l=10 bits, not 6
2021-04-30 00:48:23 -04:00
1ff8874b8d
Orchard: remove unused imports, more warn(missing_docs) lint to orchard for now
2021-04-30 00:48:23 -04:00
5ede33b231
Orchard: update nullifiers
2021-04-30 00:48:23 -04:00
c892b93f61
Orchard: update merkle_crh_orchard correctly
2021-04-30 00:48:23 -04:00
218bb9b7c2
Orchard: remove unused imports
2021-04-30 00:48:23 -04:00
f3501333b7
Orchard: tidy
2021-04-30 00:48:23 -04:00
1c903cab0f
Orchard: fix into() call inside extract_x
2021-04-30 00:48:23 -04:00
94edc90975
Orchard: derive serde::{Deserialize, Serialize} by default on redpallas::VerificationKeyBytes
2021-04-30 00:48:23 -04:00
d11a4419ac
Orchard: add a serde helper for pallas::Base
2021-04-30 00:48:23 -04:00
41a41db923
Sapling: use try_from turbofish inside prf_ock
2021-04-30 00:48:23 -04:00
0351e6481d
Orchard: tidy keys
2021-04-30 00:48:23 -04:00
e85359c756
Orchard: tidy
2021-04-30 00:48:23 -04:00
d3f0b226e6
Orchard: tidy nullifiers
2021-04-30 00:48:23 -04:00
b93a71c779
Orchard: borrow local.bytes for pallas::Affine serde helper
2021-04-30 00:48:23 -04:00
009e1dd37e
Orchard: some Action (de)serialization fixes
2021-04-30 00:48:23 -04:00
f3cf6966a5
Orchard: tidy commitments etc
2021-04-30 00:48:23 -04:00
cb9d6956d7
Orchard: Fix trait imports and Arbitrary for Action
2021-04-30 00:48:23 -04:00
981080f049
Orchard: Tidy Debug impl's for keys, cast a pallas::Base into a pallas::Scalar
2021-04-30 00:48:23 -04:00
6e51671c93
Tidy prf's
2021-04-30 00:48:23 -04:00
120b065a94
Action should use VerificationKeyBytes
2021-04-30 00:48:23 -04:00
570ad6e914
Add redpallas::signing_key::SigningKey stub
2021-04-30 00:48:23 -04:00
01fed3e0f3
Tidy impl From<SpendingKey> for IvkCommitRandomness
2021-04-30 00:48:23 -04:00
bd4e5e1f38
Cleanup
2021-04-30 00:48:23 -04:00
df1ecc72b1
Most things are filled in, including a guess at Pallas-based Mixing Pedersen Hash
2021-04-30 00:48:23 -04:00
23e391894b
Tidy
2021-04-30 00:48:23 -04:00
de051c727c
orchard: DiversifierKey is a newtype refinement of 32 bytes
2021-04-30 00:48:23 -04:00
fd29708ecc
orchard: derive IncomingViewingKey from FullViewingKey
...
Includes sinsemilla commit and short commit
2021-04-30 00:48:23 -04:00
6e1d2f1fb1
orchard: impl From<SpendingKey> for NullifierDerivingKey
2021-04-30 00:48:23 -04:00
f50d8697d4
impl orchard SpendingKey::new()
2021-04-30 00:48:23 -04:00
20abeda04b
Add sapling prf_ock and generate_trapdoor
2021-04-30 00:48:23 -04:00
c3e40d73cf
Bunch more work implementing orchard, porting from sapling where applicable
2021-04-30 00:48:23 -04:00
40383b2741
Partway done with typing out Orchard chain types
2021-04-30 00:48:23 -04:00
a63c2e8c40
Update book/src/dev/proptests.md
...
Co-authored-by: Pili Guerra <mpguerra@users.noreply.github.com>
2021-04-29 18:29:53 -04:00
661a8d57dc
Explain how to derive arbitrary impls
2021-04-29 18:29:53 -04:00
f33db69267
Remove broken ci-success check
...
Previously, Zebra made ci-success a required check for merges to main. And then we made ci-success depend on a bunch of other CI checks.
But this doesn't work as expected, because if the dependent checks fail, ci-success is skipped, and the branch protection rules allow the branch to be merged to main.
2021-04-29 18:28:47 -04:00
7e395298f1
Just run builds on ubuntu stable
...
But keep the tests across ubuntu, macOS, Windows x Rust stable, beta
2021-04-30 07:35:46 +10:00
d0e6597fec
Use minimal cargo components in docs workflow
2021-04-30 07:35:46 +10:00
ea4d3b23f9
Use minimal cargo components in CI
2021-04-30 07:35:46 +10:00
b52fbae30f
Fix a bad merge in #2075 ( #2085 )
...
Also tweak a constant name, an import, and a comment.
2021-04-29 17:47:10 +10:00
9fc2388fbc
Parse ConsensusBranchId into NetworkUpgrade for transaction v5 ( #2075 )
...
* add consensus_branch_id field to transaction v5
* clippy
* rustfmt
* replace consensus_branch_id with network_upgrade
* remove unintended test files
* change method name
* some clanups
* add network_upgrade as a constant in tests
* use std in created function
* add comment to manual arbitrary impl
* create custom strategy to deal with NetworkUpgrade
* Add a missing TODO comment
Co-authored-by: teor <teor@riseup.net>
2021-04-29 01:55:29 +00:00
b70b74c93a
Revert "build(deps): bump vergen from 5.1.2 to 5.1.5" ( #2078 )
...
This reverts commit 555805171c
2021-04-28 09:38:10 -04:00
75d29aca24
Add V5 transparent and sapling to transaction::check, add missing coinbase PrevOut check ( #2070 )
...
* validate sapling v5 tx
* Make itertools dependency optional
We only need itertools when the `proptest-impl` feature is enabled.
* Check if V4 and V5 coinbase transactions contain PrevOut transparent inputs
This is a bugfix on V4 transaction validation. The PrevOut consensus
rule was not explicitly stated in the Zcash spec until April 2021.
(But it was implied by Bitcoin, and partially implemented by Zebra.)
Also do the shielded sapling input check for V5 transactions.
* Add spec and orchard TODOs to has_inputs_and_outputs
Also make the variable names match the spec.
* Sort transaction functions to match v5 data order
* Simplify transaction input and output checks
Move counts or iterators into `Transaction` methods, so we can remove
duplicate code, and make the consensus rule logic clearer.
* Update sapling_balances_match for Transaction v5
- Quote from the spec
- Explain why the function is redunant for v5
- Rename the function so it's clear that it is sapling-specific
Co-authored-by: teor <teor@riseup.net>
2021-04-28 10:43:00 +10:00
555805171c
build(deps): bump vergen from 5.1.2 to 5.1.5
...
Bumps [vergen](https://github.com/rustyhorde/vergen ) from 5.1.2 to 5.1.5.
- [Release notes](https://github.com/rustyhorde/vergen/releases )
- [Commits](https://github.com/rustyhorde/vergen/compare/5.1.2...5.1.5 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-27 10:26:26 -04:00
Deirdre Connolly
Alfredo Garcia
teor
dependabot[bot]