teor
3892894ffa
Call ClientRequest.tx.send() even if there is an error
...
Previously, tx would be dropped before send if:
- the success case would have used tx to wait for further messages,
- but the response was actually an error.
Instead, send the error on `tx` and call `fail_with()` using the same
error.
To support this change, allow `fail_with()` to take a `PeerError` or a
`SharedPeerError`.
2021-01-06 13:07:23 -08:00
teor
28f3186182
Mark ClientRequest and State::AwaitingResponse as must_use
2021-01-06 13:07:23 -08:00
dependabot[bot]
d67de58554
build(deps): bump secp256k1 from 0.19.0 to 0.20.0
...
Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1 ) from 0.19.0 to 0.20.0.
- [Release notes](https://github.com/rust-bitcoin/rust-secp256k1/releases )
- [Changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-bitcoin/rust-secp256k1/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2021-01-04 11:05:43 -05:00
teor
b1f14f47c6
Rewrite GetData handling to match the zcashd implementation ( #1518 )
...
* Rewrite GetData handling to match the zcashd implementation
`zcashd` silently ignores missing blocks, but sends found transactions
followed by a `NotFound` message:
e7b425298f/src/main.cpp (L5497)
This is significantly different to the behaviour expected by the old
Zebra connection state machine, which expected `NotFound` for blocks.
Also change Zebra's GetData responses to peer request so they ignore
missing blocks.
* Stop hanging on incomplete transaction or block responses
Instead, if the peer sends an unexpected block, unexpected transaction,
or NotFound message:
1. end the request, and return a partial response containing any items
that were successfully received
2. if none of the expected blocks or transactions were received, return
an error, and close the connection
2021-01-04 13:25:35 +10:00
Deirdre Connolly
f9eb4a28df
Enable the metrics endpoint inside Docker.build by default
2021-01-02 18:24:02 -05:00
dependabot[bot]
6436a09be6
build(deps): bump serde_json from 1.0.60 to 1.0.61
...
Bumps [serde_json](https://github.com/serde-rs/json ) from 1.0.60 to 1.0.61.
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.60...v1.0.61 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-30 21:57:27 -05:00
Deirdre Connolly
f5b3412a50
Get PathBuf even if /zebrad-cache exists for create_cached_database_height()
2020-12-30 21:32:55 -05:00
dependabot[bot]
f2a21ac67c
build(deps): bump thiserror from 1.0.22 to 1.0.23
...
Bumps [thiserror](https://github.com/dtolnay/thiserror ) from 1.0.22 to 1.0.23.
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.22...1.0.23 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-28 16:17:00 -05:00
dependabot[bot]
b2a0048968
build(deps): bump serde-big-array from 0.3.0 to 0.3.1
...
Bumps [serde-big-array](https://github.com/est31/serde-big-array ) from 0.3.0 to 0.3.1.
- [Release notes](https://github.com/est31/serde-big-array/releases )
- [Commits](https://github.com/est31/serde-big-array/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-28 15:50:29 -05:00
dependabot[bot]
d5f4b55962
build(deps): bump toml from 0.5.7 to 0.5.8
...
Bumps [toml](https://github.com/alexcrichton/toml-rs ) from 0.5.7 to 0.5.8.
- [Release notes](https://github.com/alexcrichton/toml-rs/releases )
- [Commits](https://github.com/alexcrichton/toml-rs/compare/0.5.7...0.5.8 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-26 19:01:18 -05:00
teor
6cd7f255d4
Cleanup acceptance tests using utility functions ( #1537 )
...
And add a missing network check.
2020-12-20 09:06:18 +10:00
Jane Lusby
cfc339e8ea
export new precompute api in zebra-script ( #1493 )
...
* export new precompute api in zebra-script
* remove old API in favor of precompute API
* add multi use test cases and bump version
* update implementation to actually match henry's design
* Add safety comment for zebra-script
Co-authored-by: teor <teor@riseup.net>
2020-12-18 13:18:28 +10:00
teor
3355be4c41
Improve the random port function docs ( #1536 )
...
Also:
* rename the function
* create an alternative function for the common case.
2020-12-18 11:32:33 +10:00
Deirdre Connolly
3266265f7f
Update testnet sync test
2020-12-16 20:36:31 -05:00
Deirdre Connolly
e004d40ac1
Update cached state to @419200 on mainnet, not past it
2020-12-16 17:03:50 -05:00
Deirdre Connolly
fbca3c7434
Remove testnet --container-mount-disk for now
2020-12-16 14:45:07 +10:00
Deirdre Connolly
4d387efe1d
Disable tesnet post-Sapling sync tests for now
2020-12-16 14:45:07 +10:00
Deirdre Connolly
93b91769d6
Update stateful disks for post-Sapling-activation sync tests
2020-12-16 14:45:07 +10:00
teor
69fcf64d6c
Disable issue URLs for "duplicate hash" errors ( #1517 )
...
In our README, we tell users to ignore these errors, so we should also
disable the issue URL.
Also include the hash in the error. (We don't want the span active for
all messages, we just want the hash in the error.)
2020-12-16 08:14:42 +10:00
teor
008577561c
Use a sleep future in the async acceptance tests
...
And wait slightly longer for `zebrad` to launch.
These fixes should reduce the failure rate of the acceptance tests on
busy machines.
2020-12-16 08:09:48 +10:00
teor
1b6bf7f105
Use random ports in the acceptance tests
...
This change avoids errors when tests are cancelled and re-run within a
short period of time, for example, using `cargo watch`.
It introduces a slight risk of port conflicts between the endpoint tests,
and with (ephemeral) ports used by other services. The risk of conflicts
across 2 tests is very low, and tests should be run in an isolated
environment on busy servers.
2020-12-16 08:09:48 +10:00
dependabot[bot]
5f8891df88
build(deps): bump indexmap from 1.6.0 to 1.6.1
...
Bumps [indexmap](https://github.com/bluss/indexmap ) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/bluss/indexmap/releases )
- [Commits](https://github.com/bluss/indexmap/compare/1.6.0...1.6.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-15 16:56:00 -05:00
Alfredo Garcia
41833340c1
downgrade remaining version strings to 1.0.0-alpha.0 ( #1488 )
2020-12-15 11:21:00 +10:00
Alfredo Garcia
436ce00fc2
Move height check to NetworkUpgrade ( #1505 )
...
* move height check to NetworkUpgrade
* refactor the max block time height check
Co-authored-by: teor <teor@riseup.net>
2020-12-15 08:30:38 +10:00
Alfredo Garcia
7468dae88d
add commands and logs section to bug template ( #1506 )
...
* add commands and logs section to bug template
Co-authored-by: teor <teor@riseup.net>
2020-12-15 07:45:10 +10:00
teor
b8646fa78e
Depend on a tokio commit with the time wheel panic fix
...
Updates the tokio dependency to the commit that merged
tokio-rs/tokio#3229, which should fix the time wheel panic in #1452 .
2020-12-13 22:27:22 -05:00
teor
d482900e7f
Remove a redundant pattern match
...
Identified by clippy's redundant_pattern_match lint.
2020-12-13 22:10:05 -05:00
Alfredo Garcia
d725eeb4d6
Add documentation to zebra-utils and checkpoint generation ( #1491 )
...
* create readme for utils and checkpoints
* add link to checkpoint usage to book
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Co-authored-by: teor <teor@riseup.net>
2020-12-14 11:34:22 +10:00
teor
66e300be0a
Cleanup the ExpandedDifficulty PartialOrd impl ( #1466 )
2020-12-14 11:25:50 +10:00
teor
394634c933
Remove a redundant argument ( #1456 )
2020-12-14 11:05:31 +10:00
teor
8e2f08221f
Add peer set tracing and unreachable panics ( #1468 )
...
Add some extra tracing and panics to double-check our
assumptions about the peer set state machine.
2020-12-14 11:00:39 +10:00
Deirdre Connolly
2d1698a120
Comment out Sentry stacktraces for now
...
While panic = abort, Sentry collects the same one-line stack trace for all panics,
making it incorrectly dedupe different errors into one.
2020-12-12 13:26:52 -05:00
dependabot[bot]
6ca6d38c5c
build(deps): bump tokio-util from 0.5.0 to 0.5.1
...
Bumps [tokio-util](https://github.com/tokio-rs/tokio ) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases )
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-util-0.5.0...tokio-util-0.5.1 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-12 10:57:11 -05:00
Pili Guerra
f6ff4d2255
Fix typo ( #1504 )
2020-12-11 14:13:45 +01:00
teor
3c267f9c9d
README: clang and libclang are different
2020-12-10 23:24:30 -05:00
Alfredo Garcia
9c711c42c9
Rename State method names ( #1500 )
...
* rename `StateService::chain` to `any_ancestor_blocks`
* rename `StateService::tip` to `best_tip`
* rename `NonFinalizedState::tip` to `best_tip`
* rename `StateService::depth` to `best_depth`
* rename `StateService::transaction` to `best_transaction`
* rename `NonFinalizedState::transaction` to `best_transaction`
* rename `StateService::find_chain_intersection` to `find_best_chain_intersection`
* Rename `StateService::collect_chain_hashes` to `collect_best_chain_hashes`
* rename `StateService::find_chain_hashes` to `find_best_chain_hashes`
* rename `StateService::utxo` to `any_utxo`
* rename `NonFinalizedState::utxo` to `any_utxo`
* rename `NonFinalizedState::block_by_hash` to `any_block_by_hash`
* update `any_ancestor_blocks` comment
Co-authored-by: teor <teor@riseup.net>
2020-12-11 10:23:26 +10:00
dependabot[bot]
e537926e7b
build(deps): bump serde from 1.0.117 to 1.0.118
...
Bumps [serde](https://github.com/serde-rs/serde ) from 1.0.117 to 1.0.118.
- [Release notes](https://github.com/serde-rs/serde/releases )
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.117...v1.0.118 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-12-10 15:16:15 -05:00
teor
d0b3577968
Simplify C++ compiler dependency
...
We might as well prefer clang, but mention alternatives
2020-12-09 21:54:39 -05:00
teor
34481a28b4
Add a "without --locked" troubleshooting hint
...
We added "--locked" to the build instructions, but forgot to
update the troubleshooting hints.
2020-12-09 19:53:52 -05:00
Deirdre Connolly
cff28f7ac8
Use the commit sha as the sentry release
2020-12-09 13:06:18 -05:00
Jane Lusby
400213e2b3
integrate sentry with our existing panic reporting logic
2020-12-09 13:06:18 -05:00
Deirdre Connolly
f1ec1d626d
Tidy for now
2020-12-09 13:06:18 -05:00
Deirdre Connolly
44e1051dee
Debug
2020-12-09 13:06:18 -05:00
Deirdre Connolly
8b268e3f71
Don't keep guard around
2020-12-09 13:06:18 -05:00
Deirdre Connolly
25f6fd25b3
Test catching panic
2020-12-09 13:06:18 -05:00
Deirdre Connolly
6a17549945
Try sentry-tracing integration
2020-12-09 13:06:18 -05:00
Deirdre Connolly
8f958e3c05
apt-get install ca-certificates for the release image stage
2020-12-09 13:06:18 -05:00
Deirdre Connolly
c03a3a2606
Pull DSN from runtime env, enable Sentry debug mode with RUST_LOG=debug
2020-12-09 13:06:18 -05:00
Deirdre Connolly
1fb9198248
Can't pass feature flags at the root of the workspace
2020-12-09 13:06:18 -05:00
Deirdre Connolly
27e42f4ed5
Set up Sentry error collection via a feature flag
2020-12-09 13:06:18 -05:00