teor
48497d4857
Ignore sync errors when the block is already verified ( #980 )
...
* Ignore sync errors when the block is already verified
If we get an error for a block that is already in our state, we don't
need to restart the sync. It was probably a duplicate download.
Also:
Process any ready tasks before reset, so the logs and metrics are
up to date. (But ignore the errors, because we're about to reset.)
Improve sync logging and metrics during the download and verify task.
* Remove duplicate hashes in logs
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
* Log the sync hash span at warn level
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
2020-09-04 08:13:00 +10:00
teor
437549d8e9
Always drop the final hash in peer responses ( #991 )
...
To workaround a zcashd bug that squashes responses together.
2020-09-04 08:09:34 +10:00
teor
c770daa51f
If the first ExtendTips hash is bad, discard it and re-check ( #992 )
2020-09-04 08:08:19 +10:00
teor
8a4245daab
Improve zebra-consensus logging and metrics ( #989 )
2020-09-04 08:06:21 +10:00
Alfredo Garcia
5485f4429a
Add config path to acceptance tests ( #946 )
...
* add and apply config mode to get_child
* remove option to read config from current directory
* remove argument from get_child
2020-09-03 13:13:23 -07:00
teor
d3f7af7114
Add log filters which provide block info
...
These filters use zcash-cli to annotate hashes with the corresponding
block info.
They are useful when the local zebrad instance hasn't downloaded or
parsed the blocks in its logs, or when the zebrad logs just provide a
hash. The filter provides the height, time, previous, and next blocks.
2020-09-02 12:12:58 -04:00
teor
d3b6a73f7b
Improve zebra-state logging and metrics
2020-09-02 12:09:50 -04:00
dependabot[bot]
753b93d8a3
build(deps): bump indexmap from 1.5.1 to 1.5.2
...
Bumps [indexmap](https://github.com/bluss/indexmap ) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/bluss/indexmap/releases )
- [Commits](https://github.com/bluss/indexmap/compare/1.5.1...1.5.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-02 12:07:01 -04:00
teor
b5c653ed93
Use ok_or for constants, rather than a redudant closure
...
* Use ok_or for constants in zebra-network
* Use ok_or for constants in zebra-consensus
2020-09-02 14:26:26 +10:00
Jane Lusby
88557ddd0a
address more comments
2020-09-01 21:01:38 -04:00
Jane Lusby
d933abeebf
fix typo
2020-09-01 21:01:38 -04:00
Jane Lusby
96c8809348
Implement Inventory Tracking RFC ( #963 )
...
* Add .cargo to the gitignore file
* Implement Inventory Tracking RFC
* checkpoint
* wire together the inventory registry
* add comment documenting condition
* make inventory registry optional
2020-09-01 14:28:54 -07:00
Henry de Valence
f91b91b6d8
network: clarify comment on Default for handshake::Builder
...
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
2020-09-01 13:56:00 -07:00
Henry de Valence
fddba7a336
network: remove handshake::Builder::with_addr
...
Use the listen_addr field already specified in the config.
Also, derive Clone for Handshake<S>.
Co-authored-by: Jane Lusby <jane@zfnd.org>
2020-09-01 13:56:00 -07:00
Henry de Valence
a5b6f39850
network: don't leak our exact time skew in handshakes.
2020-09-01 13:56:00 -07:00
Henry de Valence
1b5a824584
network: fix bug in BIP37 relay flag handling.
...
The relay flag in the version message is used in conjunction with BIP37 to
receive bloom-filtered transactions. When it is set to false, transactions are
not relayed until a bloom filter is set. Since we don't implement BIP37 (it's
not useful for shielded transactions), this means we'll never receive
transactions.
2020-09-01 13:56:00 -07:00
Henry de Valence
60a0b8c382
network: change Handshake::new to a Builder.
...
This allows more detailed control over the handshake parameters.
2020-09-01 13:56:00 -07:00
Deirdre Connolly
f967e29d13
Move coverage step to common workflow for PRs and pushes to main ( #984 )
...
So we can consistently collect coverage data on the default branch, which CodeCov needs
to compare branch coverage and line data against.
2020-09-01 13:47:34 -07:00
Jane Lusby
ffdec0cb23
Remove in-memory state service ( #974 )
...
* Remove in-memory state service
* make the config compatible with toml again
* checkpoint commit to see how much I still have to revert
* back to the starting point...
* remove unused dependency
* reorganize error handling a bit
* need to make a new color-eyre release now
* reorder again because I have problems
* remove unnecessary helpers
* revert changes to config loading
* add back missing space
* Switch to released color-eyre version
* add back missing newline again...
* improve error message on unix when terminated by signal
* add context to last few asserts in acceptance tests
* instrument some of the helpers
* remove accidental extra space
* try to make this compile on windows
* reorg platform specific code
* hide on_disk module and fix broken link
2020-09-01 12:39:04 -07:00
teor
3fdfcb3179
fix: remove old tips that are behind new tips
...
This change makes sync less reliant on the exact order of ObtainTips and
ExtendTips responses.
2020-09-01 11:42:48 -04:00
teor
d7e32b68e5
fix: Split a clippy allow, so its comment is clearer
2020-09-01 11:40:18 -04:00
teor
a6d6e65940
fix: fix the flamegraph module comment
2020-09-01 11:40:18 -04:00
dependabot[bot]
656a84fa55
build(deps): bump color-eyre from 0.5.1 to 0.5.2
...
Bumps [color-eyre](https://github.com/yaahc/color-eyre ) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/yaahc/color-eyre/releases )
- [Changelog](https://github.com/yaahc/color-eyre/blob/master/CHANGELOG.md )
- [Commits](https://github.com/yaahc/color-eyre/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-01 11:39:43 -04:00
teor
7931766c84
fix: Improve checkpoint diagnostics
...
Improve metrics and logging when the checkpoint verifier is waiting for
more blocks.
2020-09-01 05:15:52 -04:00
Henry de Valence
3ed967bcf8
deps: use x25519-dalek's new PartialEq, Eq methods
2020-08-31 13:30:14 -07:00
Ramana Venkata
448250f901
Deduplicate test config defaults ( #971 )
...
Fixes #967
2020-08-31 12:43:43 -07:00
Ramana Venkata
ad0001f7f7
zebra-state: Add support for temporary sled databases ( #939 )
...
* Test config with persistent sled database
* Test ephemeral config
* Add misconfigured ephemeral test
2020-08-31 18:32:55 +10:00
Henry de Valence
d25cc20319
refer to CONTRIBUTING.md in rfc template
2020-08-31 00:58:50 -04:00
Henry de Valence
43c9441a73
Update .github/PULL_REQUEST_TEMPLATE/pull_request.md
...
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2020-08-31 00:58:50 -04:00
Henry de Valence
e1e299906f
rfc: add number to script verification rfc
2020-08-31 00:58:50 -04:00
Henry de Valence
b212becb67
Add issue and PR templates, document RFC process
2020-08-31 00:58:50 -04:00
Deirdre Connolly
50af921d5d
Use zebra favicon for zebra.zfnd.org book
2020-08-29 03:33:31 -04:00
Jane Lusby
a7b7961ef7
Add .cargo to the gitignore file
2020-08-28 20:14:12 -04:00
Henry de Valence
4561f1d25b
rfc: initial inventory tracking ( #952 )
...
* rfc: initial inventory tracking
This just describes the design, not the design alternatives.
* rfc: finish inventory tracking rfc
Also assign it #3 . The async script verification RFC should have had a number
assigned before merging but it didn't. I don't want to fix that in this PR
because I don't want those changes to block on each other. The fix is to (1)
document the RFC flow better and (2) add issue templates for RFCs.
* rfc: touch up inventory tracking rfc
* rfc: prune inventory entries generationally.
Based on a suggestion by @yaahc.
* Update book/src/dev/rfcs/0003-inventory-tracking.md
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
2020-08-28 14:19:18 -07:00
dependabot[bot]
f7fe7b9053
build(deps): bump secp256k1 from 0.17.2 to 0.19.0
...
Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1 ) from 0.17.2 to 0.19.0.
- [Release notes](https://github.com/rust-bitcoin/rust-secp256k1/releases )
- [Changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-bitcoin/rust-secp256k1/compare/secp256k1-0.17.2...secp256k1-0.19.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-08-28 17:09:39 -04:00
Deirdre Connolly
447398691a
Make SaplingNoteCommitmentTree private for now
2020-08-28 04:46:31 -04:00
Deirdre Connolly
b467a75e08
Rename tree::*NoteTreeRootHash to tree::Root
2020-08-28 04:46:31 -04:00
Deirdre Connolly
31d98248ab
Expose note types and make note modules private
2020-08-28 04:46:31 -04:00
Deirdre Connolly
d795b8bfd9
Add memo to Note, remove NotePlaintext
2020-08-28 04:46:31 -04:00
Deirdre Connolly
5258e891dc
Rename sapling::note::OutCiphertext to WrappedNoteKey
2020-08-28 04:46:31 -04:00
Deirdre Connolly
cfc60936ce
Little more detail to sapling::note::EncryptedNote docstring
2020-08-28 04:46:31 -04:00
Deirdre Connolly
d6eecbe935
Rename Sprout EncyptedCiphertext to EncryptedNote
2020-08-28 04:46:31 -04:00
Deirdre Connolly
99b4a400af
Make find_group_hash() pub(super)
2020-08-28 04:46:31 -04:00
Deirdre Connolly
7a92496244
Make RANDOMNESS_BEACON_URS pub(super)
2020-08-28 04:46:31 -04:00
Deirdre Connolly
c027cfc0d2
Rename SaplingShieldedAddress to Address, make address & commitment private, export their structs
2020-08-28 04:46:31 -04:00
Deirdre Connolly
df89a049cb
Rename EncryptedCiphertext to EncryptedNote
2020-08-28 04:46:31 -04:00
dependabot[bot]
005ec6c57c
build(deps): bump structopt from 0.3.16 to 0.3.17 ( #953 )
...
Bumps [structopt](https://github.com/TeXitoi/structopt ) from 0.3.16 to 0.3.17.
- [Release notes](https://github.com/TeXitoi/structopt/releases )
- [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/TeXitoi/structopt/compare/v0.3.16...v0.3.17 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-26 11:59:04 -07:00
dependabot[bot]
8e9019a847
build(deps): bump jubjub from 0.3.0 to 0.4.0
...
Bumps [jubjub](https://github.com/zkcrypto/jubjub ) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/zkcrypto/jubjub/releases )
- [Changelog](https://github.com/zkcrypto/jubjub/blob/master/RELEASES.md )
- [Commits](https://github.com/zkcrypto/jubjub/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2020-08-25 17:35:54 -04:00
Alfredo Garcia
780e675517
change env syntax
2020-08-24 14:57:01 -04:00
Alfredo Garcia
6dd859e0cf
add RUST_BACKTRACE to CI tests
2020-08-24 14:57:01 -04:00