AMT-Cheif
/
Stylet
mirror of https://github.com/AMT-Cheif/Stylet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid binding to IEnumerable in MessageBoxView 

According to dotMemory, this can cause a memory leak
This commit is contained in:
Antony Male 2015-03-16 13:02:56 +00:00
parent 0e48896a6d
commit 63a9c4a70f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Stylet/MessageBoxViewModel.cs
View File

@ -127,7 +127,7 @@ namespace Stylet
this.DisplayName = caption; this.DisplayName = caption;
this.Icon = icon; this.Icon = icon;
var buttonList = new List<LabelledValue<MessageBoxResult>>(); var buttonList = new BindableCollection<LabelledValue<MessageBoxResult>>();
this.ButtonList = buttonList; this.ButtonList = buttonList;
foreach (var val in ButtonToResults[buttons]) foreach (var val in ButtonToResults[buttons])
{ {
@ -165,7 +165,7 @@ namespace Stylet
/// <summary> /// <summary>
/// Gets or sets the list of buttons which are shown in the View. /// Gets or sets the list of buttons which are shown in the View.
/// </summary> /// </summary>
public IEnumerable<LabelledValue<MessageBoxResult>> ButtonList { get; protected set; } public IObservableCollection<LabelledValue<MessageBoxResult>> ButtonList { get; protected set; }
/// <summary> /// <summary>
/// Gets or sets the item in ButtonList which is the Default button /// Gets or sets the item in ButtonList which is the Default button