AMT-Cheif
/
drift
mirror of https://github.com/AMT-Cheif/drift.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add tests for null sorting on asc/desc factories

This commit is contained in:
Simon Binder 2022-08-28 22:39:07 +02:00
parent b399db78e3
commit 80f8546122
No known key found for this signature in database
GPG Key ID: 7891917E4147B8C0
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/pages/docs/Examples/existing_databases.md
View File

@ -46,7 +46,6 @@ import 'package:drift/drift.dart';
import 'package:flutter/services.dart' show rootBundle; import 'package:flutter/services.dart' show rootBundle;
import 'package:path/path.dart' as p; import 'package:path/path.dart' as p;
LazyDatabase _openConnection() { LazyDatabase _openConnection() {
return LazyDatabase(() async { return LazyDatabase(() async {
// put the database file, called db.sqlite here, into the documents folder // put the database file, called db.sqlite here, into the documents folder

4
drift/lib/src/runtime/query_builder/components/order_by.dart
View File

@ -53,7 +53,7 @@ class OrderingTerm extends Component {
/// Creates an ordering term that sorts for ascending values /// Creates an ordering term that sorts for ascending values
/// of [expression] and the [nulls]. /// of [expression] and the [nulls].
factory OrderingTerm.asc(Expression expression, [NullsOrder? nulls]) { factory OrderingTerm.asc(Expression expression, {NullsOrder? nulls}) {
return OrderingTerm( return OrderingTerm(
expression: expression, expression: expression,
mode: OrderingMode.asc, mode: OrderingMode.asc,
@ -63,7 +63,7 @@ class OrderingTerm extends Component {
/// Creates an ordering term that sorts for descending values /// Creates an ordering term that sorts for descending values
/// of [expression] and the [nulls]. /// of [expression] and the [nulls].
factory OrderingTerm.desc(Expression expression, [NullsOrder? nulls]) { factory OrderingTerm.desc(Expression expression, {NullsOrder? nulls}) {
return OrderingTerm( return OrderingTerm(
expression: expression, expression: expression,
mode: OrderingMode.desc, mode: OrderingMode.desc,

10
drift/test/database/statements/order_by_test.dart
View File

@ -75,4 +75,14 @@ void main() {
argThat(isEmpty), argThat(isEmpty),
)); ));
}); });
test('works with helper factories', () {
final table = db.users;
expect(OrderingTerm.asc(table.id), generates('id ASC'));
expect(OrderingTerm.asc(table.id, nulls: NullsOrder.last),
generates('id ASC NULLS LAST'));
expect(OrderingTerm.desc(table.id, nulls: NullsOrder.first),
generates('id DESC NULLS FIRST'));
});
} }