Don't generate double-quoted string literals

moor/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.4.1
+
+- Don't generate double quoted string literals in date time functions
+
 ## 2.4.0
 
 - Support aggregate expressions and `group by` in the Dart api

moor/lib/src/runtime/query_builder/expressions/datetimes.dart

@@ -99,9 +99,9 @@ class _StrftimeSingleFieldExpression extends Expression<int, IntType> {
 
   @override
   void writeInto(GenerationContext context) {
-    context.buffer.write('CAST(strftime("$format", ');
+    context.buffer.write("CAST(strftime('$format', ");
     date.writeInto(context);
-    context.buffer.write(', "unixepoch") AS INTEGER)');
+    context.buffer.write(", 'unixepoch') AS INTEGER)");
   }
 
   @override

moor/pubspec.yaml

@@ -1,6 +1,6 @@
 name: moor
 description: Moor is a safe and reactive persistence library for Dart applications
-version: 2.4.0
+version: 2.4.1
 repository: https://github.com/simolus3/moor
 homepage: https://moor.simonbinder.eu/
 issue_tracker: https://github.com/simolus3/moor/issues

moor/test/columns/datetime_test.dart

@@ -19,6 +19,6 @@ void main() {
     final ctx = GenerationContext(null, null);
     nonNull.isSmallerThan(currentDateAndTime).writeInto(ctx);
 
-    expect(ctx.sql, 'name < strftime(\'%s\', CURRENT_TIMESTAMP)');
+    expect(ctx.sql, "name < strftime('%s', CURRENT_TIMESTAMP)");
   });
 }

moor/test/engines/connection_pool_integration_test.dart

@@ -43,4 +43,6 @@ void main() {
     await db.close();
     await isolate.shutdownAll();
   });
+
+  tearDown(_file.delete);
 }

moor/test/expressions/datetime_expression_test.dart

@@ -14,12 +14,12 @@ void main() {
 
   group('extracting information via top-level method', () {
     final expectedResults = <_Extractor, String>{
-      year: 'CAST(strftime("%Y", val, "unixepoch") AS INTEGER)',
-      month: 'CAST(strftime("%m", val, "unixepoch") AS INTEGER)',
-      day: 'CAST(strftime("%d", val, "unixepoch") AS INTEGER)',
-      hour: 'CAST(strftime("%H", val, "unixepoch") AS INTEGER)',
-      minute: 'CAST(strftime("%M", val, "unixepoch") AS INTEGER)',
-      second: 'CAST(strftime("%S", val, "unixepoch") AS INTEGER)',
+      year: "CAST(strftime('%Y', val, 'unixepoch') AS INTEGER)",
+      month: "CAST(strftime('%m', val, 'unixepoch') AS INTEGER)",
+      day: "CAST(strftime('%d', val, 'unixepoch') AS INTEGER)",
+      hour: "CAST(strftime('%H', val, 'unixepoch') AS INTEGER)",
+      minute: "CAST(strftime('%M', val, 'unixepoch') AS INTEGER)",
+      second: "CAST(strftime('%S', val, 'unixepoch') AS INTEGER)",
     };
 
     expectedResults.forEach((key, value) {