mirror of https://github.com/AMT-Cheif/drift.git
Enable checkNoTail
This commit is contained in:
parent
48f1aa8437
commit
b7dd8872c5
|
@ -182,7 +182,8 @@ class _VmDelegate extends DatabaseDelegate {
|
||||||
@override
|
@override
|
||||||
Future<void> runBatched(BatchedStatements statements) async {
|
Future<void> runBatched(BatchedStatements statements) async {
|
||||||
final prepared = [
|
final prepared = [
|
||||||
for (final stmt in statements.statements) _db.prepare(stmt),
|
for (final stmt in statements.statements)
|
||||||
|
_db.prepare(stmt, checkNoTail: true),
|
||||||
];
|
];
|
||||||
|
|
||||||
for (final application in statements.arguments) {
|
for (final application in statements.arguments) {
|
||||||
|
@ -202,7 +203,7 @@ class _VmDelegate extends DatabaseDelegate {
|
||||||
if (args.isEmpty) {
|
if (args.isEmpty) {
|
||||||
_db.execute(statement);
|
_db.execute(statement);
|
||||||
} else {
|
} else {
|
||||||
final stmt = _db.prepare(statement);
|
final stmt = _db.prepare(statement, checkNoTail: true);
|
||||||
stmt.execute(args);
|
stmt.execute(args);
|
||||||
stmt.dispose();
|
stmt.dispose();
|
||||||
}
|
}
|
||||||
|
@ -227,7 +228,7 @@ class _VmDelegate extends DatabaseDelegate {
|
||||||
|
|
||||||
@override
|
@override
|
||||||
Future<QueryResult> runSelect(String statement, List<Object?> args) async {
|
Future<QueryResult> runSelect(String statement, List<Object?> args) async {
|
||||||
final stmt = _db.prepare(statement);
|
final stmt = _db.prepare(statement, checkNoTail: true);
|
||||||
final result = stmt.select(args);
|
final result = stmt.select(args);
|
||||||
stmt.dispose();
|
stmt.dispose();
|
||||||
|
|
||||||
|
|
|
@ -386,6 +386,10 @@ abstract class DatabaseConnectionUser {
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Executes the custom sql [statement] on the database.
|
/// Executes the custom sql [statement] on the database.
|
||||||
|
///
|
||||||
|
/// [statement] should contain exactly one SQL statement. Attempting to run
|
||||||
|
/// multiple statements with a single [customStatement] may not be fully
|
||||||
|
/// supported on all platforms.
|
||||||
Future<void> customStatement(String statement, [List<dynamic>? args]) {
|
Future<void> customStatement(String statement, [List<dynamic>? args]) {
|
||||||
final engine = resolvedEngine;
|
final engine = resolvedEngine;
|
||||||
|
|
||||||
|
|
|
@ -25,6 +25,40 @@ void main() {
|
||||||
underlying.dispose();
|
underlying.dispose();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
group('checks for trailing statement content', () {
|
||||||
|
late NativeDatabase db;
|
||||||
|
|
||||||
|
setUp(() async {
|
||||||
|
db = NativeDatabase.memory();
|
||||||
|
await db.ensureOpen(_FakeExecutorUser());
|
||||||
|
});
|
||||||
|
|
||||||
|
tearDown(() => db.close());
|
||||||
|
|
||||||
|
test('multiple statements are allowed for runCustom without args', () {
|
||||||
|
return db.runCustom('SELECT 1; SELECT 2;');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('throws for runCustom with args', () async {
|
||||||
|
expect(db.runCustom('SELECT ?; SELECT ?;', [1, 2]), throwsArgumentError);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('in runSelect', () async {
|
||||||
|
expect(db.runSelect('SELECT ?; SELECT ?;', [1, 2]), throwsArgumentError);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('in runBatched', () {
|
||||||
|
expect(
|
||||||
|
db.runBatched(BatchedStatements([
|
||||||
|
'SELECT ?; SELECT ?;'
|
||||||
|
], [
|
||||||
|
ArgumentsForBatchedStatement(0, []),
|
||||||
|
])),
|
||||||
|
throwsArgumentError,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
class _FakeExecutorUser extends QueryExecutorUser {
|
class _FakeExecutorUser extends QueryExecutorUser {
|
||||||
|
|
Loading…
Reference in New Issue