AMT-Cheif
/
drift
mirror of https://github.com/AMT-Cheif/drift.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Test transactions in migrations (#430)

This commit is contained in:
Simon Binder 2020-03-15 15:16:22 +01:00
parent 97127782b2
commit bc1f347498
No known key found for this signature in database
GPG Key ID: 7891917E4147B8C0
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
extras/integration_tests/tests/lib/database/database.dart
View File

@ -89,7 +89,7 @@ class Database extends _$Database {
/// It will be set in the onUpgrade callback. Null if no migration ocurred /// It will be set in the onUpgrade callback. Null if no migration ocurred
int schemaVersionChangedFrom; int schemaVersionChangedFrom;
/// It will be set in the onUpgrade callback. Null if no migration ocurred /// It will be set in the onUpgrade callback. Null if no migration ocurred
int schemaVersionChangedTo; int schemaVersionChangedTo;
@ -99,7 +99,10 @@ class Database extends _$Database {
onCreate: (m) async { onCreate: (m) async {
await m.createTable(users); await m.createTable(users);
if (schemaVersion >= 2) { if (schemaVersion >= 2) {
await m.createTable(friendships); // ensure that transactions can be used in a migration callback.
await transaction(() async {
await m.createTable(friendships);
});
} }
}, },
onUpgrade: (m, from, to) async { onUpgrade: (m, from, to) async {

2
moor/lib/src/runtime/api/db_base.dart
View File

@ -100,7 +100,7 @@ abstract class GeneratedDatabase extends DatabaseConnectionUser
/// ///
/// This api is mainly used internally in moor, especially to implement the /// This api is mainly used internally in moor, especially to implement the
/// [beforeOpen] callback from the database site. /// [beforeOpen] callback from the database site.
/// However, it can also be used if yuo need to create tables manually and /// However, it can also be used if you need to create tables manually and
/// outside of a [MigrationStrategy]. For almost all use cases, overriding /// outside of a [MigrationStrategy]. For almost all use cases, overriding
/// [migration] should suffice. /// [migration] should suffice.
@protected @protected