AMT-Cheif
/
drift
mirror of https://github.com/AMT-Cheif/drift.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2161 from North101/develop 

Remove unnecessary where clause for batch.deleteAll
This commit is contained in:
Simon Binder 2022-11-21 23:00:00 +01:00 committed by GitHub
parent 6e16a8b8b6 d165ee1bd8
commit df76457819
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drift/lib/src/runtime/api/batch.dart
View File

@ -147,8 +147,11 @@ class Batch {
///
/// See also:
/// - [DatabaseConnectionUser.delete]
void deleteAll<T extends Table, D>(TableInfo<T, D> table) =>
deleteWhere(table, (tbl) => const Constant(true));
void deleteAll<T extends Table, D>(TableInfo<T, D> table) {
_addUpdate(table, UpdateKind.delete);
final stmt = DeleteStatement(_user, table);
_addContext(stmt.constructQuery());
}
/// Executes the custom [sql] statement with variables instantiated to [args].
///

2
drift/test/database/batch_test.dart
View File

@ -59,7 +59,7 @@ void main() {
'UPDATE "users" SET "name" = ? WHERE "name" = ?;',
'UPDATE "categories" SET "desc" = ?, "priority" = 0 WHERE "id" = ?;',
'DELETE FROM "categories" WHERE "id" = ?;',
'DELETE FROM "categories" WHERE 1;',
'DELETE FROM "categories";',
'DELETE FROM "todos" WHERE "id" = ?;',
'some custom statement',
],