AMT-Cheif
/
drift
mirror of https://github.com/AMT-Cheif/drift.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't sync in transactions, remove interface

This commit is contained in:
Simon Binder 2022-05-23 12:11:06 +02:00
parent 0a37736d1b
commit e2622517a5
No known key found for this signature in database
GPG Key ID: 7891917E4147B8C0
3 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drift/lib/src/sqlite3/database.dart
View File

@ -1,5 +1,6 @@
@internal @internal
import 'package:drift/src/sqlite3/persistence_handler.dart'; import 'dart:async';
import 'package:meta/meta.dart'; import 'package:meta/meta.dart';
import 'package:sqlite3/common.dart'; import 'package:sqlite3/common.dart';
@ -48,6 +49,12 @@ abstract class Sqlite3Delegate<DB extends CommonDatabase>
@override @override
Future<bool> get isOpen => Future.value(_isOpen); Future<bool> get isOpen => Future.value(_isOpen);
/// Flush pending writes to the file system on platforms where that is
/// necessary.
///
/// At the moment, we only support this for the WASM backend.
FutureOr<void> flush() => null;
@override @override
Future<void> open(QueryExecutorUser db) async { Future<void> open(QueryExecutorUser db) async {
if (!_hasCreatedDatabase) { if (!_hasCreatedDatabase) {
@ -89,8 +96,8 @@ abstract class Sqlite3Delegate<DB extends CommonDatabase>
stmt.dispose(); stmt.dispose();
} }
if (this is PersistenceHandler) { if (!isInTransaction) {
await (this as PersistenceHandler).flush(); await flush();
} }
return Future.value(); return Future.value();
@ -105,8 +112,8 @@ abstract class Sqlite3Delegate<DB extends CommonDatabase>
stmt.dispose(); stmt.dispose();
} }
if (this is PersistenceHandler) { if (!isInTransaction) {
await (this as PersistenceHandler).flush(); await flush();
} }
} }
@ -141,9 +148,8 @@ abstract class Sqlite3Delegate<DB extends CommonDatabase>
if (_closeUnderlyingWhenClosed) { if (_closeUnderlyingWhenClosed) {
beforeClose(_db); beforeClose(_db);
_db.dispose(); _db.dispose();
if (this is PersistenceHandler) {
await (this as PersistenceHandler).flush(); await flush();
}
} }
} }
} }

5
drift/lib/src/sqlite3/persistence_handler.dart
View File

@ -1,5 +0,0 @@
///
abstract class PersistenceHandler {
///
Future<void> flush();
}

4
drift/lib/wasm.dart
View File

@ -14,7 +14,6 @@
@experimental @experimental
library drift.wasm; library drift.wasm;
import 'package:drift/src/sqlite3/persistence_handler.dart';
import 'package:meta/meta.dart'; import 'package:meta/meta.dart';
import 'package:sqlite3/common.dart'; import 'package:sqlite3/common.dart';
import 'package:sqlite3/wasm.dart'; import 'package:sqlite3/wasm.dart';
@ -67,8 +66,7 @@ class WasmDatabase extends DelegatedDatabase {
} }
} }
class _WasmDelegate extends Sqlite3Delegate<CommonDatabase> class _WasmDelegate extends Sqlite3Delegate<CommonDatabase> {
implements PersistenceHandler {
final CommmonSqlite3 _sqlite3; final CommmonSqlite3 _sqlite3;
final String? _path; final String? _path;
final IndexedDbFileSystem? _fileSystem; final IndexedDbFileSystem? _fileSystem;