From fa9461473868132a6a23c672b2eea2d29287855d Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Wed, 14 Feb 2018 16:30:55 -0500 Subject: [PATCH] [doc] dev-notes: Members should be initialized Also, remove mention of threads that were removed long ago --- doc/developer-notes.md | 20 ++++++++++++++------ src/miner.cpp | 6 ------ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/doc/developer-notes.md b/doc/developer-notes.md index 9dc63a1e4..ac1f52b49 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -238,12 +238,8 @@ Threads - DumpAddresses : Dumps IP addresses of nodes to peers.dat. -- ThreadFlushWalletDB : Close the wallet.dat file if it hasn't been used in 500ms. - - ThreadRPCServer : Remote procedure call handler, listens on port 8332 for connections and services them. -- BitcoinMiner : Generates bitcoins (if wallet is enabled). - - Shutdown : Does an orderly shutdown of everything. Ignoring IDE/editor files @@ -380,6 +376,18 @@ C++ data structures - *Rationale*: Easier to understand what is happening, thus easier to spot mistakes, even for those that are not language lawyers +- Initialize all non-static class members where they are defined + + - *Rationale*: Initializing the members in the declaration makes it easy to spot uninitialized ones, + and avoids accidentally reading uninitialized memory + +```cpp +class A +{ + uint32_t m_count{0}; +} +``` + Strings and formatting ------------------------ @@ -415,11 +423,11 @@ member name: ```c++ class AddressBookPage { - Mode mode; + Mode m_mode; } AddressBookPage::AddressBookPage(Mode _mode) : - mode(_mode) + m_mode(_mode) ... ``` diff --git a/src/miner.cpp b/src/miner.cpp index dda52790c..fcb376c6c 100644 --- a/src/miner.cpp +++ b/src/miner.cpp @@ -30,12 +30,6 @@ #include #include -////////////////////////////////////////////////////////////////////////////// -// -// BitcoinMiner -// - -// // Unconfirmed transactions in the memory pool often depend on other // transactions in the memory pool. When we select transactions from the // pool, we select by highest fee rate of a transaction combined with all