Avoid duplicate CheckBlock checks

This commit is contained in:
Pieter Wuille 2015-08-15 23:32:38 +02:00
parent 391dff16fe
commit 3b33ec85ed
2 changed files with 10 additions and 0 deletions

View File

@ -2587,6 +2587,9 @@ bool CheckBlock(const CBlock& block, CValidationState& state, bool fCheckPOW, bo
{
// These are checks that are independent of context.
if (block.fChecked)
return true;
// Check that the header is valid (particularly PoW). This is mostly
// redundant with the call in AcceptBlockHeader.
if (!CheckBlockHeader(block, state, fCheckPOW))
@ -2642,6 +2645,9 @@ bool CheckBlock(const CBlock& block, CValidationState& state, bool fCheckPOW, bo
return state.DoS(100, error("CheckBlock(): out-of-bounds SigOpCount"),
REJECT_INVALID, "bad-blk-sigops", true);
if (fCheckPOW && fCheckMerkleRoot)
block.fChecked = true;
return true;
}

View File

@ -77,6 +77,9 @@ public:
// network and disk
std::vector<CTransaction> vtx;
// memory only
mutable bool fChecked;
CBlock()
{
SetNull();
@ -100,6 +103,7 @@ public:
{
CBlockHeader::SetNull();
vtx.clear();
fChecked = false;
}
CBlockHeader GetBlockHeader() const