From a1fe9446e9df87e7c2c344d31c5b7b60275127fb Mon Sep 17 00:00:00 2001 From: Russell Yanofsky Date: Wed, 14 Dec 2016 05:41:36 -0500 Subject: [PATCH] Remove reference to nonexistent "version" wallet transaction mapvalue field This change removes a mapValue.erase("version") statement which deletes a mapValue entry that never existed. The statement was mistakenly added in commit 865c3a23832e36d50cb873d38c976032b027b5d3 in 2010 and is harmless but confusing. --- src/wallet/wallet.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h index 36f7cd47b..755c1a870 100644 --- a/src/wallet/wallet.h +++ b/src/wallet/wallet.h @@ -268,10 +268,6 @@ public: * "timesmart" - serialized nTimeSmart value * "spent" - serialized vfSpent value that existed prior to * 2014 (removed in commit 93a18a3) - * - * A mapValue.erase("version") statement also appears in the code, - * originating from commit 865c3a2 in 2010, but it does not appear that any - * "version" entries were actually ever created by any version of bitcoin. */ mapValue_t mapValue; std::vector > vOrderForm; @@ -381,7 +377,6 @@ public: } mapValue.erase("fromaccount"); - mapValue.erase("version"); mapValue.erase("spent"); mapValue.erase("n"); mapValue.erase("timesmart");