BTCPrivate
/
BTCP-Rebase
mirror of https://github.com/BTCPrivate/BTCP-Rebase.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Prevent TestNodeCLI.args mixups 

Change TestNodeCLI.__call__() to return a new instance instead of modifying the
existing instance. This way, it's possible to create different cli objects that
have their own options (for example -rpcwallet options to connect to different
wallets), and options set for a single call (`node.cli(options).method(args)`)
will no longer leak into future calls.
This commit is contained in:
Russell Yanofsky 2017-12-20 18:41:12 -05:00 committed by John Newbery
parent fcfb952bca
commit ca9085afc5
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/functional/test_framework/test_node.py
View File

@ -203,9 +203,10 @@ class TestNodeCLI():
def __call__(self, *args, input=None): def __call__(self, *args, input=None):
# TestNodeCLI is callable with bitcoin-cli command-line args # TestNodeCLI is callable with bitcoin-cli command-line args
self.args = [str(arg) for arg in args] cli = TestNodeCLI(self.binary, self.datadir)
self.input = input cli.args = [str(arg) for arg in args]
return self cli.input = input
return cli
def __getattr__(self, command): def __getattr__(self, command):
def dispatcher(*args, **kwargs): def dispatcher(*args, **kwargs):