qa: Remove redundant checkmempool/checkblockindex extra_args

This commit is contained in:
MarcoFalke 2018-08-08 14:30:09 -04:00
parent df9f712746
commit fa31ca0c22
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548
5 changed files with 4 additions and 8 deletions

View File

@ -22,7 +22,7 @@ class ReindexTest(BitcoinTestFramework):
self.nodes[0].generate(3) self.nodes[0].generate(3)
blockcount = self.nodes[0].getblockcount() blockcount = self.nodes[0].getblockcount()
self.stop_nodes() self.stop_nodes()
extra_args = [["-reindex-chainstate" if justchainstate else "-reindex", "-checkblockindex=1"]] extra_args = [["-reindex-chainstate" if justchainstate else "-reindex"]]
self.start_nodes(extra_args) self.start_nodes(extra_args)
wait_until(lambda: self.nodes[0].getblockcount() == blockcount) wait_until(lambda: self.nodes[0].getblockcount() == blockcount)
self.log.info("Success") self.log.info("Success")

View File

@ -35,7 +35,6 @@ class MempoolAcceptanceTest(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.num_nodes = 1 self.num_nodes = 1
self.extra_args = [[ self.extra_args = [[
'-checkmempool',
'-txindex', '-txindex',
'-reindex', # Need reindex for txindex '-reindex', # Need reindex for txindex
'-acceptnonstdtxn=0', # Try to mimic main-net '-acceptnonstdtxn=0', # Try to mimic main-net

View File

@ -11,11 +11,10 @@ that spend (directly or indirectly) coinbase transactions.
from test_framework.test_framework import BitcoinTestFramework from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import * from test_framework.util import *
# Create one-input, one-output, no-fee transaction:
class MempoolCoinbaseTest(BitcoinTestFramework): class MempoolCoinbaseTest(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.num_nodes = 2 self.num_nodes = 2
self.extra_args = [["-checkmempool"]] * 2
alert_filename = None # Set by setup_network alert_filename = None # Set by setup_network

View File

@ -7,11 +7,10 @@
from test_framework.test_framework import BitcoinTestFramework from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import * from test_framework.util import *
# Create one-input, one-output, no-fee transaction:
class MempoolCoinbaseTest(BitcoinTestFramework): class MempoolCoinbaseTest(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.num_nodes = 1 self.num_nodes = 1
self.extra_args = [["-checkmempool"]]
def run_test(self): def run_test(self):
node0_address = self.nodes[0].getnewaddress() node0_address = self.nodes[0].getnewaddress()

View File

@ -15,11 +15,10 @@ but less mature coinbase spends are NOT.
from test_framework.test_framework import BitcoinTestFramework from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import * from test_framework.util import *
# Create one-input, one-output, no-fee transaction:
class MempoolSpendCoinbaseTest(BitcoinTestFramework): class MempoolSpendCoinbaseTest(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.num_nodes = 1 self.num_nodes = 1
self.extra_args = [["-checkmempool"]]
def run_test(self): def run_test(self):
chain_height = self.nodes[0].getblockcount() chain_height = self.nodes[0].getblockcount()