[doc] dev-notes: Members should be initialized

Also, remove mention of threads that were removed long ago
This commit is contained in:
MarcoFalke 2018-02-14 16:30:55 -05:00
parent f4f4f51f1a
commit fa94614738
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548
2 changed files with 14 additions and 12 deletions

View File

@ -238,12 +238,8 @@ Threads
- DumpAddresses : Dumps IP addresses of nodes to peers.dat.
- ThreadFlushWalletDB : Close the wallet.dat file if it hasn't been used in 500ms.
- ThreadRPCServer : Remote procedure call handler, listens on port 8332 for connections and services them.
- BitcoinMiner : Generates bitcoins (if wallet is enabled).
- Shutdown : Does an orderly shutdown of everything.
Ignoring IDE/editor files
@ -380,6 +376,18 @@ C++ data structures
- *Rationale*: Easier to understand what is happening, thus easier to spot mistakes, even for those
that are not language lawyers
- Initialize all non-static class members where they are defined
- *Rationale*: Initializing the members in the declaration makes it easy to spot uninitialized ones,
and avoids accidentally reading uninitialized memory
```cpp
class A
{
uint32_t m_count{0};
}
```
Strings and formatting
------------------------
@ -415,11 +423,11 @@ member name:
```c++
class AddressBookPage
{
Mode mode;
Mode m_mode;
}
AddressBookPage::AddressBookPage(Mode _mode) :
mode(_mode)
m_mode(_mode)
...
```

View File

@ -30,12 +30,6 @@
#include <queue>
#include <utility>
//////////////////////////////////////////////////////////////////////////////
//
// BitcoinMiner
//
//
// Unconfirmed transactions in the memory pool often depend on other
// transactions in the memory pool. When we select transactions from the
// pool, we select by highest fee rate of a transaction combined with all