1ad3b7d5c0
add Debug window to tray-menu / switch sendCoinsAction and receiveCoinsAction in tray to match button ordering in the client window
2012-05-09 14:38:06 +02:00
d285c7bf2c
Kill warning from unavoidable signed/unsigned comparison in bitcoinrpc.cpp.
2012-05-09 07:17:30 -04:00
2e767410b8
Merge pull request #1230 from sipa/warnings
...
Clean up warnings
2012-05-09 04:07:24 -07:00
c164396ddc
Merge pull request #1235 from Diapolo/translation_en
...
update bitcoin_en.ts (translation master file) to match current master branch as of 2012-05-09
2012-05-09 04:06:47 -07:00
92dca80975
Merge pull request #1232 from TheBlueMatt/lockcontention
...
Fix DEBUG_LOCKCONTENTION
2012-05-09 03:55:02 -07:00
11353b0c57
update bitcoin_en.ts (translation master file) to match current master branch as of 2012-05-09
2012-05-09 12:38:51 +02:00
3e468840bd
util.h/.ccp: modifiy some comments / rename MyGetSpecialFolderPath() -> GetSpecialFolderPath(), set fCreate default to true and remove the fallback (not Win >= Vista compatible anyway) / remove namespace fs stuff where only used once / misc small changes'
2012-05-09 12:22:58 +02:00
3b6ed2294b
fix an incorrect if-clause in net.cpp
2012-05-09 09:11:13 +02:00
50a3855082
harmonize the use of ellipsis ("...") to be used in menus, but not on buttons / update some strings to be more informative
2012-05-09 09:06:51 +02:00
9e11cb53dd
Merge pull request #1215 from laanwj/2012_05_nogridtables
...
Make user actions more straightforward in address book
2012-05-08 23:34:10 -07:00
5ac114c756
Make it possible to set user interface language from options dialog
2012-05-09 07:45:47 +02:00
6ddf861078
Organize optionsdialog (split off Window and Network page)
2012-05-09 07:45:47 +02:00
2ea78ec7fd
Fix DEBUG_LOCKCONTENTION
2012-05-09 01:41:07 -04:00
09570add5f
remove 2 ugly spaces from a string used in translations
2012-05-09 06:51:25 +02:00
f621326c24
Clean up warnings
...
* Use -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameters
* Remove xCXXFLAGS usage in makefile.unix
* Fix several recent and older sign-compare warnings
2012-05-09 03:48:30 +02:00
781fc2c8c0
Revert part of 1302257e: don't update CXXFLAGS, only xCXXFLAGS
2012-05-08 21:18:35 -04:00
1302257e5d
makefile.unix: add -Wall to default CXXFLAGS
...
Additionally, remove -Wno-sign-compare from alt CXXFLAGS, as
that is no longer a problem.
2012-05-08 21:02:28 -04:00
96c5269511
RPC: Support HTTP/1.0 and HTTP/1.1, including the proper use of keep-alives
2012-05-08 20:25:39 -04:00
e9205293bd
Support multi-threaded JSON-RPC
...
Change internal HTTP JSON-RPC server from single-threaded to
thread-per-connection model. The IP filter list is applied prior to starting
the thread, which then processes the RPC.
A mutex covers the entire RPC operation, because not all RPC operations are
thread-safe.
[minor modifications by jgarzik, to make change upstream-ready]
2012-05-08 20:11:17 -04:00
203f9e6c00
Merge branch 'tmp-ipv6' into merge-ipv6
2012-05-08 19:43:17 -04:00
82ab06b849
Merge pull request #886 from luke-jr/getblock_full
...
More details for getblock and gettransaction
2012-05-08 15:31:52 -07:00
2387a7a969
remove 2 obsolete functions from init.h that moved to util.h
2012-05-08 23:22:36 +02:00
7e63dc3615
Support for decomposing scripts as "obj"
2012-05-08 21:04:57 +00:00
74335bd32a
Second parameter to JSON-RPC getblock/gettransaction: decompositions
...
This is an Object specifying how to decompose specific elements.
Currently supported:
- "tx": "no", "hash", "hex", "obj"
- "script": "no", "hex", "asm"
2012-05-08 21:04:52 +00:00
d4e09300f3
Add block "confirmations" to getblock, mainly for identifying orphans
2012-05-08 21:04:47 +00:00
a2ea797593
Merge pull request #1180 from jgarzik/sign-compare
...
Fix final sign comparison warnings
2012-05-08 13:50:27 -07:00
2f1dca645b
Merge pull request #841 from sipa/getalltransactions
...
gettransaction RPC for non-wallet transactions
2012-05-08 13:19:11 -07:00
f1ae31d8af
Merge pull request #883 from sipa/loadblock
...
Add -loadblock to load from an external blk000?.dat file
2012-05-08 12:37:27 -07:00
fa8cc47c4f
Merge pull request #1075 from laanwj/2012_04_consoleui
...
Add UI RPC console / debug window
2012-05-08 12:26:49 -07:00
a5f95d75a1
Increase client version to 0.6.99
2012-05-08 15:22:02 -04:00
1f7e0e51aa
Merge pull request #1219 from luke-jr/rm_fee_tip
...
Bitcoin-Qt: Remove redundant tooltip on optional transaction fee. Fixes #1218
2012-05-07 12:36:26 -07:00
1ef3a48c03
Bitcoin-Qt: Remove redundant tooltip on optional transaction fee. Fixes #1218
2012-05-07 19:22:09 +00:00
356c3cad1a
Make user action more straightforward in address book
...
- Add all actions that can be triggered with buttons to the context menu
- Hide delete action from context menu for receiving tab
2012-05-07 11:30:23 +02:00
f49d4f0e93
Merge pull request #1196 from sipa/fix_948
...
Prevent stuck download: correct solution
2012-05-06 16:58:31 -07:00
7d5bb42946
Move back setPlaceholderText to code, from xml, as this broke building with Qt 4.6
2012-05-07 00:19:22 +02:00
46692fc929
Merge pull request #1189 from Diapolo/fix#952
...
fix for #952 (send coins tab glitch)
2012-05-06 14:49:08 -07:00
6860133373
Prevent stuck download: correct solution
...
Pull request #948 introduced a fix for nodes stuck on a long side branch
of the main chain. The fix was non-functional however, as the additional
getdata request was created in a first step of processing, but dropped
in a second step as it was considered redundant. This commits fixes it
by sending the request directly.
2012-05-06 23:37:45 +02:00
52d4975825
passphrasedialog: change dialog title to "Passphrase Dialog" / remove style-sheet for bold font and use Qt Designer option / remove an unused label default-text and remove an obsolete clear()'
2012-05-06 22:11:26 +02:00
4295311da3
move many overviewpage settings from code to ui XML-file / removed ability to translate "0 BTC" and "123.456 BTC" as this is only used as preview in the Qt Designer anyway / set mouse cursor to IBeam for selectable labels
2012-05-06 16:57:12 +02:00
0e69fc6e84
Merge pull request #1209 from laanwj/2012_05_hideonshutdown
...
Hide UI immediately after leaving the main loop
2012-05-05 23:30:55 -07:00
46f552a9fe
Hide UI immediately after leaving the main loop.
...
Prevents it from seeming to hang during shutdown if shutdown is triggered while the window is open.
2012-05-06 08:28:20 +02:00
4fdc8a62d0
Merge pull request #1207 from sipa/fix_addrman
...
Fix addrman crashes
2012-05-05 22:23:57 -07:00
5b8def797c
Merge pull request #1160 from retep/master
...
Minor error message fix
2012-05-05 12:34:46 -07:00
bd1aabe941
Bugfix: store source address in addrman
2012-05-05 21:33:29 +02:00
56f1e91239
Fix addrman crashes
...
A function returned the element to remove from a bucket, instead of its
position in that bucket. This function was only called when a tried
bucket overflowed, which only happens after many outgoing connections
have been made.
Closes : #1065 , #1156
2012-05-05 21:33:26 +02:00
29a86a1735
Add extra asserts to addrman
2012-05-05 21:32:41 +02:00
82e6b92b0a
Bugfix: %-12I64d is not valid and causes the parameter to be skipped, use %12"PRI64d" instead
2012-05-05 14:24:55 -04:00
46c08874aa
Merge pull request #1201 from Diapolo/about-dialog
...
changed cursor for selectable text on the about dialog to IBeamCursor...
2012-05-05 04:22:04 -07:00
7b74bd4928
changed cursor for selectable text on the about dialog to IBeamCursor and removed an unused tag
2012-05-05 12:55:51 +02:00
dd62ca1b29
Merge pull request #1202 from Diapolo/messagepage
...
change text on message.ui from "Copy to Clipboard" to "Copy Signature"...
2012-05-05 03:31:11 -07:00
d7d7d81a6a
change text on message.ui from "Copy to Clipboard" to "Copy Signature" and
...
add an Alt-Shortcut to "Clear &All"
2012-05-05 12:03:02 +02:00
6ad47ddf40
Merge pull request #1203 from Diapolo/qrcodedialog
...
renamed qrcodedialog.ui window title to "QR-Code Dialog"...
2012-05-05 02:59:44 -07:00
092522af6c
renamed qrcodedialog.ui window title to "QR-Code Dialog" and changed window size to the minimum values Qt Creator allows me to set
2012-05-05 11:43:54 +02:00
e400258bf0
simplified qrcode icon that scales gracefully to 16x16
2012-05-05 11:27:38 +02:00
460c51fdad
Add UI RPC console / debug window
2012-05-05 10:37:06 +02:00
3793fa09ff
Allow Qt to wrap long tooltips ( fixes #1063 )
...
Implemented without having to touch any translation: by listening for QEvent::ToolTipChange events, then rewriting the tooltips to prefix `<qt/>` if it is not yet rich text.
2012-05-05 10:20:52 +02:00
c8a3917089
signmessage: auto-select signature when field is focused/clicked
2012-05-05 09:56:55 +02:00
4c9183e8bb
Merge pull request #1166 from Diapolo/signmessage_clear
...
add a clear all button to the sign message page (addresses #943 )
2012-05-05 00:43:27 -07:00
6672400206
Merge pull request #1175 from Diapolo/translators
...
small translation-file handling / loading changes and re-work comments to be clearer
2012-05-05 00:11:37 -07:00
1f6f261ace
Merge pull request #1187 from TheBlueMatt/win32_ie
...
Update to require IE 5.1 as it is required to build on mingw64.
2012-05-05 00:02:10 -07:00
393a0edc51
Merge pull request #1194 from Diapolo/sendcoins_placeholdertext
...
move label placeholdertext from sendcoinsentry.cpp to ui-file
2012-05-05 00:01:35 -07:00
3118d11d88
Merge pull request #1032 from Diapolo/fix#945
...
Remove HTML font crap from "Wallet" message (fix for #945 )
2012-05-04 23:58:46 -07:00
d0ccf0c755
move label placeholdertext from sendcoinsentry.cpp to ui-file
2012-05-04 18:19:06 +02:00
397737b913
Bump version numbers for 0.6.1rc2
2012-05-04 10:22:26 -04:00
19b6958cfd
Added -externalip and -discover
...
-externalip=<ip> can be used to explicitly set the public IP address
of your node. -discover=0 can be used to disable the automatic public
IP discovery system.
2012-05-04 16:12:23 +02:00
39857190de
Support for multiple local addresses
2012-05-04 16:12:23 +02:00
478b01d9a7
Add -seednode connections, and use this for -dnsseed + -proxydns
2012-05-04 16:11:54 +02:00
9bab521df8
Support connecting by hostnames passed to proxy (-proxydns)
2012-05-04 16:11:54 +02:00
a012e2db59
refactor ConnectSocket
2012-05-04 16:11:54 +02:00
933f2715d8
SOCKS5 connect via hostname
2012-05-04 16:11:54 +02:00
60a87bce87
SOCKS5 support by default
...
Add -socks=<n> to select SOCKS version to use. 4 and 5 are supported,
5 is default.
2012-05-04 16:11:54 +02:00
dab7acdf45
fix #952 by checking if we have a new address or an updated label
2012-05-04 11:09:55 +02:00
86c47a5636
Fixed non-sensical error message
...
Previously trying to create a multisig address that required less than
one signature would output something like the following:
"wrong number of keys(got 1, need at least 0)"
2012-05-04 00:41:00 -04:00
e23a121afe
remove obsolete BackupWallet() entry in wallet.h
2012-05-03 11:30:52 +02:00
65c2ad687f
add a clear all button to the sign message page
2012-05-03 09:23:37 +02:00
234db30d66
Update to require IE 5.1 as it is required on mingw64.
...
We already require XP, this just fixes Mingw64 build.
2012-05-02 20:21:43 -04:00
ca97bde8ff
Merge pull request #1171 from Diapolo/fix_compiler_warn
...
fix 2 compiler warnings
2012-05-01 15:02:41 -07:00
024fa1cb44
EvalScript(): cast to avoid signed/unsigned warning
2012-05-01 17:57:12 -04:00
061a001590
ThreadSocketHandler2(): cast to avoid signed/unsigned warning
2012-05-01 17:54:52 -04:00
10ab9c2f42
OpenBlockFile(): cast to eliminate signed/unsigned comparison warning
...
nFile's null value is -1. Cast that to unsigned int, to avoid warning.
Additionally, avoid nFile==0 because the first valid value is 1.
2012-05-01 17:50:33 -04:00
24de922636
CDiskTxPos, CInPoint, COutPoint: cast null value (-1) to unsigned int
...
to eliminate signed/unsigned comparison warnings
2012-05-01 17:49:17 -04:00
e19ccfa657
Merge pull request #1177 from laanwj/2012_05_remove_duplicate_securestring
...
remove duplicate definition of SecureString in util.h
2012-05-01 10:05:00 -07:00
6d25b0e99a
Merge pull request #1172 from Diapolo/serialize_h_rem_typedef
...
remove unused typedef in serialize.h
2012-05-01 09:52:38 -07:00
3ee5f8aac3
remove duplicate definition of SecureString in util.h
...
SecureString was moved to allocators.h in commit 6cb6d62347
2012-05-01 18:49:50 +02:00
aab1f950aa
small translation-file handling / loading changes and re-work comments to be clearer
2012-05-01 17:54:07 +02:00
1c94f88d5e
fix compiler warning "suggest parentheses around assignment used as truth
...
value [-Wparentheses]" in util.cpp
2012-05-01 11:41:04 +02:00
f8e4d43be7
fix compiler warning "suggest explicit braces to avoid ambiguous "else"
...
[-Wparentheses]" in net.cpp
2012-05-01 11:40:08 +02:00
00d971e1e7
remove references to bitcoin-wx from comment in init.cpp
2012-05-01 01:59:54 +02:00
810b4fad7d
remove unused typedef in serialize.h
2012-05-01 01:56:47 +02:00
be8651dde7
Check earlier for blocks with duplicate transactions. Fixes #1167
2012-04-30 11:08:07 -04:00
ec4997d48f
Merge pull request #1139 from Diapolo/messagepage
...
change button tooltip on sign message page for copy to clipboard...
2012-04-29 04:35:27 -07:00
6974aff668
Fix critical UI performance issue ( #1154 )
2012-04-29 13:25:05 +02:00
0acbe31cfc
Update openssl version
2012-04-27 12:45:49 -04:00
2c31cfc271
Bump version numbers for 0.6.1rc1
2012-04-27 10:14:33 -04:00
dfead66eac
Merge pull request #1151 from freewil/listsinceblock-blockhash
...
listsinceblock: rpc param blockid -> blockhash
2012-04-26 15:37:12 -07:00
27d4b53a5c
Merge pull request #1150 from gavinandresen/NOPCH
...
Remove unused -DNOPCH
2012-04-26 15:36:33 -07:00
b2997dc043
Merge pull request #1152 from freewil/remove-strange-debug
...
remove strange debug message from listsinceblock
2012-04-26 15:36:15 -07:00
287ce61dc2
Merge pull request #1146 from drizztbsd/posix-include
...
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
2012-04-26 15:25:56 -07:00
42ce57687a
remove strange debug message from listsinceblock
2012-04-26 13:12:44 -04:00
fdb204abb1
listsinceblock: rpc param blockid -> blockhash
...
This is more consistent with the rest of the labeling seen
by the user when accessing the rpc commands.
2012-04-26 12:48:33 -04:00
9e71a5cd23
Define TEST_DATA_DIR so unit tests can be run from any current working directory
2012-04-26 11:20:44 -04:00
08e663d7e2
Undo part of c2e8c8ac to fix issue#1148
2012-04-26 10:18:35 -04:00
cfc45319fe
Remove unused -DNOPCH
2012-04-25 19:40:44 -04:00
83743ed681
Make lsn_reset ("detach databases") optional and off by default.
...
Add an option -detachdb (and entry in OptionDialog), without which no
lsn_reset is called on addr.dat and blkindex.dat. That means these
files cannot be moved to a new environment, but shutdown can be
significantly faster. The wallet file is always lsn_reset'ed.
-detachdb corresponds to the old behaviour, though it is off by
default now to speed up shutdowns.
2012-04-26 00:31:54 +02:00
5e9dc15360
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
2012-04-25 14:07:24 +02:00
c2e8c8acd8
Merge pull request #1140 from jgarzik/sign-compare
...
Address many more sign comparison warnings
2012-04-23 21:33:29 -07:00
735a60698c
Change signed->unsigned at 3 code sites
...
This resolves signed/unsigned comparison warnings.
2012-04-23 14:14:36 -04:00
5aa0b23825
CBlock::WriteToDisk() properly checks ftell(3) for error return
...
Rather than storing ftell(3)'s return value -- a long -- in an
unsigned int, we store and check a properly typed temp. Then, assured a
non-negative value, we store in nBlockPosRet.
2012-04-23 14:14:36 -04:00
1d8c7a9557
Add casts for unavoidable signed/unsigned comparisons
...
At these code sites, it is preferable to cast rather than change
a variable's type.
2012-04-23 14:14:36 -04:00
c0a0a93d02
Test ScriptSigArgsExpected() for error, before accumulating return value
2012-04-23 14:14:36 -04:00
7bd9c3a3cf
SigOp and orphan-tx constants and counts are always unsigned.
...
Fixes several sign-comparison warnings.
2012-04-23 14:14:03 -04:00
faf705a42a
Prefer 'unsigned int' for loop index variables tested against ::size()
...
C++ STL ::size() generally returns unsigned, which implies that "int idx"
style of loop variable will generate a signed-vs-unsigned comparison warning
when testing the loop exit condition "idx < blah.size()"
Update areas of the bitcoin code where loop variables may be more properly and
correctly defined as unsigned.
2012-04-22 13:22:39 -04:00
a2d0fcbe38
change button tooltip on sign message page for copy to clipboard as it was missleading
2012-04-22 19:02:52 +02:00
f4203de302
Make GetDataDir return absolute paths
2012-04-22 17:38:47 +02:00
1d740055da
-loadblock to load from an external blk000?.dat file
2012-04-22 03:09:35 +02:00
457661f640
Merge pull request #1124 from sipa/rpcobj3
...
extension of #1103 : encapsulate mapCommands in CRPCTable
2012-04-21 16:49:32 -07:00
7dbe393629
Merge pull request #1131 from laanwj/2012_04_hexstr
...
Integrate @JoelKatz's optimized ToHex (#562 ) into current HexStr function
2012-04-21 16:47:02 -07:00
d5eb41fa08
Merge pull request #1129 from laanwj/2012_04_opcodes
...
Add explicit numeric constant value for all opcodes
2012-04-21 16:43:31 -07:00
8449a8788a
Data-drive script evaluation unit tests.
2012-04-21 19:35:39 -04:00
6a7a42be16
Merge pull request #1126 from drizztbsd/master
...
Fix build with gcc 4.7
2012-04-21 15:13:29 -07:00
88dc2d6c6a
Integrate @JoelKatz's optimized ToHex ( #562 ) into current HexStr function
2012-04-21 20:37:50 +02:00
b6c837cbe1
Remove no-longer used UI hints in bitcoin core
...
The Qt UI has its own associated structures for temporary transaction state / cache.
2012-04-21 18:21:19 +02:00
cdcc319c2d
change type of various bare chars to bool that are only used as bool (and never serialized)
2012-04-21 18:16:11 +02:00
7be8b2ff9c
Add explicit numeric constant value for all opcodes
...
- Easier for debugging (what opcode was 0x... again?)
- Clarifies that the opcodes are set in stone in the protocol, and signals that it is impossible to insert opcodes in between.
2012-04-21 10:34:18 +02:00
e46704dd90
Expose CRPCTable via bitcoinrpc.h for testing
2012-04-21 01:37:34 +02:00
9862229d4d
Encapsulate mapCommands in class CRPCTable
2012-04-21 01:20:05 +02:00
dc42bf52c1
Encapsulate RPC command dispatch in an array of CRPCCommand's
2012-04-21 01:20:05 +02:00
00b9c0f4b2
Merge pull request #1122 from dlitz/unsigned-char-fix
...
Unsigned char fix & fix undefined phexdigits[255]
2012-04-20 10:18:45 -07:00
9553c35d89
Add missing includes. (Fix bulding under GCC 4.7)
2012-04-20 12:50:57 +02:00
c73ba23eb5
gettransaction RPC for non-wallet transactions
...
Works for wallet transactions, memory-pool transaction and block chain
transactions.
Available for all:
* txid
* version
* locktime
* size
* coinbase/inputs/outputs
* confirmations
Available only for wallet transactions:
* amount
* fee
* details
* blockindex
Available for wallet transactions and block chain transactions:
* blockhash
* time
2012-04-18 23:42:07 +02:00
871c3557bf
Added ability to respond to signals during Block Loading stage.
2012-04-18 12:30:24 +01:00
8c8e8c2e93
Fix bugs on 'unsigned char' platforms.
...
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
2012-04-18 00:33:32 -04:00
a6fa147c8d
Fix phexdigits[255] is undefined.
2012-04-18 00:33:32 -04:00
559fc3c610
Add missing breaks in optionmodel's switch case
2012-04-17 23:27:59 +02:00
031eae7864
Merge pull request #1114 from sipa/lesssync
...
Reduce sync frequency for blkindex.dat
2012-04-17 14:23:31 -07:00
0a83c0fcef
Fix tests after recent refactors
2012-04-17 20:37:47 +02:00
c23617fef3
Merge remote-tracking branch 'jgarzik/mempool'
2012-04-17 20:12:48 +02:00
caeddc5d37
Merge pull request #1117 from sipa/deadlockfix
...
Fix potential deadlock
2012-04-17 11:05:02 -07:00
6b6aaa1698
Further reduce header dependencies
...
This commit removes the dependency of serialize.h on PROTOCOL_VERSION,
and makes this parameter required instead of implicit. This is much saner,
as it makes the places where changing a version number can have an
influence obvious.
2012-04-17 20:03:42 +02:00
ccd65d4261
Move proto version to version.h. Reduce header deps a bit more.
2012-04-17 20:02:38 +02:00
9eace6b113
Move CWalletDB code to new walletdb module.
...
In addition to standard code separation, this change opens the door
to fixing several include inter-dependencies.
2012-04-17 20:00:55 +02:00
ed6d0b5f85
Remove headers.h
2012-04-17 20:00:55 +02:00
b97d54355e
Merge pull request #1106 from jgarzik/sign-compare
...
Fix many sign-comparison warnings found in bitcoin codebase
2012-04-17 10:55:56 -07:00
e873dc654c
Merge pull request #1115 from laanwj/2012_04_cleanupmisc
...
Delete unused, unreachable and commented code, add missing initializer
2012-04-17 10:12:33 -07:00
c581cc16bb
Fix potential deadlock
...
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
2012-04-17 18:50:52 +02:00
ce8c93498a
main.cpp: replace tabs with spaces
...
Sometimes they sneak in through the 'vi' door
2012-04-17 12:31:51 -04:00
8bff8ac079
AlreadyHave(): only hold lock during mapTransactions access
2012-04-17 12:30:00 -04:00
7fa3ad83a9
Remove unused and unreachable code
2012-04-17 18:28:02 +02:00
4941aad657
Add forgotten initializer
2012-04-17 18:27:55 +02:00
8f2b50f178
Reduce sync frequency for blkindex.dat
...
Since auto-remove-db-logs was enabled, each time a CTxDB was closed
outside of the initial download window, it causes a checkpoint + log
cleanup. This is overkill, so reduce the sync frequency to once per
minute at most.
2012-04-17 18:27:18 +02:00
dd21ce5f1b
Merge pull request #1094 from jgarzik/already-have-locking
...
Locking fix for AlreadyHave()
2012-04-17 09:23:49 -07:00
ea9627979e
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
2012-04-17 12:16:46 -04:00
865a0c1674
Merge pull request #1081 from jgarzik/pong
...
BIP 0031: pong message
2012-04-17 08:51:17 -07:00
7a5452ffb3
Merge pull request #1092 from laanwj/2012_04_sendcoins_setlabelfix
...
When sending coins, set label when selecting address that already has a label
2012-04-16 05:41:39 -07:00
088a13331b
Merge pull request #1091 from Diapolo/GUI-BlockDL
...
revert to default OS theme for progressbar (fix #1071 )
2012-04-16 00:55:37 -07:00
9fb89c26f3
Fix misc. minor sign-comparison warnings
2012-04-15 17:00:20 -04:00
0dd710acb6
CNode's nHeaderStart may be negative, so change its type
2012-04-15 16:59:48 -04:00
c3fad8350b
serialize.h: CAutoFile's read and write may take size_t nSize
2012-04-15 16:59:09 -04:00
3a78f82a78
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
2012-04-15 16:58:32 -04:00
c376ac359e
Fix loop index var types, fixing many minor sign comparison warnings
...
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
2012-04-15 16:52:09 -04:00
ab9dc75a18
The string class returns string::npos, when find() fails.
...
Noticed when sign-comparison warnings were enabled.
2012-04-15 16:47:24 -04:00
ca4c4c53a8
CTxMemPool: add helper methods, to reduce global mempool.mapTx accesses
2012-04-15 14:43:19 -04:00
d01903e751
CTxMemPool: encapsulate AcceptToMemoryPool
2012-04-15 14:43:19 -04:00
8e45ed66dd
CTxMemPool: encapsulate AddToMemoryPoolUnchecked(), RemoveFromMemoryPool(),
...
and nPooledTx
2012-04-15 14:42:52 -04:00
235507ae48
New class CTxMemPool, encapsulating TX memory pool data members
2012-04-15 14:41:27 -04:00
5a701eb7ea
Merge pull request #1104 from laanwj/2012_04_clang
...
Enable and fix most compilation warnings
2012-04-15 11:39:15 -07:00
fced2231f8
Merge pull request #1084 from dooglus/validate_secret
...
importprivkey doesn't check that it is given a private key
2012-04-15 09:25:29 -07:00
9ea8e60a0c
Merge pull request #1097 from laanwj/2012_04_runawayexception
...
Show a message box when runaway exception happens
2012-04-15 09:22:26 -07:00
da7bbd9dfd
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
2012-04-15 13:40:14 +02:00
6642ffb761
fix warnings: '&&' within '||' [-Wlogical-op-parentheses]
2012-04-15 13:40:14 +02:00
2e120f28e0
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
2012-04-15 13:40:14 +02:00
11cd416525
fix warnings: unused variable 'XX' [-Wunused-variable]
2012-04-15 13:40:14 +02:00
76d8170ce8
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
2012-04-15 13:40:14 +02:00
87207a2e08
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
2012-04-15 13:40:14 +02:00
8add7822ce
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
2012-04-15 13:40:14 +02:00
1f29d399f4
work around issue in boost::program_options that prevents from compiling in clang
2012-04-15 13:40:14 +02:00
f9f625fb32
enable all warnings except invalid-offsetof, sign-compare, unused-parameter
2012-04-15 13:40:14 +02:00
2eb665c634
Bugfix: Check that QRcode_encodeString didn't return NULL (error)
...
Without this, any error will segfault Bitcoin-Qt
2012-04-14 21:00:27 -04:00
a7a0c7a1bf
Show a message box when runaway exception happens
...
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
2012-04-14 18:35:42 +02:00
22014c31e5
Merge pull request #1093 from jgarzik/tx-opt
...
Database micro-optimization for "tx" network message
2012-04-14 08:50:43 -07:00
46ba858817
Merge pull request #1089 from laanwj/2012_04_translationupdate
...
Update translations for bitcoin core
2012-04-13 23:47:50 -07:00
3fddc8effc
Update translations for bitcoin core
...
- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
2012-04-14 08:46:16 +02:00
b970067298
Do not show green tick unless all known blocks are downloaded ( fixes #921 )
2012-04-14 08:21:22 +02:00
8deb9822e4
Locking fix for AlreadyHave()
...
Access to mapTransactions[] must be guarded by cs_mapTransactions lock.
Also, reformat long lines to make the switch statement more readable.
2012-04-13 18:24:55 -04:00
9925d34a49
Database micro-optimization for "tx" network message
...
Open database once per "tx" message, rather than multiple times,
in the case of orphan transaction presence.
As a side effect, a now-unused CTransaction::AcceptToMemoryPool()
variant is removed.
2012-04-13 17:48:15 -04:00
2d67195ed2
Set label when selecting an address that already has a label. Fixes #1080 .
2012-04-13 21:08:46 +02:00
e72c6a1830
revert to default OS theme for progressbar / fix small glitches in bitcoingui.cpp
2012-04-13 18:25:56 +02:00
6b8e7eefcc
Add missing tooltip and key shortcut in settings dialog ( #1088 without line break part)
2012-04-13 09:16:46 +02:00
c3c203ccd9
Merge pull request #1087 from sipa/fix_1086
...
Fix #1086 : add /testnet to passed datadir
2012-04-12 18:22:15 -07:00
7a743148c9
Fix #1086 : add /testnet to passed datadir
2012-04-13 03:11:14 +02:00
8b09cd3a4d
Replace several network protocol version numbers with named constants
...
stored in version.h.
Also, a minor CAddress code reformat while we're in there, fixing
some incorrect indentation.
2012-04-12 20:07:49 -04:00
b3a6e613fc
CBitcoinSecret::SetString() now calls IsValid() to make sure it was passed something with the correct version.
2012-04-12 13:13:08 -07:00
b7dc02381f
Merge pull request #1041 from gavinandresen/listtransactionsfix
...
Bug fix listtransactions from/count handling.
2012-04-12 12:20:51 -07:00
181400c3d5
make text in about box selectable ( fixes #1055 )
2012-04-12 20:55:38 +02:00
7261945eb5
enable wordWrap on lblQRCode / small code comment change
2012-04-12 20:34:06 +02:00
b1a99c3a1f
limit length of generated URI to 255 chars to prevent a DoS against the QR-Code dialog
2012-04-12 20:34:06 +02:00
1e8c62b29c
updated to reflect pull-request suggestions / renamed some GUI elements
2012-04-12 20:34:05 +02:00
9e0dba8c17
fixed amount part of URI in QR-Codes / removed (no label) string if we have NO label / coding style updates / removed an unused variable
2012-04-12 20:34:04 +02:00
460b66b14b
Remove obsolete Win32 AffinityBugWorkaround()
...
Reference miner exists for testnet-in-a-box type situations, and as a
reference. We don't care enough about highly optimized internal
mining to keep workarounds like this.
2012-04-12 13:24:00 -04:00
b87c0fc440
version.h: separate client, net sections. Move more constants to this file.
...
* move PROTOCOL_VERSION to version.h
* move CLIENT_VERSION* to version.h, make available past cpp stage
* clearly separate client, network version portions of version.h
2012-04-12 12:23:58 -04:00
Philip Kaufmann
Gregory Maxwell
Gregory Maxwell
Wladimir J. van der Laan
Matt Corallo
Pieter Wuille
Jeff Garzik
Jeff Garzik
David Joel Schwartz
Luke Dashjr
Gavin Andresen
Peter Todd
freewil
Timothy Redaelli
R E Broadley
Dwayne C. Litzenberger
Chris Moore