BTCPrivate
/
BitcoinPrivate-legacy
mirror of https://github.com/BTCPrivate/BitcoinPrivate-legacy.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
7,935 Commits 12 Branches 14 Tags 52 MiB
Commit Graph

5382 Commits

Author SHA1 Message Date
Wladimir J. van der Laan d48ce48093
Merge #5548: [REST] add /rest/chaininfos 
2c0f901 [REST] rest/chaininfos add documentation (Jonas Schnelli)
59582c8 [REST] add /rest/chaininfos (Jonas Schnelli)
 2015-02-10 12:08:07 +01:00
Wladimir J. van der Laan a9565863e0
Merge #5629: [Qt] prevent amount overflow problem with payment requests 
a651668 [Qt] prevent amount overflow problem with payment requests (Philip Kaufmann)
 2015-02-09 13:50:56 +01:00
Wladimir J. van der Laan 183ca292bd
Merge #5699: Split logic to undo txin's off DisconnectBlock. 
eb1c2cd Split logic to undo txin's off DisconnectBlock. (Daniel Kraft)
 2015-02-09 13:22:35 +01:00
Wladimir J. van der Laan beff11a3a1
Merge #5679: Get rid of DetectShutdownThread 
28ee7e8 Get rid of DetectShutdownThread (Wladimir J. van der Laan)
 2015-02-09 12:57:09 +01:00
Wladimir J. van der Laan 7225577f6b
Merge pull request #5739 
f4b2078 Replace difficulty readjustment blocks with Interval() (Shaul Kfir)
 2015-02-09 12:48:38 +01:00
Wladimir J. van der Laan 0f44672437
Merge pull request #5753 
d67a642 [Qt] add bitcoin logo to about screen (Jonas Schnelli)
 2015-02-09 11:34:01 +01:00
Gregory Maxwell 28d4cff0ed Sanitize command strings before logging them. 
Normally bitcoin core does not display any network originated strings without
 sanitizing or hex encoding.  This wasn't done for strcommand in many places.

This could be used to play havoc with a terminal displaying the logs,
 especially with printtoconsole in use.

Thanks to Evil-Knievel for reporting this issue.
 2015-02-08 19:58:59 +00:00
Wladimir J. van der Laan fb6140b54b
Merge pull request #5721 
cf008ac Acquire CCheckQueue's lock to avoid race condition (Suhas Daftuar)
 2015-02-06 16:51:39 +01:00
Jonas Schnelli d67a642392 [Qt] add bitcoin logo to about screen 2015-02-04 20:52:18 +01:00
Jonas Schnelli 17115d0a34 fix getblocktemplate lock issue 
getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.
 2015-02-04 16:34:34 +01:00
Wladimir J. van der Laan 93b7544501
Merge pull request #5319 
35f7227 Clean up wallet encryption code. (Daniel Kraft)
 2015-02-04 13:56:57 +01:00
Philip Kaufmann a6516686dc [Qt] prevent amount overflow problem with payment requests 
Bitcoin amounts are stored as uint64 in the protobuf messages (see
paymentrequest.proto), but CAmount is defined as int64_t. Because
of that we need to verify that single and accumulated amounts are
in a valid range and no variable overflow has happened.

- fixes #5624 (#5622)

Thanks @SergioDemianLerner for reporting that issue and also supplying us
with a possible solution.

- add static verifyAmount() function to PaymentServer and move the logging
  on error into the function
- also add a unit test to paymentservertests.cpp
 2015-02-04 13:47:32 +01:00
Wladimir J. van der Laan 31dedb463b
Merge pull request #5509 
7f991e3 c++11: These look like user-defined literals. (Cory Fields)
5a6155c c++11: don't forward-declare types used in maps (Cory Fields)
3447cf8 c++11: MOVEONLY: break circular dependency in wallet (Cory Fields)
bbacd88 c++11: MOVEONLY: move function definitions out of the header (Cory Fields)
a2b04dd build: fix newer boost build with c++11 (Cory Fields)
 2015-02-04 13:06:16 +01:00
Wladimir J. van der Laan 87ecfb0f96
Merge pull request #5711 
5ebe095 Trim RPC command table (Wladimir J. van der Laan)
4401b2d Removed main.h dependency from rpcserver.cpp (Eric Lombrozo)
 2015-02-04 10:23:09 +01:00
Cory Fields 7f991e364e c++11: These look like user-defined literals. 
Add a space to keep the compiler happy
 2015-02-03 23:31:00 -05:00
Cory Fields 5a6155ccfa c++11: don't forward-declare types used in maps 2015-02-03 23:30:59 -05:00
Cory Fields 3447cf87e2 c++11: MOVEONLY: break circular dependency in wallet 
c++11 (libc++'s stdlib implementation anyway) doesn't allow for map types to be
forward-declared. for example:

class foo;
std::map<int, foo> bar; // error, foo has not been defined.
class foo{};

Since CWallet and CWalletTx are inter-dependent, but only std::map<*,CWalletTx>
is used, forward-declare CWallet instead and define CWalletTx first.

Despite the mangled git diff, this change only amounts to moving ~320 lines in
a single chunk.
 2015-02-03 23:30:59 -05:00
Cory Fields bbacd88204 c++11: MOVEONLY: move function definitions out of the header 
These need to be moved out of the header in order to resolve a circular
dependency between CWallet and CTxWallet. See next commit.
 2015-02-03 22:41:33 -05:00
Cory Fields a2b04ddfe6 build: fix newer boost build with c++11 2015-02-03 22:41:01 -05:00
Daniel Kraft eb1c2cd37f Split logic to undo txin's off DisconnectBlock. 
Instead, create a separate function that applies the undo operation of a
CTxInUndo object onto a CCoinsViewCache.  This method is used from
DisconnectBlock.
 2015-02-03 15:44:39 +01:00
Suhas Daftuar cf008ac8c3 Acquire CCheckQueue's lock to avoid race condition 
This fixes a potential race condition in the CCheckQueueControl constructor,
which was looking directly at data in CCheckQueue without acquiring its lock.

Remove the now-unnecessary friendship for CCheckQueueControl
 2015-02-03 08:53:08 -05:00
Wladimir J. van der Laan fcf646c9b0
Merge pull request #5286 
44e9a6b Update the 'test_IsStandard' unit test (Flavien Charlon)
a930658 Change the default maximum OP_RETURN size to 80 bytes (Flavien Charlon)
 2015-02-03 13:12:44 +01:00
Wladimir J. van der Laan e5f1f5a263
Merge pull request #5732 
1371e6f Change "insane" to "absurd" (referring to high fees) in text strings and identifiers. (Daira Hopwood)
 2015-02-03 13:12:12 +01:00
Wladimir J. van der Laan 6ee87f9bc5
Merge pull request #5647 
3ff735c Increase block download timeout base from 10 to 20 minutes. (Gregory Maxwell)
 2015-02-03 10:36:44 +01:00
Wladimir J. van der Laan 4e2b1fff98
Merge pull request #5675 
2d9b0b7 Fix priority calculation in CreateTransaction (Alex Morcos)
 2015-02-03 10:36:01 +01:00
Wladimir J. van der Laan 41e6e4caba
Merge pull request #5713 
bf6cdeb Increase coverage of DERSIG edge cases (Pieter Wuille)
819bcf9 Add RPC test for DERSIG BIP switchover logic (Pieter Wuille)
5a47811 BIP66 changeover logic (Pieter Wuille)
092e9fe Example unit tests from BIP66 (Pieter Wuille)
80ad135 Change IsDERSignature to BIP66 implementation (Pieter Wuille)
 2015-02-03 10:34:53 +01:00
Wladimir J. van der Laan 9c4a5a5067
Merge pull request #5729 
fdf80ea [Qt] allow unit changes for read-only BitcoinAmountField (Philip Kaufmann)
 2015-02-03 09:49:26 +01:00
Pieter Wuille 9fddceda44 Avoid storing a reference passed to SignatureChecker constructors 2015-02-02 20:19:46 -08:00
Pieter Wuille 858809a33e Use separate SignatureChecker for CMutableTransaction 2015-02-02 20:19:12 -08:00
Shaul Kfir f4b2078f72 Replace difficulty readjustment blocks with Interval() 2015-02-02 14:36:00 -05:00
Pieter Wuille bf6cdebdc5 Increase coverage of DERSIG edge cases 2015-02-01 17:51:25 -04:00
Pieter Wuille 5a47811da5 BIP66 changeover logic 2015-02-01 17:51:24 -04:00
Pieter Wuille 092e9fe5fb Example unit tests from BIP66 2015-02-01 17:47:21 -04:00
Pieter Wuille 80ad135a5e Change IsDERSignature to BIP66 implementation 2015-02-01 17:47:21 -04:00
Daira Hopwood 1371e6f5db Change "insane" to "absurd" (referring to high fees) in text strings and identifiers. 
Note that this will also require translation changes in Transifex for the key
"A fee higher than %1 is considered an insanely high fee." which is now
"A fee higher than %1 is considered an absurdly high fee."

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2015-01-31 23:23:20 +00:00
bikinibabe ee932025c1 Changed pronouns for correctness and inclusivity 2015-01-31 17:38:28 -05:00
Vitalii Demianets bd2b73bb9b TRIVIAL: fix misleading comment 2015-01-31 17:38:28 -05:00
Pavel Janík 5262fde0ec Remove whitespaces before double colon in errors and logs 2015-01-31 17:38:28 -05:00
Pavel Janík 91a9fe094b Fix typo - sentence starts with capital letter 2015-01-31 17:37:01 -05:00
Manuel Araoz d6bed1514c remove sig_canonical.json and sig_noncanonical.json 2015-01-31 17:36:44 -05:00
Philip Kaufmann fdf80ea7b1 [Qt] allow unit changes for read-only BitcoinAmountField 
- fixes #5725
 2015-01-31 17:39:22 +01:00
Wladimir J. van der Laan 6af674ecdc
Merge pull request #5707 
14d023f change hardcoded character constants to a set of descriptive named constants for database keys (Earlz)
 2015-01-31 14:31:12 +01:00
randy-waterhouse 72ac792b4a Format build flags in src/Makefile.am. 2015-01-30 10:43:30 +13:00
Wladimir J. van der Laan 5f04d1d0d7
Merge pull request #5477 
6bbca99 LSSharedFileListItemResolve() was deprecated in Mac OS X 10.10, use LSSharedFileListItemCopyResolvedURL() instead (Cory Fields)
 2015-01-29 13:27:23 +01:00
Wladimir J. van der Laan 7823598fa4
Merge pull request #5620 
6715efb [Qt] Payment request expiration bug fix (re-done) (Philip Kaufmann)
 2015-01-29 12:48:27 +01:00
fsb4000 55eade9d46 Change Coin Control first column label 2015-01-29 15:07:08 +06:00
Wladimir J. van der Laan 5ebe0956b3 Trim RPC command table 
- invalidateblock and reconsiderblock were defined doubly
- remove no-longer-used threadSafe, as locks have been pushed down
 2015-01-28 07:41:54 +01:00
Eric Lombrozo 4401b2d7c5 Removed main.h dependency from rpcserver.cpp 
Rebased by @laanwj:

- update for RPC methods added since 84d13ee: setmocktime,
  invalidateblock, reconsiderblock. Only the first, setmocktime, required a change,
  the other two are thread safe.
 2015-01-28 07:41:54 +01:00
Wladimir J. van der Laan 6b5f5294bb
Merge pull request #5506 
7873633 Squashed 'src/secp256k1/' changes from bccaf86..50cc6ab (Pieter Wuille)
1a9576d Use libsecp256k1's RFC6979 implementation (Pieter Wuille)
 2015-01-26 13:04:29 +01:00
Wladimir J. van der Laan 2511a39cca
Merge pull request #5575 
7b782f5 RPCWallet: Notate all account stuff as deprecated (Luke Dashjr)
 2015-01-26 12:38:22 +01:00