Continues Johnathan Corgan's work.
Publishing multipart messages
Bugfix: Add missing zmq header includes
Bugfix: Adjust build system to link ZeroMQ code for Qt binaries
* Add getlocalsolps and getnetworksolps RPC calls, show them in getmininginfo
* Add benchmark for attempting decryption of notes
* Add benchmark for incrementing note witnesses
* Add -metricsui flag to toggle between persistent screen and rolling metrics
Defaults to true if stdout is a TTY, else false.
* Add -metricsrefreshtime option
* Only show metrics by default if stdout is a TTY
* Document metrics screen options
* Fix stale comment referencing upstream block interval
* Add checkpoint at block height 15000
* Make command line option to show all debugging consistent with similar options
Most people expect a value of 1 to enable all for command line arguments.
However to do this for the -debug option you must type "-debug=".
This has been changed to allow "-debug=1" as well as "-debug=" to
enable all debug logging
* Update documentation to match the #4219 change
* Update help message to match the #4219 change
* Clarify that metrics options are only useful without -daemon and -printtoconsole
* Increase length of metrics divider
* Closes#1857. Fixes bug where tx spending only notes had priority of 0.
* Closes#1901. Increase default settings for the max block size when
mining and the amount of space available for priority transactions.
* Write witness caches when writing the best block
For steady-state operation, this reduces the average time between wallet disk
writes from once per block to once per hour.
On -rescan, witness caches are only written out at the end along with the best
block, increasing speed while ensuring that on-disk state is kept consistent.
Witness caches are now never recreated during a -reindex, on the assumption that
the blocks themselves are not changing (the chain is just being reconstructed),
and so the witnesses will remain valid.
Part of #1749.
* Add porter dev overrides for CC, CXX, MAKE, BUILD, HOST
* Apply miniupnpc patches to enable compilation on Solaris 11
These can be removed after the next MiniUPnP release.
Closes#1835.
* Closes#1903. Add fee parameter to z_sendmany.
* Add an upstream miniupnpc patch revision
* Metrics - Don't exclaim unless > 1
"You have validated 0 transactions!" sounds a little less enthusiastic that intended. Also, only says "1 transaction".
* Address review comments, tweak strings
* bash-completion: Adapt for 0.12 and 0.13
* separate completion for bitcoind and bitcoin-cli
* remove RPC support from bitcoind completion
* add completion for bitcoin-tx and bitcoin-qt
* rely on autoloading of completions
* Change function names to not clash with Bitcoin, apply to correct binaries
* Add bash completion files to Debian package
* Always bash-complete the default account
* Add Zcash RPC commands to CLI argument completion
* Fixes#1823. Witness anchors for input notes no longer cross block boundaries.
* Edit for grammar: "block chain"
At this point, I believe it is universally accepted that "blockchain" is one word, and should not be separated into two.
* Increase timeout as laptops on battery power have cpu throttling.
* Isolate verification to a `ProofVerifier` context object that allows verification behavior to be tuned by the caller.
* Regression test.
* Ensure cache contains valid entry when anchor is popped.
* Ensure ProofVerifier cannot be accidentally copied.
* Document behaviour of CWallet::SetBestChain
* WitnessAnchorData only needs to store one witness per JSOutPoint.
* Rename Dummy to Disabled.
* Add more tests for ProofVerifier.
* Fix indentation
* Generate JS for trydecryptnotes, make number of addresses a variable
* Add JS to second block to ensure witnesses are incremented
* ASSERT_TRUE -> ASSERT_FALSE
* Skip JoinSplit verification before the last checkpoint
Part of #1749
* Gather release notes from previous release to HEAD
Also update release-process.md to replace git shortlog command with
release-notes.py script.
* Add a reindex test that fails because of a bug in decrementing witness caches
Ref: https://github.com/zcash/zcash/pull/1904#issuecomment-265992988
* Make the test pass by fixing the bug!
* Only check cache validity for witnesses being incremented or decremented
Fixes the bug resulting from #1904.
* Update release process to check in with users who opened resolved issues
* Check that E' points are actually in G2 by ensuring they are of order r.
* Fix bug in wallet tests
* Extract block-generation wallet test code into a function
* Rewrite reindex test to check beyond the max witness cache size
* Fix bug in IncrementNoteWitness()
* Extend createjoinsplit to benchmark parallel JoinSplits
Closes#1940
* Update payment API docs to recommend -rescan for fixing witness errors
* Add total number of commitments to getblockchaininfo
* Update version to 1.0.4
* Update man pages
* Release notes, authors, changelog
* Only enable getblocktemplate when wallet is enabled
* Only run wallet tests when wallet is enabled
* Add a tool for profiling the creation of JoinSplits
* Add test for IncrementalMerkleTree::size().
* Exclude test binaries from make install
Closes#1943.
* Fixes#1964 to catch general exception in z_sendmany and catch
exceptions as reference-to-const.
* Fixes#1967 by adding age of note to z_sendmany logging.
* Scan the whole chain whenever a z-key is imported
Closes#1941.
* Instruct users to run zcash-fetch-params if network params aren't available
Closes#1786.
* Fixes a bug where the unsigned transaction was logged by z_sendmany
after a successful sign and send, meaning that the logged hash fragment
would be different from the txid logged by "AddToWallet". This issue
occured when sending from transparent addresses, as utxo inputs must be
signed. It did not occur when sending from shielded addresses.
* Trigger metrics UI refresh on new messages
* Strip out the SECURE flag in metrics UI so message style is detected
* Add 'CreateJoinSplit' standalone utility to gitignore.
* Handle newlines in UI messages
* Suggest ./zcutil/fetch-params.sh as well
Once we improve the from-source installation docs to use 'make install', we can
revert this commit.
* Update debug categories
Closes#1954.
* CreateJoinSplit: add start_profiling() call
This solves the problem of profiling output displaying nonsensical large time values.
* rpc: Implement random-cookie based authentication
When no `-rpcpassword` is specified, use a special 'cookie' file for
authentication. This file is generated with random content when the
daemon starts, and deleted when it exits. Read access to this file
controls who can access through RPC. By default this file is stored in
the data directory but it be overriden with `-rpccookiefile`.
This is similar to Tor CookieAuthentication: see
https://www.torproject.org/docs/tor-manual.html.en
Alternative to #6258. Like that pull, this allows running bitcoind
without any manual configuration. However, daemons should ideally never write to
their configuration files, so I prefer this solution.
* Rename build-aux/m4/bitcoin_find_bdb48.m4 to remove version
Closes#1622.
* Bump COPYRIGHT_YEAR from 2016 to 2017.
* Throw an error if zcash.conf is missing
An empty zcash.conf is sufficient to bypass this error.
* Show a friendly message explaining why zcashd needs a zcash.conf
* Closes#1780. Result of z_getoperationstatus now sorted by creation time of operation
* Create ISSUE_TEMPLATE.md
* move template to subdirectory, fix typo, include prompt under describing issue section, include uploading file directly to github ticket as option for sharing logs
* Remove UTF-8 BOM efbbbf from zcash.conf to avoid problems with command line tools
* Closes#1097 so zcash-cli now displays license info like zcashd.
LicenseInfo is refactored from init.cpp to util.cpp so that the
bitcoin-cli makefile target does not need to be modified.
* Fixes#1497 ZCA-009 by restricting data exporting to user defined folder.
Previously the RPC interface allowed z_exportwallet, backupwallet and
dumpwallet to write data to an arbitrary filename. ZCA-009 demonstrates
how this is vulnerable. The resolution is to only allow data to
written when the -exportdir has been configured. Also filenames are
restricted to alphanumeric characters.
* Closes#1957 by adding tx serialization size to listtransactions output.
* Fix gtest ordering broken by #1949
Part of #1539
* Fixes#1960: z_getoperationstatus/result now includes operation details.
* Debian package lint
- Tweak description synopsis to make Debian happy
- Put bash completion files in correct directory
- Add a manpage for zcash-fetch-params
* Generate Debian control file to fix shlibs lint
* Create empty zcash.conf during performance measurements
* Create empty zcash.conf during coverage checks
Fixes regression caused by #2013.
* Coverage build system tweaks
* Update walletbackup.py qa test to use -exportdir option
* Add missing header required by std::accumulate
* Increase timeout for z_sendmany transaction in wallet.py qa test
* Add test for z_importkey rescanning from beginning of chain.
* Bump version to 1.0.5.
* Update release notes and Debian package.
* V1.0.4 mac (#51)
* initial mac version of zclassic
Work in progress - 15JAN2017
more refactoring
linux refactoring fixes
osx refactoring fixes
initial win64 commit
fixup! initial win64 commit
compile libsnark with posix threads
build gtest and gmock with posix
Working build
fixup! Working build
* Windows and Linux builds ok
* fixup! Merge tag 'v1.0.5' into v1.0.5-multios
* fixup! fixup! Merge tag 'v1.0.5' into v1.0.5-multios
* fixup! fixup! fixup! Merge tag 'v1.0.5' into v1.0.5-multios
* Fix OSX compatibility with depends
* OSX Compat - Fix site_t ambiguity in json
* fixup! OSX Compat - Fix site_t ambiguity in json
* Add getlocalsolps and getnetworksolps RPC calls, show them in getmininginfo
* Add benchmark for attempting decryption of notes
* Add benchmark for incrementing note witnesses
* Add -metricsui flag to toggle between persistent screen and rolling metrics
Defaults to true if stdout is a TTY, else false.
* Add -metricsrefreshtime option
* Only show metrics by default if stdout is a TTY
* Document metrics screen options
* Fix stale comment referencing upstream block interval
* Add checkpoint at block height 15000
* Added mainnet, testnet, and onion nodes
* Make command line option to show all debugging consistent with similar options
Most people expect a value of 1 to enable all for command line arguments.
However to do this for the -debug option you must type "-debug=".
This has been changed to allow "-debug=1" as well as "-debug=" to
enable all debug logging
* Update documentation to match the #4219 change
* Update help message to match the #4219 change
* Clarify that metrics options are only useful without -daemon and -printtoconsole
* Increase length of metrics divider
* Closes#1857. Fixes bug where tx spending only notes had priority of 0.
* Closes#1901. Increase default settings for the max block size when
mining and the amount of space available for priority transactions.
* Write witness caches when writing the best block
For steady-state operation, this reduces the average time between wallet disk
writes from once per block to once per hour.
On -rescan, witness caches are only written out at the end along with the best
block, increasing speed while ensuring that on-disk state is kept consistent.
Witness caches are now never recreated during a -reindex, on the assumption that
the blocks themselves are not changing (the chain is just being reconstructed),
and so the witnesses will remain valid.
Part of #1749.
* Add porter dev overrides for CC, CXX, MAKE, BUILD, HOST
* Apply miniupnpc patches to enable compilation on Solaris 11
These can be removed after the next MiniUPnP release.
Closes#1835.
* Closes#1903. Add fee parameter to z_sendmany.
* Add an upstream miniupnpc patch revision
* Metrics - Don't exclaim unless > 1
"You have validated 0 transactions!" sounds a little less enthusiastic that intended. Also, only says "1 transaction".
* Address review comments, tweak strings
* bash-completion: Adapt for 0.12 and 0.13
* separate completion for bitcoind and bitcoin-cli
* remove RPC support from bitcoind completion
* add completion for bitcoin-tx and bitcoin-qt
* rely on autoloading of completions
* Change function names to not clash with Bitcoin, apply to correct binaries
* Add bash completion files to Debian package
* Always bash-complete the default account
* Add Zcash RPC commands to CLI argument completion
* Fixes#1823. Witness anchors for input notes no longer cross block boundaries.
* Edit for grammar: "block chain"
At this point, I believe it is universally accepted that "blockchain" is one word, and should not be separated into two.
* Increase timeout as laptops on battery power have cpu throttling.
* Isolate verification to a `ProofVerifier` context object that allows verification behavior to be tuned by the caller.
* Regression test.
* Ensure cache contains valid entry when anchor is popped.
* Ensure ProofVerifier cannot be accidentally copied.
* Document behaviour of CWallet::SetBestChain
* WitnessAnchorData only needs to store one witness per JSOutPoint.
* Rename Dummy to Disabled.
* Add more tests for ProofVerifier.
* Fix indentation
* Generate JS for trydecryptnotes, make number of addresses a variable
* Add JS to second block to ensure witnesses are incremented
* ASSERT_TRUE -> ASSERT_FALSE
* Skip JoinSplit verification before the last checkpoint
Part of #1749
* Gather release notes from previous release to HEAD
Also update release-process.md to replace git shortlog command with
release-notes.py script.
* Add a reindex test that fails because of a bug in decrementing witness caches
Ref: https://github.com/zcash/zcash/pull/1904#issuecomment-265992988
* Make the test pass by fixing the bug!
* Only check cache validity for witnesses being incremented or decremented
Fixes the bug resulting from #1904.
* Check that E' points are actually in G2 by ensuring they are of order r.
* Fix bug in wallet tests
* Extract block-generation wallet test code into a function
* Rewrite reindex test to check beyond the max witness cache size
* Fix bug in IncrementNoteWitness()
* Update payment API docs to recommend -rescan for fixing witness errors
* Update version to 1.0.4
* Update man pages
* Release notes, authors, changelog
* Update seed nodes
* Bugfix #14 - getblocksubsidy RPC command is incorrect
* separate completion for bitcoind and bitcoin-cli
* remove RPC support from bitcoind completion
* add completion for bitcoin-tx and bitcoin-qt
* rely on autoloading of completions
Debian packaging fixes
* Updates maintainer scripts from latest version of `dh_make`
* Includes `rules` file
* Use `fakeroot` to build the package.
We use currently `dpkg-deb --build` instead of `debuild` or `dpkg-buildpackage`, so I don't know if the package is well-formatted for the latter. (one difference, the former works with uppercase `DEBIAN`, the latter lowercase `debian` -- that's why the directory was renamed)
Cleanup documentation
Added zcash developer public keys to /contrib/gitian-downloader, incorporated some of @daira's suggestions for files in the /doc directory
Upstream gitian updates
This PR pulls in all gitian-related PRs that have been merged upstream since 0.11.2. The only ones I left out were documentation-only PRs, because we removed `doc/gitian-building.md` at some point. Here are the commits applied here, in the order shown in `git log` (ie. last to first):
- bitcoin/bitcoin#7283
- fa42a67
- fa58c76
- bitcoin/bitcoin#8175
- 74c1347
- bitcoin/bitcoin#8167
- 7e7eb27
- ad38204
- b676f38
- bitcoin/bitcoin#7776
- f063863
- bitcoin/bitcoin#7424
- a81c87f ~ we already partly applied
- a8ce872
- f3d3eaf ~ we already partly applied
- 475813b
- ~~cd27bf5~~ X we already applied
- bitcoin/bitcoin#7060
- 3b468a0 ~ we removed doc/gitian-building.md
- ~~99fda26~~ X we removed doc/gitian-building.md
- bitcoin/bitcoin#7251
- fa09562
- bitcoin/bitcoin#6900
- ~~2cecb24~~ X we removed doc/gitian-building.md
- 957c0fd
- 2e31d74
- ~~0b416c6~~ X we removed QT
- 9f251b7
- bitcoin/bitcoin#6854
- 579b863 ~ we already partly applied
Part of #540
The -debug tarballs/zips contain detached debugging symbols. To use them, place
in the same dir as the target binary, and invoke gdb as usual.
Also, because the debug symbols add a substantial space requirement, the build
dirs are now deleted when they're no longer needed.
This removes the following executables from the binary gitian release:
- test_bitcoin-qt[.exe]
- bench_bitcoin[.exe]
@jonasschnelli and me discussed this on IRC a few days ago - unlike the
normal `bitcoin_tests` which is useful to see if it is safe to run
bitcoin on a certain OS/environment combination, there is no good reason
to include these. Better to leave them out to reduce the download
size.
Sizes from the 0.12 release:
```
2.4M bitcoin-0.12.0/bin/bench_bitcoin.exe
22M bitcoin-0.12.0/bin/test_bitcoin-qt.exe
```
Add a check to symbol-check.py that checks that only the subset of
allowed libraries is imported (to avoid incompatibilities).
See 56734f4b27 for the earlier changes.
This adds some source files, a script and skeleton for building
a Debian package that installs the zcash daemon and CLI tool.
Also removes unused Bitcoin files.
Common sentiment is that the miniupnpc codebase likely contains further
vulnerabilities.
I'd prefer to get rid of the dependency completely, but a compromise for
now is to at least disable it by default.
Github-Pull: #6795
Rebased-From: 21d27ebad5721bc61c62bc72dc3ab3197f9da268
joshuayabut
Simon
Jack Grigg
isle2983
Jonas Schnelli
Jeff Garzik
Sean Bowe
Christian von Roques
Rhett Creighton
zkbot
Daira Hopwood
Kevin Gallagher
Paige Peterson
MarcoFalke
Wladimir J. van der Laan
Cory Fields
Jay Graber
Taylor Hornby
Matt Corallo
Zak Wilcox
Diego Viola
Veres Lajos