BTCPrivate
/
bitcore
mirror of https://github.com/BTCPrivate/bitcore.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #1337 from braydonf/coinbase-fee 

Return zero for coinbase transaction fee.
This commit is contained in:
Patrick Nagurny 2015-09-29 10:59:52 -04:00
parent 966c88f138 0e24e4c421
commit a419a1b037
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/transaction/transaction.js
View File

@ -843,6 +843,9 @@ Transaction.prototype._updateChangeOutput = function() {
* @return {Number} fee of this transaction in satoshis
*/
Transaction.prototype.getFee = function() {
if (this.isCoinbase()) {
return 0;
}
if (!_.isUndefined(this._fee)) {
return this._fee;
}

6
test/transaction/transaction.js
View File

@ -62,6 +62,12 @@ describe('Transaction', function() {
testTransaction.getFee().should.equal(10000);
});
it('will return zero as the fee for a coinbase', function() {
// block #2: 0e3e2357e806b6cdb1f70b54c3a3a17b6714ee1f0e68bebb44a74b1efd512098
var coinbaseTransaction = new Transaction('01000000010000000000000000000000000000000000000000000000000000000000000000ffffffff0704ffff001d0104ffffffff0100f2052a0100000043410496b538e853519c726a2c91e61ec11600ae1390813a627c66fb8be7947be63c52da7589379515d4e0a604f8141781e62294721166bf621e73a82cbf2342c858eeac00000000');
coinbaseTransaction.getFee().should.equal(0);
});
it('serialize to Object roundtrip', function() {
var a = testTransaction.toObject();
var newTransaction = new Transaction(a);