BTCPrivate
/
bitcore
mirror of https://github.com/BTCPrivate/bitcore.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Transport/Pool: Use sinon for tests.

This commit is contained in:
Braydon Fuller 2014-12-15 14:10:45 -05:00
parent 1a1d63321a
commit e04cb76854
3 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/transport/pool.js
View File

@ -28,15 +28,10 @@ function now(){
* @returns {Pool} * @returns {Pool}
* @constructor * @constructor
*/ */
function Pool(network, options) { function Pool(network) {
var self = this; var self = this;
if (!options) {
options = {};
}
this.dns = options.dns || dns;
this.network = Networks.get(network) || Networks.defaultNetwork; this.network = Networks.get(network) || Networks.defaultNetwork;
this.connectedPeers = []; this.connectedPeers = [];
this.addrs = []; this.addrs = [];
@ -246,7 +241,7 @@ Pool.prototype.addAddr = function addAddr(addr) {
*/ */
Pool.prototype.addAddrsFromSeed = function addAddrsFromSeed(seed, done) { Pool.prototype.addAddrsFromSeed = function addAddrsFromSeed(seed, done) {
var self = this; var self = this;
this.dns.resolve(seed, function(err, ips) { dns.resolve(seed, function(err, ips) {
if (err) { if (err) {
self.emit('error', err); self.emit('error', err);
return done(); return done();

1
package.json
View File

@ -98,6 +98,7 @@
"gulp-shell": "^0.2.10", "gulp-shell": "^0.2.10",
"mocha": "~2.0.1", "mocha": "~2.0.1",
"run-sequence": "^1.0.2", "run-sequence": "^1.0.2",
"sinon": "^1.12.2",
"karma": "^0.12.28", "karma": "^0.12.28",
"karma-firefox-launcher": "^0.1.3", "karma-firefox-launcher": "^0.1.3",
"karma-mocha": "^0.1.9" "karma-mocha": "^0.1.9"

13
test/transport/pool.js
View File

@ -10,6 +10,9 @@ if (typeof(window) === 'undefined'){
var should = chai.should(); var should = chai.should();
var expect = chai.expect; var expect = chai.expect;
var dns = require('dns');
var sinon = require('sinon');
var bitcore = require('../..'); var bitcore = require('../..');
var Peer = bitcore.transport.Peer; var Peer = bitcore.transport.Peer;
var Pool = bitcore.transport.Pool; var Pool = bitcore.transport.Pool;
@ -28,14 +31,14 @@ if (typeof(window) === 'undefined'){
}); });
it('should discover peers via dns', function() { it('should discover peers via dns', function() {
// mock dns var stub = sinon.stub(dns, 'resolve', function(seed, callback){
var dns = function() {};
dns.resolve = function(seed, callback){
callback(null, ['10.10.10.1', '10.10.10.2', '10.10.10.3']); callback(null, ['10.10.10.1', '10.10.10.2', '10.10.10.3']);
}; });
var pool = new Pool(Networks.livenet, {dns: dns}); var pool = new Pool(Networks.livenet);
pool.connect(); pool.connect();
pool.addrs.length.should.equal(3); pool.addrs.length.should.equal(3);
stub.restore();
}); });
it('should not discover peers via dns', function() { it('should not discover peers via dns', function() {