From a0a4d4387769b25ff84728f306bacca8dd6fb46e Mon Sep 17 00:00:00 2001 From: ssotomayor Date: Thu, 2 Oct 2014 13:51:56 -0300 Subject: [PATCH 1/2] Removes mobile check. Adds QA bug reporting standard to Readme. --- CONTRIBUTE.md | 22 ++++++++++++++++++++++ README.md | 24 ++++++++++++++++++++++++ js/controllers/more.js | 1 - views/more.html | 2 +- 4 files changed, 47 insertions(+), 2 deletions(-) create mode 100644 CONTRIBUTE.md diff --git a/CONTRIBUTE.md b/CONTRIBUTE.md new file mode 100644 index 000000000..26ba247e4 --- /dev/null +++ b/CONTRIBUTE.md @@ -0,0 +1,22 @@ +# QA - Bug Reporting + +In the interest of improving bug reporting, each bug that you find and want to create a ticket about it, please refer to a form that contains: + +· Brief description of the bug +· Steps to reproduce it +· Platform in which you are testing +· Screenshots if possible. +· Expected behaviour. + +i.e: + +The application fails at login. + +1) Launch the app `npm run start` +2) Click on "Join a Wallet" +3) Type an unexistent username +4) The app stops working, throws "Unhandled exception" error. + +Expected: The app should login and show the home screen without any error. + +Platform: Android 4.3, Android 4.4, iOS \ No newline at end of file diff --git a/README.md b/README.md index ed379bb1c..2be886b8b 100644 --- a/README.md +++ b/README.md @@ -167,6 +167,28 @@ $ npm run-script firefox browser-extensions/firefox/copay.xpi ` +# QA - Bug Reporting + +In the interest of improving bug reporting, each bug that you find and want to create a ticket about it, please refer to a form that contains: + +· Brief description of the bug +· Steps to reproduce it +· Platform in which you are testing +· Screenshots if possible +· Expected behaviour + +i.e: + +The application fails at login. + +1) Launch the app `npm run start` +2) Click on "Join a Wallet" +3) Type an unexistent username +4) The app stops working, throws "Unhandled exception" error. + +Expected: The app should login to the home screen after clicking login and show no errors. + +Platform: Android 4.3, Android 4.4, iOS ## Web App @@ -183,6 +205,8 @@ $ sh webapp/build.sh + + # About Copay General diff --git a/js/controllers/more.js b/js/controllers/more.js index b47d00296..c06aeb3eb 100644 --- a/js/controllers/more.js +++ b/js/controllers/more.js @@ -3,7 +3,6 @@ angular.module('copayApp.controllers').controller('MoreController', function($scope, $rootScope, $location, $filter, backupService, walletFactory, controllerUtils, notification, rateService, isMobile) { var w = $rootScope.wallet; - $scope.isMobile = isMobile.iOS(); $scope.unitOpts = [{ name: 'Satoshis (100,000,000 satoshis = 1BTC)', diff --git a/views/more.html b/views/more.html index 375eb61cf..65eafed3b 100644 --- a/views/more.html +++ b/views/more.html @@ -1,6 +1,6 @@

Settings

-
+

Backup

It's important to backup your wallet so that you can recover it in case of disaster

From afa754f3df69e81d55ef2043ca38168272697c29 Mon Sep 17 00:00:00 2001 From: ssotomayor Date: Thu, 2 Oct 2014 13:55:30 -0300 Subject: [PATCH 2/2] Removes "isMobile" service from controller. --- js/controllers/more.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/controllers/more.js b/js/controllers/more.js index c06aeb3eb..5f06a84a3 100644 --- a/js/controllers/more.js +++ b/js/controllers/more.js @@ -1,7 +1,7 @@ 'use strict'; angular.module('copayApp.controllers').controller('MoreController', - function($scope, $rootScope, $location, $filter, backupService, walletFactory, controllerUtils, notification, rateService, isMobile) { + function($scope, $rootScope, $location, $filter, backupService, walletFactory, controllerUtils, notification, rateService) { var w = $rootScope.wallet; $scope.unitOpts = [{