From fac553eb1483f11d5d8b3628170f7f41f8aaa2a8 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Thu, 22 Sep 2016 18:24:46 -0300 Subject: [PATCH 01/47] Return cached address while BWS returns main address GAP reached --- src/js/controllers/tab-receive.js | 5 +---- src/js/services/walletService.js | 25 ++++++------------------- 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/src/js/controllers/tab-receive.js b/src/js/controllers/tab-receive.js index 26e71e57c..763253d95 100644 --- a/src/js/controllers/tab-receive.js +++ b/src/js/controllers/tab-receive.js @@ -51,10 +51,7 @@ angular.module('copayApp.controllers').controller('tabReceiveController', functi $timeout(function() { walletService.getAddress($scope.wallet, forceNew, function(err, addr) { $scope.generatingAddress = false; - if (err || lodash.isEmpty(addr)) { - popupService.showAlert(gettextCatalog.getString('Error'), err || gettextCatalog.getString('Address is empty')); - return; - } + if (err) popupService.showAlert(gettextCatalog.getString('Error'), err); $scope.addr = addr; $scope.$apply(); }); diff --git a/src/js/services/walletService.js b/src/js/services/walletService.js index 0c9d00583..aedd12eb3 100644 --- a/src/js/services/walletService.js +++ b/src/js/services/walletService.js @@ -791,29 +791,16 @@ angular.module('copayApp.services').factory('walletService', function($log, $tim root.getAddress = function(wallet, forceNew, cb) { - var firstStep; - if (forceNew) { - firstStep = storageService.clearLastAddress; - } else { - firstStep = function(walletId, cb) { - return cb(); - }; - } - - firstStep(wallet.id, function(err) { + storageService.getLastAddress(wallet.id, function(err, addr) { if (err) return cb(err); - storageService.getLastAddress(wallet.id, function(err, addr) { - if (err) return cb(err); + if (!forceNew && addr) return cb(null, addr); - if (addr) return cb(null, addr); - - createAddress(wallet, function(err, addr) { + createAddress(wallet, function(err, _addr) { + if (err) return cb(err, addr); + storageService.storeLastAddress(wallet.id, _addr, function() { if (err) return cb(err); - storageService.storeLastAddress(wallet.id, addr, function() { - if (err) return cb(err); - return cb(null, addr); - }); + return cb(null, _addr); }); }); }); From f82ea8502fb0e237dfd5a0b9bd24094021caacd3 Mon Sep 17 00:00:00 2001 From: Jamal Jackson Date: Fri, 23 Sep 2016 09:50:17 -0400 Subject: [PATCH 02/47] started new address book styling --- public/views/addressbook.add.html | 4 ++-- src/sass/main.scss | 1 + src/sass/views/address-book.scss | 5 +++++ 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 src/sass/views/address-book.scss diff --git a/public/views/addressbook.add.html b/public/views/addressbook.add.html index f7f575305..11e528f5a 100644 --- a/public/views/addressbook.add.html +++ b/public/views/addressbook.add.html @@ -1,4 +1,4 @@ - + Add Contact @@ -16,7 +16,7 @@
-
+