[V4] remove warnings

src/pages/feedback/feedback-complete/feedback-complete.ts

@@ -35,7 +35,6 @@ export class FeedbackCompletePage {
   private downloadUrl: string;
   private shareFacebookVia: string;
   private shareTwitterVia: string;
-  private shareGooglePlusVia: string;
 
   constructor(
     private navCtrl: NavController,

src/pages/feedback/feedback/feedback.ts

@@ -1,5 +1,5 @@
 import { Component } from '@angular/core';
-import { NavParams, Platform, NavController } from 'ionic-angular';
+import { NavParams, NavController } from 'ionic-angular';
 import { Logger } from '@nsalaun/ng-logger';
 
 //providers
@@ -33,7 +33,6 @@ export class FeedbackPage {
     private appProvider: AppProvider,
     private configProvider: ConfigProvider,
     private navParams: NavParams,
-    private platform: Platform,
     private feedbackProvider: FeedbackProvider,
     private navCtrl: NavController,
     private logger: Logger,

src/pages/feedback/send-feedback/send-feedback.ts

@@ -8,7 +8,6 @@ import { AppProvider } from '../../../providers/app/app';
 import { OnGoingProcessProvider } from '../../../providers/on-going-process/on-going-process';
 import { FeedbackProvider } from '../../../providers/feedback/feedback';
 import { PopupProvider } from '../../../providers/popup/popup';
-import { PlatformProvider } from '../../../providers/platform/platform';
 
 //pages
 import { FeedbackCompletePage } from '../feedback-complete/feedback-complete';
@@ -39,7 +38,6 @@ export class SendFeedbackPage {
     private feedbackProvider: FeedbackProvider,
     private formBuilder: FormBuilder,
     private popupProvider: PopupProvider,
-    private platformProvider: PlatformProvider
   ) {
     this.feedbackForm = this.formBuilder.group({
       comment: ['', Validators.compose([Validators.minLength(1), Validators.required])]
@@ -99,7 +97,7 @@ export class SendFeedbackPage {
         let title = 'Thank you!'; //TODO gettextcatalog
         let message = 'A member of the team will review your feedback as soon as possible.'; //TODO gettextcatalog
         let okText = 'Finish'; //TODO gettextcatalog
-        this.popupProvider.ionicAlert(title, message).then(() => {
+        this.popupProvider.ionicAlert(title, message, okText).then(() => {
           this.feedback = '';
           this.navCtrl.pop();
         });

src/pages/home/home.ts

@@ -1,5 +1,5 @@
 import { Component } from '@angular/core';
-import { NavController, Events, ModalController, NavParams } from 'ionic-angular';
+import { NavController, Events, ModalController } from 'ionic-angular';
 import { Logger } from '@nsalaun/ng-logger';
 
 // Pages
@@ -91,7 +91,6 @@ export class HomePage {
     private nextStepsProvider: NextStepsProvider,
     private persistenceProvider: PersistenceProvider,
     private feedbackProvider: FeedbackProvider,
-    private navParams: NavParams
   ) {
     this.cachedBalanceUpdateOn = '';
     this.isNW = this.platformProvider.isNW;

src/pages/includes/feedback-card/feedback-card.ts

@@ -1,11 +1,10 @@
-import { Component, Input } from "@angular/core";
+import { Component } from "@angular/core";
 import { NavController, Events } from 'ionic-angular';
 import { Logger } from '@nsalaun/ng-logger';
 
 //providers
 import { AppProvider } from '../../../providers/app/app';
 import { PersistenceProvider } from '../../../providers/persistence/persistence';
-import { PlatformProvider } from '../../../providers/platform/platform';
 
 //pages
 import { FeedbackPage } from '../../../pages/feedback/feedback/feedback';
@@ -21,18 +20,14 @@ export class FeedbackCardPage {
   public score: number;
   public button_title: string;
 
-  private isCordova: boolean;
-
   constructor(
     private appProvider: AppProvider,
     private navCtrl: NavController,
     private logger: Logger,
     private persistenceProvider: PersistenceProvider,
     private events: Events,
-    private platformProvider: PlatformProvider
   ) {
     this.appName = this.appProvider.info.nameCase;
-    this.isCordova = this.platformProvider.isCordova;
     this.score = 0;
   }
 

src/pages/integrations/glidera/modal/glidera-tx-details.ts

@@ -1,6 +1,5 @@
 import { Component } from '@angular/core';
-import { NavController, NavParams, ModalController, ViewController } from 'ionic-angular';
-import { Logger } from '@nsalaun/ng-logger';
+import { NavParams, ViewController } from 'ionic-angular';
 
 @Component({
   selector: 'page-glidera-tx-details',
@@ -11,7 +10,6 @@ export class GlideraTxDetailsPage {
   public tx: any;
 
   constructor(
-    private logger: Logger,
     private navParams: NavParams,
     private viewCtrl: ViewController
   ) {

src/pages/settings/bitcoin-cash/bitcoin-cash.ts

@@ -51,7 +51,7 @@ export class BitcoinCashPage {
 		this.walletsBCH = [];
 		this.availableWallets = [];
 		this.nonEligibleWallets = [];
-		this.errors = bwcProvider.getErrors();
+		this.errors = this.bwcProvider.getErrors();
 	}
 
 	ionViewWillEnter() {
@@ -126,25 +126,25 @@ export class BitcoinCashPage {
 		}
 
 		let importOrCreate = () => {
-			return new Promise ((resolve, reject) => {
+			return new Promise((resolve, reject) => {
 				this.walletProvider.getStatus(wallet, {}).then((status: any) => {
 					opts.singleAddress = status.wallet.singleAddress;
-	
+
 					// first try to import
 					this.profileProvider.importExtendedPrivateKey(opts.extendedPrivateKey, opts).then((newWallet) => {
-						return resolve({ newWallet: newWallet});
+						return resolve({ newWallet: newWallet });
 					}).catch((err) => {
 						if (!(err instanceof this.errors.NOT_AUTHORIZED)) {
 							return reject(err);
 						}
 						// create and store a wallet
 						this.profileProvider.createWallet(opts).then((newWallet) => {
-							return resolve({ newWallet: newWallet, isNew: true});
+							return resolve({ newWallet: newWallet, isNew: true });
 						});
 					}).catch((err) => {
 						return reject(err);
 					});
-				}).catch((err) =>{
+				}).catch((err) => {
 					return reject(err);
 				});
 			});
@@ -160,7 +160,7 @@ export class BitcoinCashPage {
 			this.walletProvider.copyCopayers(wallet, newWallet, (err) => {
 				if (err) {
 					return setErr(err);
-				} 
+				}
 				return cb();
 			});
 		};

src/providers/feedback/feedback.ts

@@ -1,8 +1,6 @@
 import { Injectable } from '@angular/core';
 import { HttpClient, HttpHeaders, HttpParams } from '@angular/common/http';
 import { Logger } from '@nsalaun/ng-logger';
-import { log } from 'util';
-import { concat } from 'rxjs/operator/concat';
 
 @Injectable()
 export class FeedbackProvider {