From 8115d156750780c4dc7758a6dd7a372c2b382c51 Mon Sep 17 00:00:00 2001 From: Jason Dreyzehner Date: Wed, 26 Oct 2016 20:18:34 -0400 Subject: [PATCH] fix(build): only install the fileicon module on macOS --- app-template/build-macos.sh | 3 +++ app-template/package-template.json | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app-template/build-macos.sh b/app-template/build-macos.sh index f214b1fb4..5f09bd0b2 100755 --- a/app-template/build-macos.sh +++ b/app-template/build-macos.sh @@ -116,6 +116,9 @@ mkdir /Volumes/"${VOL_NAME}"/.background cp "${DMG_BACKGROUND_IMG}" /Volumes/"${VOL_NAME}"/.background/ echo "Adding volume icon to disk image" +# we install this here to avoid trying to install it on linux or windows, where +# it fails to install +npm install fileicon # use fileicon node_module cp "${DMG_VOLUME_ICON}" /Volumes/"${VOL_NAME}"/.VolumeIcon.icns `npm bin`/fileicon set /Volumes/"${VOL_NAME}"/ /Volumes/"${VOL_NAME}"/.VolumeIcon.icns diff --git a/app-template/package-template.json b/app-template/package-template.json index 2ef5e1979..0148205a9 100644 --- a/app-template/package-template.json +++ b/app-template/package-template.json @@ -118,7 +118,6 @@ "ionic": "^2.1.0", "trash-cli": "^1.4.0", "lodash": "^4.3.0", - "fileicon": "^0.1.8", "pre-commit": "^1.1.3" }, "pre-commit": "unstage-package"