From f55d243bedd0045c398588338f7a664f3158be69 Mon Sep 17 00:00:00 2001
From: Gustavo Cortez <cmgustavo83@gmail.com>
Date: Thu, 17 Apr 2014 16:42:27 -0300
Subject: [PATCH 1/2] Refactory get balance 's methods

---
 js/controllers/home.js          |  3 +--
 js/models/blockchain/Insight.js | 11 -----------
 js/models/core/Wallet.js        | 26 +++++++++++++++++++++-----
 js/services/controllerUtils.js  |  4 ++--
 test/test.blockchain.Insight.js |  6 ------
 5 files changed, 24 insertions(+), 26 deletions(-)

diff --git a/js/controllers/home.js b/js/controllers/home.js
index 75f059d01..8519571ea 100644
--- a/js/controllers/home.js
+++ b/js/controllers/home.js
@@ -9,8 +9,7 @@ angular.module('copay.home').controller('HomeController',
     
     var _getBalance = function() {
       $scope.addrs.forEach(function(addr) {
-        $rootScope.wallet.blockchain.listUnspent([addr], function(unspent) {
-          var balance = $rootScope.wallet.blockchain.getBalance(unspent);
+        $rootScope.wallet.getBalance([addr], function(balance) {
           $scope.addrBalance[addr] = balance;
           $scope.$digest();
         });
diff --git a/js/models/blockchain/Insight.js b/js/models/blockchain/Insight.js
index 3db6a1b06..e2fe60c72 100644
--- a/js/models/blockchain/Insight.js
+++ b/js/models/blockchain/Insight.js
@@ -29,17 +29,6 @@ function _asyncForEach(array, fn, callback) {
   }
 }; 
 
-Insight.prototype.getBalance = function(unspent) {
-  var balance = 0;
-  for(var i=0;i<unspent.length; i++) {
-    balance = balance + unspent[i].amount;
-  }
-  if (balance) {
-    balance = balance.toFixed(4);
-  }
-  return balance;
-};
-
 Insight.prototype.listUnspent = function(addresses, cb) {
   var self = this;
   
diff --git a/js/models/core/Wallet.js b/js/models/core/Wallet.js
index 7c7231279..df720d418 100644
--- a/js/models/core/Wallet.js
+++ b/js/models/core/Wallet.js
@@ -277,21 +277,37 @@ Wallet.prototype.getAddressesStr = function() {
   return ret;
 };
 
-Wallet.prototype.getBalance = function(cb) {
+Wallet.prototype.getTotalBalance = function(cb) {
+  this.getBalance(this.getAddressesStr(), function(balance) {
+    return cb(balance);
+  });
+};
+
+Wallet.prototype.getBalance = function(addrs, cb) {
   var balance = 0;
-  this.blockchain.listUnspent(this.getAddressesStr(), function(unspent) {
+  this.listUnspent(addrs, function(unspent) {
     for(var i=0;i<unspent.length; i++) {
       balance = balance + unspent[i].amount;
     }
     if (balance) {
-      balance = balance.toFixed(4);
+      if (balance === parseInt(balance)) {
+        balance = balance;
+      }
+      else {
+        balance = balance.toFixed(8);
+      }
     }
     return cb(balance);
   });
 };
 
-Wallet.prototype.listUnspent = function(cb) {
-  this.blockchain.listUnspent(this.getAddressesStr(), cb);
+Wallet.prototype.listUnspent = function(addrs, cb) {
+  if (!addrs) {
+    addrs = this.getAddressesStr();
+  }
+  this.blockchain.listUnspent(addrs, function(unspent) {
+    return cb(unspent);
+  });
 };
 
 
diff --git a/js/services/controllerUtils.js b/js/services/controllerUtils.js
index 7963572c5..7167381d0 100644
--- a/js/services/controllerUtils.js
+++ b/js/services/controllerUtils.js
@@ -8,7 +8,7 @@ angular.module('copay.controllerUtils').factory('controllerUtils', function ($ro
       $rootScope.wallet = w;
       
       // Initial getBalance
-      $rootScope.wallet.getBalance(function(balance) {
+      $rootScope.wallet.getTotalBalance(function(balance) {
         $rootScope.totalBalance = balance;
         $rootScope.$digest();
       });
@@ -34,7 +34,7 @@ angular.module('copay.controllerUtils').factory('controllerUtils', function ($ro
     addrs.forEach(function(addr) {
       socket.on(addr, function(txid) {
         console.log('Received!', txid);
-        $rootScope.wallet.getBalance(function(balance) {
+        $rootScope.wallet.getTotalBalance(function(balance) {
           scope.$apply(function() {
             $rootScope.totalBalance = balance;
           });
diff --git a/test/test.blockchain.Insight.js b/test/test.blockchain.Insight.js
index c5fd13ff6..a17cb07ce 100644
--- a/test/test.blockchain.Insight.js
+++ b/test/test.blockchain.Insight.js
@@ -61,12 +61,6 @@ describe('Insight model', function() {
       done();
     });
   });
-  it('should return balance', function () {
-    var w = new Insight();
-    var b = w.getBalance(unspent); 
-    should.exist(b);
-    b.should.equal(91);
-  });
   it.skip('should return txid', function (done) {
     var w = new Insight();
     w.sendRawTransaction(rawtx, function(a) { 

From f5fd03ad3c369f078a026843e308f730d23032d2 Mon Sep 17 00:00:00 2001
From: Gustavo Cortez <cmgustavo83@gmail.com>
Date: Thu, 17 Apr 2014 17:01:45 -0300
Subject: [PATCH 2/2] Fix refactory for createTx.

---
 js/models/core/Wallet.js | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/js/models/core/Wallet.js b/js/models/core/Wallet.js
index df720d418..b30de0771 100644
--- a/js/models/core/Wallet.js
+++ b/js/models/core/Wallet.js
@@ -285,9 +285,9 @@ Wallet.prototype.getTotalBalance = function(cb) {
 
 Wallet.prototype.getBalance = function(addrs, cb) {
   var balance = 0;
-  this.listUnspent(addrs, function(unspent) {
-    for(var i=0;i<unspent.length; i++) {
-      balance = balance + unspent[i].amount;
+  this.listUnspent(addrs, function(utxos) {
+    for(var i=0;i<utxos.length; i++) {
+      balance = balance + utxos[i].amount;
     }
     if (balance) {
       if (balance === parseInt(balance)) {
@@ -302,11 +302,8 @@ Wallet.prototype.getBalance = function(addrs, cb) {
 };
 
 Wallet.prototype.listUnspent = function(addrs, cb) {
-  if (!addrs) {
-    addrs = this.getAddressesStr();
-  }
-  this.blockchain.listUnspent(addrs, function(unspent) {
-    return cb(unspent);
+  this.blockchain.listUnspent(addrs, function(utxos) {
+    return cb(utxos);
   });
 };
 
@@ -327,7 +324,7 @@ Wallet.prototype.createTx = function(toAddress, amountSatStr, opts, cb) {
     opts.remainderOut={ address: this.publicKeyRing.generateAddress(true).toString()};
   }
 
-  self.listUnspent(function(utxos) {
+  self.listUnspent(self.getAddressesStr(), function(utxos) {
     // TODO check enough funds, etc.
     self.createTxSync(toAddress, amountSatStr, utxos, opts);
     self.store();