From e5a4e3c25cecb544f2ddba7bf7d2f9b0babbbb3e Mon Sep 17 00:00:00 2001 From: Mario Colque Date: Fri, 18 Apr 2014 15:22:02 -0300 Subject: [PATCH 1/4] modev wallet validation from all controllers to router --- js/controllers/backup.js | 7 +------ js/controllers/header.js | 4 ---- js/controllers/home.js | 4 ---- js/controllers/peer.js | 7 +------ js/controllers/send.js | 7 +------ js/controllers/setup.js | 1 + js/controllers/signin.js | 4 ++-- js/controllers/transactions.js | 12 +++--------- js/routes.js | 8 ++++++++ 9 files changed, 17 insertions(+), 37 deletions(-) diff --git a/js/controllers/backup.js b/js/controllers/backup.js index bad72f097..309da15dc 100644 --- a/js/controllers/backup.js +++ b/js/controllers/backup.js @@ -2,12 +2,7 @@ angular.module('copay.backup').controller('BackupController', function($scope, $rootScope, $location, $window, $timeout, Socket, controllerUtils) { - if (!$rootScope.wallet || !$rootScope.wallet.id) { - $location.path('signin'); - } - else { - controllerUtils.handleTransactionByAddress($scope); - } + controllerUtils.handleTransactionByAddress($scope); $scope.title = 'Backup'; diff --git a/js/controllers/header.js b/js/controllers/header.js index d6680e76b..9919d11fd 100644 --- a/js/controllers/header.js +++ b/js/controllers/header.js @@ -24,10 +24,6 @@ angular.module('copay.header').controller('HeaderController', 'link': '#/backup' }]; - if (!$rootScope.wallet || !$rootScope.wallet.id) { - $location.path('signin'); - } - $scope.isActive = function(item) { if (item.link && item.link.replace('#','') == $location.path()) { return true; diff --git a/js/controllers/home.js b/js/controllers/home.js index f17f92ac5..f103b200e 100644 --- a/js/controllers/home.js +++ b/js/controllers/home.js @@ -28,9 +28,5 @@ angular.module('copay.home').controller('HomeController', $scope.selectedAddr = addr; }; - - if (!$rootScope.wallet || !$rootScope.wallet.id) { - $location.path('signin'); - } _updateBalance(); }); diff --git a/js/controllers/peer.js b/js/controllers/peer.js index ad0537b4b..e3c7f8b7b 100644 --- a/js/controllers/peer.js +++ b/js/controllers/peer.js @@ -7,11 +7,6 @@ angular.module('copay.peer').controller('PeerController', //Network.connect($rootScope.masterId); }; - if (!$rootScope.wallet || !$rootScope.wallet.id) { - $location.path('signin'); - } - else { - controllerUtils.handleTransactionByAddress($scope); - } + controllerUtils.handleTransactionByAddress($scope); }); diff --git a/js/controllers/send.js b/js/controllers/send.js index a808e3941..02cd74c37 100644 --- a/js/controllers/send.js +++ b/js/controllers/send.js @@ -4,12 +4,7 @@ angular.module('copay.send').controller('SendController', function($scope, $rootScope, $location, Socket, controllerUtils) { $scope.title = 'Send'; - if (!$rootScope.wallet || !$rootScope.wallet.id) { - $location.path('signin'); - } - else { - controllerUtils.handleTransactionByAddress($scope); - } + controllerUtils.handleTransactionByAddress($scope); $scope.sendTest = function() { var w = $rootScope.wallet; diff --git a/js/controllers/setup.js b/js/controllers/setup.js index 58d5f158d..b13f96071 100644 --- a/js/controllers/setup.js +++ b/js/controllers/setup.js @@ -19,6 +19,7 @@ angular.module('copay.setup').controller('SetupController', } } }; + updateRCSelect($scope.totalCopayers); $scope.$watch('totalCopayers', function(tc) { diff --git a/js/controllers/signin.js b/js/controllers/signin.js index 260fbb07b..2d4e43e3d 100644 --- a/js/controllers/signin.js +++ b/js/controllers/signin.js @@ -1,12 +1,12 @@ 'use strict'; - - angular.module('copay.signin').controller('SigninController', function($scope, $rootScope, $location, walletFactory, controllerUtils) { // var peerData = Storage.get($rootScope.walletId, 'peerData'); // $rootScope.peerId = peerData ? peerData.peerId : null; +// + $scope.loading = false; $scope.walletIds = walletFactory.getWalletIds(); diff --git a/js/controllers/transactions.js b/js/controllers/transactions.js index ccbed41a4..639890105 100644 --- a/js/controllers/transactions.js +++ b/js/controllers/transactions.js @@ -34,15 +34,9 @@ angular.module('copay.transactions').controller('TransactionsController', $scope.txs = ts; }; - - if (!$rootScope.wallet || !$rootScope.wallet.id) { - $location.path('signin'); - } - else { - _updateTxs(); - var socket = Socket($scope); - socket.on('connect', controllerUtils.handleTransactionByAddress($scope)); - } + _updateTxs(); + var socket = Socket($scope); + socket.on('connect', controllerUtils.handleTransactionByAddress($scope)); $scope.sign = function (ntxid) { var w = $rootScope.wallet; diff --git a/js/routes.js b/js/routes.js index 5c655b208..6bca7f6a1 100644 --- a/js/routes.js +++ b/js/routes.js @@ -45,4 +45,12 @@ angular $locationProvider .html5Mode(false); //.hashPrefix('!'); + }) + .run(function($rootScope, $location) { + $rootScope.$on('$routeChangeStart', function() { + if (!$rootScope.wallet || !$rootScope.wallet.id) { + console.log('############ no wallet'); + $location.path('signin'); + } + }); }); From 58a15502d1046b46cebfd5693295856d5d519c20 Mon Sep 17 00:00:00 2001 From: Mario Colque Date: Fri, 18 Apr 2014 15:36:38 -0300 Subject: [PATCH 2/4] clean up peerController --- index.html | 2 +- js/controllers/peer.js | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/index.html b/index.html index 90191c5c3..4a0457bc2 100644 --- a/index.html +++ b/index.html @@ -170,7 +170,7 @@