diff --git a/js/models/network/Async.js b/js/models/network/Async.js index 543372f7e..b6fb92cfb 100644 --- a/js/models/network/Async.js +++ b/js/models/network/Async.js @@ -218,10 +218,7 @@ Network.prototype._onMessage = function(enc) { } //ensure claimed public key is actually the public key of the peer //e.g., their public key should hash to be their peerId - if (enc.pubkey !== payload.copayerId) { - console.log(JSON.stringify(enc)); - console.log(JSON.stringify(enc.pubkey)); - console.log(JSON.stringify(payload.copayerId)); + if (sender !== payload.copayerId) { this._deletePeer(enc.pubkey, 'incorrect pubkey for peerId'); return; } diff --git a/test/test.network.Async.js b/test/test.network.Async.js index 069590168..ead9de985 100644 --- a/test/test.network.Async.js +++ b/test/test.network.Async.js @@ -122,18 +122,17 @@ describe('Network / Async', function() { var cid3 = '034d3dd2054234737c1cff9d973c9c7e0fb5902c8e56c9d57a699b7842cedfe984'; it('should not reject data sent from a peer with hijacked pubkey', function() { - var n = createN(pk2); + var n1 = createN(pk1); + var n2 = createN(pk2); + n2._deletePeer = sinon.spy(); var message = { type: 'hello', copayerId: cid1 }; - var enc = n.encode(cid2, message); - - n._deletePeer = sinon.spy(); - - n._onMessage(enc); - n._deletePeer.calledOnce.should.equal(false); + var enc = n1.encode(cid2, message); + n2._onMessage(enc); + n2._deletePeer.calledOnce.should.equal(false); }); it('should reject data sent from a peer with hijacked pubkey', function() {