From 11a7e96c0842425d912eefc6e8ad02eb74097fb6 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 28 Sep 2016 11:08:08 -0300 Subject: [PATCH 1/5] Fix flow for bitpay card --- public/views/bitpayCard.html | 13 +++++------ public/views/tab-home.html | 2 +- src/js/controllers/bitpayCard.js | 34 ++++++++++++++-------------- src/js/controllers/tab-home.js | 2 +- src/js/routes.js | 37 ++++++++++++++----------------- src/js/services/profileService.js | 2 +- 6 files changed, 42 insertions(+), 48 deletions(-) diff --git a/public/views/bitpayCard.html b/public/views/bitpayCard.html index 9e10307a7..5480dc787 100644 --- a/public/views/bitpayCard.html +++ b/public/views/bitpayCard.html @@ -1,19 +1,16 @@ - - - + + BitPay Card - - +
Sandbox version. Only for testing purpose diff --git a/public/views/tab-home.html b/public/views/tab-home.html index e17426e5b..2a92cc6de 100644 --- a/public/views/tab-home.html +++ b/public/views/tab-home.html @@ -76,7 +76,7 @@

- diff --git a/src/js/controllers/bitpayCard.js b/src/js/controllers/bitpayCard.js index fe199d85d..752c91fa7 100644 --- a/src/js/controllers/bitpayCard.js +++ b/src/js/controllers/bitpayCard.js @@ -98,23 +98,6 @@ angular.module('copayApp.controllers').controller('bitpayCardController', functi }); }; - this.init = function() { - $scope.dateRange = 'last30Days'; - - $scope.network = bitpayCardService.getEnvironment(); - $scope.wallets = profileService.getWallets({ - network: $scope.network, - onlyComplete: true - }); - - self.update(); - - wallet = $scope.wallets[0]; - - if (wallet && wallet.credentials.n > 1) - self.isMultisigWallet = true; - }; - this.sendFunds = function() { if (lodash.isEmpty(wallet)) return; @@ -258,5 +241,22 @@ angular.module('copayApp.controllers').controller('bitpayCardController', functi return tx.description; }; + $scope.$on("$ionicView.beforeEnter", function(event, data){ + $scope.dateRange = 'last30Days'; + + $scope.network = bitpayCardService.getEnvironment(); + $scope.wallets = profileService.getWallets({ + network: $scope.network, + onlyComplete: true + }); + + self.update(); + + wallet = $scope.wallets[0]; + + if (wallet && wallet.credentials.n > 1) + self.isMultisigWallet = true; + }); + }); diff --git a/src/js/controllers/tab-home.js b/src/js/controllers/tab-home.js index 41444b0d9..ae0f7cb3c 100644 --- a/src/js/controllers/tab-home.js +++ b/src/js/controllers/tab-home.js @@ -76,7 +76,7 @@ angular.module('copayApp.controllers').controller('tabHomeController', }); } - $state.go('tabs.details', { + $state.go('tabs.wallet', { walletId: wallet.credentials.walletId }); }; diff --git a/src/js/routes.js b/src/js/routes.js index ba828213c..e81fa76b2 100644 --- a/src/js/routes.js +++ b/src/js/routes.js @@ -150,10 +150,10 @@ angular.module('copayApp').config(function(historicLogProvider, $provide, $logPr * */ - .state('tabs.details', { - url: '/details/{walletId}/{fromOnboarding}', + .state('tabs.wallet', { + url: '/wallet/{walletId}/{fromOnboarding}', views: { - 'tab-home': { + 'tab-home@tabs': { controller: 'walletDetailsController', templateUrl: 'views/walletDetails.html' } @@ -166,7 +166,7 @@ angular.module('copayApp').config(function(historicLogProvider, $provide, $logPr .state('tabs.activity', { url: '/activity', views: { - 'tab-home': { + 'tab-home@tabs': { controller: 'activityController', templateUrl: 'views/activity.html', } @@ -175,7 +175,7 @@ angular.module('copayApp').config(function(historicLogProvider, $provide, $logPr .state('tabs.proposals', { url: '/proposals', views: { - 'tab-home': { + 'tab-home@tabs': { controller: 'proposalsController', templateUrl: 'views/proposals.html', } @@ -836,29 +836,26 @@ angular.module('copayApp').config(function(historicLogProvider, $provide, $logPr } }) - /* - * - * BitPay Card - * - */ + /* + * + * BitPay Card + * + */ - .state('bitpayCard', { - url: '/bitpayCard', - abstract: true, - template: '' - }) - .state('bitpayCard.main', { - url: '/main', + .state('tabs.bitpayCard', { + url: '/bitpay-card', views: { - 'bitpayCard': { + 'tab-home@tabs': { + controller: 'bitpayCardController', + controllerAs: 'bitpayCard', templateUrl: 'views/bitpayCard.html' } } }) - .state('bitpayCard.preferences', { + .state('tabs.bitpayCard.preferences', { url: '/preferences', views: { - 'bitpayCard': { + 'tab-home@tabs': { templateUrl: 'views/preferencesBitpayCard.html' } } diff --git a/src/js/services/profileService.js b/src/js/services/profileService.js index 0dea73fb0..ace8bbb11 100644 --- a/src/js/services/profileService.js +++ b/src/js/services/profileService.js @@ -833,7 +833,7 @@ angular.module('copayApp.services') x.action = function() { // TODO? - // $state.go('tabs.details', { + // $state.go('tabs.wallet', { // walletId: x.walletId, // txpId: x.txpId, // txid: x.txid, From 1ac78c21a5101575e06d0464c4140f418c14b3e6 Mon Sep 17 00:00:00 2001 From: Gustavo Maximiliano Cortez Date: Wed, 28 Sep 2016 17:51:45 -0300 Subject: [PATCH 2/5] New send flow for bitpay card. Fix paypro txStatus. Minor bug fixes --- public/views/amount.html | 11 ++-- public/views/bitpayCard.html | 2 +- public/views/confirm.html | 21 +++++--- public/views/modals/paypro.html | 77 +++++++++++++-------------- public/views/modals/tx-status.html | 15 +++--- src/js/controllers/amount.js | 69 ++++++++++++++++++------ src/js/controllers/confirm.js | 23 ++++---- src/js/controllers/modals/txStatus.js | 15 ++++-- src/js/controllers/tabsController.js | 2 + src/js/routes.js | 18 +++++++ src/sass/common.scss | 13 +++++ src/sass/views/amount.scss | 3 ++ src/sass/views/confirm.scss | 3 ++ 13 files changed, 182 insertions(+), 90 deletions(-) diff --git a/public/views/amount.html b/public/views/amount.html index 207ca5c11..07460c375 100644 --- a/public/views/amount.html +++ b/public/views/amount.html @@ -12,10 +12,15 @@
Recipient
-
+
- - {{toName || toAddress}} + + + +
+
+
+ {{toName || toAddress}}
diff --git a/public/views/bitpayCard.html b/public/views/bitpayCard.html index 5480dc787..2b15d9aa6 100644 --- a/public/views/bitpayCard.html +++ b/public/views/bitpayCard.html @@ -101,7 +101,7 @@
diff --git a/public/views/confirm.html b/public/views/confirm.html index 721ef18c8..aa039f4b4 100644 --- a/public/views/confirm.html +++ b/public/views/confirm.html @@ -26,14 +26,21 @@
- - To: {{toAddress}} -

{{toName}}

+
+ + +
+
+
+
+ To: {{toAddress}} +

{{toName}}

-
- - - {{_paypro.domain}} +
+ + + {{_paypro.domain}} +
diff --git a/public/views/modals/paypro.html b/public/views/modals/paypro.html index 20eecb676..e3fc96488 100644 --- a/public/views/modals/paypro.html +++ b/public/views/modals/paypro.html @@ -1,60 +1,57 @@ - -
- - Close - + + +
+ Payment request
-

Payment request

- - +
+ {{'Memo'|translate}} + {{_paypro.memo}} +
+
+ {{'Expires'|translate}} + {{_paypro.expires * 1000 | amTimeAgo }} +
-
diff --git a/public/views/modals/tx-status.html b/public/views/modals/tx-status.html index 6d808fafb..426c762af 100644 --- a/public/views/modals/tx-status.html +++ b/public/views/modals/tx-status.html @@ -4,13 +4,14 @@
{{tx.amountStr}}
-
- Sent +
+ Sent + Funds sent
-
+ -
+

Would you like to add this address to your address book?

@@ -40,7 +41,7 @@