From 3f6a58f967e0ac40aa3785772e9a866aada52e2e Mon Sep 17 00:00:00 2001 From: Laura Cressman Date: Wed, 20 Sep 2017 20:37:26 -0400 Subject: [PATCH] channeldb: use binary.Read/Write in invoices.go Use binary.Read/Write in when reading and writing booleans in functions to serialize and deserialize invoices. --- channeldb/invoices.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/channeldb/invoices.go b/channeldb/invoices.go index 98cc1943..99a9caec 100644 --- a/channeldb/invoices.go +++ b/channeldb/invoices.go @@ -3,6 +3,7 @@ package channeldb import ( "bytes" "crypto/sha256" + "encoding/binary" "fmt" "io" "time" @@ -343,11 +344,7 @@ func serializeInvoice(w io.Writer, i *Invoice) error { return err } - var settleByte [1]byte - if i.Terms.Settled { - settleByte[0] = 1 - } - if _, err := w.Write(settleByte[:]); err != nil { + if err := binary.Write(w, byteOrder, i.Terms.Settled); err != nil { return err } @@ -401,13 +398,9 @@ func deserializeInvoice(r io.Reader) (*Invoice, error) { } invoice.Terms.Value = lnwire.MilliSatoshi(byteOrder.Uint64(scratch[:])) - var settleByte [1]byte - if _, err := io.ReadFull(r, settleByte[:]); err != nil { + if err := binary.Read(r, byteOrder, &invoice.Terms.Settled); err != nil { return nil, err } - if settleByte[0] == 1 { - invoice.Terms.Settled = true - } return invoice, nil }