From 1d12be67e913cdeda44f5e5f8a63453a5c222d9d Mon Sep 17 00:00:00 2001 From: James Hawkins Date: Tue, 14 Jul 2015 09:18:19 -0500 Subject: [PATCH] Cleaning up error checking First checking for a valid order, then checking for a valid order id --- .../community/Bitpay/Core/controllers/IpnController.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/code/community/Bitpay/Core/controllers/IpnController.php b/app/code/community/Bitpay/Core/controllers/IpnController.php index a7ae8a7..2e457e6 100644 --- a/app/code/community/Bitpay/Core/controllers/IpnController.php +++ b/app/code/community/Bitpay/Core/controllers/IpnController.php @@ -77,8 +77,13 @@ class Bitpay_Core_IpnController extends Mage_Core_Controller_Front_Action $order = \Mage::getModel('sales/order')->load($ipn->posData->quoteId, 'quote_id'); } + if (false === isset($order) || true === empty($order)) { + \Mage::helper('bitpay')->debugData('[ERROR] In Bitpay_Core_IpnController::indexAction(), Invalid Bitpay IPN received.'); + \Mage::throwException('Invalid Bitpay IPN received.'); + } + $orderId = $order->getId(); - if (false === isset($order) || (true === empty($orderId))) { + if (false === isset($orderId) || true === empty($orderId)) { \Mage::helper('bitpay')->debugData('[ERROR] In Bitpay_Core_IpnController::indexAction(), Invalid Bitpay IPN received.'); \Mage::throwException('Invalid Bitpay IPN received.'); }