From a2e7e2845eb46931bf5505d3ce2d6f3ea5cc996f Mon Sep 17 00:00:00 2001
From: Joshua Estes <josh@bitpay.com>
Date: Tue, 8 Jul 2014 12:37:03 -0400
Subject: [PATCH] A little more refactoring making the code easier to manage.

---
 .../Bitpay/Bitcoins/Model/PaymentMethod.php   | 83 +++++++++++++------
 1 file changed, 58 insertions(+), 25 deletions(-)

diff --git a/app/code/community/Bitpay/Bitcoins/Model/PaymentMethod.php b/app/code/community/Bitpay/Bitcoins/Model/PaymentMethod.php
index 8c26583..3249371 100644
--- a/app/code/community/Bitpay/Bitcoins/Model/PaymentMethod.php
+++ b/app/code/community/Bitpay/Bitcoins/Model/PaymentMethod.php
@@ -120,18 +120,14 @@ class Bitpay_Bitcoins_Model_PaymentMethod extends Mage_Payment_Model_Method_Abst
      */
     public function canUseCheckout()
     {
-        $secret = Mage::getStoreConfig('payment/Bitcoins/api_key');
-
-        if (!$secret or !strlen($secret))
+        if ($this->isApiKeyConfigured())
         {
             Mage::log('Bitpay/Bitcoins: API key not entered', Zend_Log::ERR, 'bitpay.log');
 
             return false;
         }
 
-        $speed = Mage::getStoreConfig('payment/Bitcoins/speed');
-
-        if (!$speed or !strlen($speed))
+        if ($this->isTransactionSpeedConfigured())
         {
             Mage::log('Bitpay/Bitcoins: Transaction Speed invalid', Zend_Log::ERR, 'bitpay.log');
 
@@ -141,6 +137,30 @@ class Bitpay_Bitcoins_Model_PaymentMethod extends Mage_Payment_Model_Method_Abst
         return $this->_canUseCheckout;
     }
 
+    /**
+     * Returns true if the merchant has set their api key
+     *
+     * @return boolean
+     */
+    public function isApiKeyConfigured()
+    {
+        $key = Mage::getStoreConfig('payment/Bitcoins/api_key');
+
+        return !empty($key);
+    }
+
+    /**
+     * Returns true if Transaction Speed has been configured
+     *
+     * @return boolean
+     */
+    public function isTransactionSpeedConfigured()
+    {
+        $speed = Mage::getStoreConfig('payment/Bitcoins/speed');
+
+        return !empty($speed);
+    }
+
     /**
      * Authorize payment method
      *
@@ -188,6 +208,37 @@ class Bitpay_Bitcoins_Model_PaymentMethod extends Mage_Payment_Model_Method_Abst
         return $this;
     }
 
+    /**
+     * @param Varien_Object $order
+     */
+    public function invoiceOrder($order)
+    {
+        try
+        {
+            if (!$order->canInvoice())
+            {
+                Mage::throwException(Mage::helper('core')->__('Cannot create an invoice.'));
+            }
+
+            $invoice = $order->prepareInvoice()
+                ->setTransactionId(1)
+                ->addComment('Invoiced automatically by Bitpay/Bitcoins/controllers/IndexController.php')
+                ->register()
+                ->pay();
+
+            $transactionSave = Mage::getModel('core/resource_transaction')
+                ->addObject($invoice)
+                ->addObject($invoice->getOrder());
+
+            $transactionSave->save();
+        }
+        catch (Exception $e)
+        {
+            Mage::log($e->getMessage(), Zend_Log::EMERG, 'bitpay.log');
+            Mage::logException($e);
+        }
+    }
+
     /**
      * @param $order
      */
@@ -199,25 +250,7 @@ class Bitpay_Bitcoins_Model_PaymentMethod extends Mage_Payment_Model_Method_Abst
         {
             if (!count($order->getInvoiceCollection()))
             {
-                try
-                {
-                    $invoice = $order->prepareInvoice()
-                        ->setTransactionId(1)
-                        ->addComment('Invoiced automatically by Bitpay/Bitcoins/controllers/IndexController.php')
-                        ->register()
-                        ->pay();
-
-                    $transactionSave = Mage::getModel('core/resource_transaction')
-                        ->addObject($invoice)
-                        ->addObject($invoice->getOrder());
-
-                    $transactionSave->save();
-                }
-                catch (Exception $e)
-                {
-                    Mage::log($e->getMessage(), Zend_Log::EMERG, 'bitpay.log');
-                    Mage::logException($e);
-                }
+                $this->invoiceOrder($order);
             }
         }
         else