fome-fw/firmware/controllers/trigger/trigger_central.cpp

799 lines
28 KiB
C++
Raw Normal View History

2015-07-10 06:01:56 -07:00
/*
* @file trigger_central.cpp
2017-12-12 14:26:23 -08:00
* Here we have a bunch of higher-level methods which are not directly related to actual signal decoding
2015-07-10 06:01:56 -07:00
*
* @date Feb 23, 2014
2020-01-07 21:02:40 -08:00
* @author Andrey Belomutskiy, (c) 2012-2020
2015-07-10 06:01:56 -07:00
*/
2018-09-16 19:26:57 -07:00
#include "global.h"
#include "os_access.h"
2015-07-10 06:01:56 -07:00
#include "trigger_central.h"
#include "trigger_decoder.h"
#include "main_trigger_callback.h"
#include "engine_configuration.h"
#include "listener_array.h"
#include "pwm_generator_logic.h"
#include "tooth_logger.h"
2015-07-10 06:01:56 -07:00
#include "settings.h"
2016-08-20 20:02:09 -07:00
#include "engine_math.h"
#include "local_version_holder.h"
#include "trigger_simulator.h"
2015-07-10 06:01:56 -07:00
#include "rpm_calculator.h"
#include "tooth_logger.h"
2019-10-11 17:43:21 -07:00
#include "perf_trace.h"
2019-07-06 17:15:49 -07:00
#if EFI_PROD_CODE
#include "pin_repository.h"
#endif /* EFI_PROD_CODE */
#if EFI_TUNER_STUDIO
#include "tunerstudio.h"
#endif /* EFI_TUNER_STUDIO */
#if EFI_ENGINE_SNIFFER
#include "engine_sniffer.h"
WaveChart waveChart;
#endif /* EFI_ENGINE_SNIFFER */
trigger_central_s::trigger_central_s() : hwEventCounters() {
2020-05-15 13:35:18 -07:00
static_assert(TRIGGER_TYPE_60_2 == TT_TOOTHED_WHEEL_60_2, "One day we will have one source of this magic constant");
static_assert(TRIGGER_TYPE_36_1 == TT_TOOTHED_WHEEL_36_1, "One day we will have one source of this magic constant");
}
TriggerCentral::TriggerCentral() : trigger_central_s() {
2019-01-31 14:55:23 -08:00
clearCallbacks(&triggerListeneres);
triggerState.resetTriggerState();
2020-01-27 21:16:33 -08:00
noiseFilter.resetAccumSignalData();
2019-01-31 14:55:23 -08:00
}
2020-01-27 21:16:33 -08:00
void TriggerNoiseFilter::resetAccumSignalData() {
2019-01-31 14:55:23 -08:00
memset(lastSignalTimes, 0xff, sizeof(lastSignalTimes)); // = -1
memset(accumSignalPeriods, 0, sizeof(accumSignalPeriods));
memset(accumSignalPrevPeriods, 0, sizeof(accumSignalPrevPeriods));
}
int TriggerCentral::getHwEventCounter(int index) const {
2019-01-31 14:55:23 -08:00
return hwEventCounters[index];
}
2019-04-12 19:07:03 -07:00
#if EFI_SHAFT_POSITION_INPUT
2019-01-31 14:55:23 -08:00
2015-09-13 14:02:44 -07:00
EXTERN_ENGINE;
2015-07-10 06:01:56 -07:00
static Logging *logger;
void TriggerCentral::addEventListener(ShaftPositionListener listener, const char *name, Engine *engine) {
print("registerCkpListener: %s\r\n", name);
2018-12-27 06:40:40 -08:00
triggerListeneres.registerCallback((VoidInt)(void*)listener, engine);
2015-07-10 06:01:56 -07:00
}
angle_t TriggerCentral::getVVTPosition() {
return vvtPosition;
}
2015-07-10 06:01:56 -07:00
/**
* @brief Adds a trigger event listener
*
* Trigger event listener would be invoked on each trigger event. For example, for a 60/2 wheel
2016-02-27 20:03:34 -08:00
* that would be 116 events: 58 SHAFT_PRIMARY_RISING and 58 SHAFT_PRIMARY_FALLING events.
2015-07-10 06:01:56 -07:00
*/
void addTriggerEventListener(ShaftPositionListener listener, const char *name, Engine *engine) {
2015-09-13 14:02:44 -07:00
engine->triggerCentral.addEventListener(listener, name, engine);
2015-07-10 06:01:56 -07:00
}
2020-04-05 08:43:45 -07:00
#define miataNbIndex (0)
2020-03-09 13:59:19 -07:00
void hwHandleVvtCamSignal(trigger_value_e front, efitick_t nowNt DECLARE_ENGINE_PARAMETER_SUFFIX) {
2019-09-02 18:02:08 -07:00
TriggerCentral *tc = &engine->triggerCentral;
if (front == TV_RISE) {
tc->vvtEventRiseCounter++;
} else {
tc->vvtEventFallCounter++;
}
if (!CONFIG(displayLogicLevelsInEngineSniffer)) {
addEngineSnifferEvent(PROTOCOL_VVT_NAME, front == TV_RISE ? PROTOCOL_ES_UP : PROTOCOL_ES_DOWN);
2020-05-15 13:35:18 -07:00
#if EFI_TOOTH_LOGGER
if (front == TV_RISE) {
LogTriggerTooth(SHAFT_SECONDARY_RISING, nowNt PASS_ENGINE_PARAMETER_SUFFIX);
} else {
LogTriggerTooth(SHAFT_SECONDARY_FALLING, nowNt PASS_ENGINE_PARAMETER_SUFFIX);
}
#endif /* EFI_TOOTH_LOGGER */
}
2019-09-02 18:02:08 -07:00
2016-08-23 20:03:01 -07:00
if (CONFIG(vvtCamSensorUseRise) ^ (front != TV_FALL)) {
2016-08-23 20:03:01 -07:00
return;
}
if (CONFIG(displayLogicLevelsInEngineSniffer)) {
if (CONFIG(vvtCamSensorUseRise)) {
// todo: unify TS composite logger code with console Engine Sniffer
// todo: better API to reduce copy/paste?
2020-04-15 18:09:05 -07:00
#if EFI_TOOTH_LOGGER
2020-04-15 16:50:07 -07:00
LogTriggerTooth(SHAFT_SECONDARY_RISING, nowNt PASS_ENGINE_PARAMETER_SUFFIX);
LogTriggerTooth(SHAFT_SECONDARY_FALLING, nowNt PASS_ENGINE_PARAMETER_SUFFIX);
2020-04-15 18:09:05 -07:00
#endif /* EFI_TOOTH_LOGGER */
addEngineSnifferEvent(PROTOCOL_VVT_NAME, PROTOCOL_ES_UP);
addEngineSnifferEvent(PROTOCOL_VVT_NAME, PROTOCOL_ES_DOWN);
} else {
2020-04-15 18:09:05 -07:00
#if EFI_TOOTH_LOGGER
2020-04-15 16:50:07 -07:00
LogTriggerTooth(SHAFT_SECONDARY_FALLING, nowNt PASS_ENGINE_PARAMETER_SUFFIX);
LogTriggerTooth(SHAFT_SECONDARY_RISING, nowNt PASS_ENGINE_PARAMETER_SUFFIX);
2020-04-15 18:09:05 -07:00
#endif /* EFI_TOOTH_LOGGER */
addEngineSnifferEvent(PROTOCOL_VVT_NAME, PROTOCOL_ES_DOWN);
addEngineSnifferEvent(PROTOCOL_VVT_NAME, PROTOCOL_ES_UP);
}
}
2017-08-11 11:02:15 -07:00
floatus_t oneDegreeUs = engine->rpmCalculator.oneDegreeUs;
if (cisnan(oneDegreeUs)) {
// todo: this code branch is slowing NB2 cranking since we require RPM sync for VVT sync!
// todo: smarter code
//
2017-08-11 11:02:15 -07:00
// we are here if we are getting VVT position signals while engine is not running
// for example if crank position sensor is broken :)
return;
}
2020-08-26 21:06:10 -07:00
ENGINE(triggerCentral).vvtState.decodeTriggerEvent(
&ENGINE(triggerCentral).vvtShape,
nullptr,
nullptr,
&engine->vvtTriggerConfiguration,
front == TV_RISE ? SHAFT_PRIMARY_RISING : SHAFT_PRIMARY_FALLING, nowNt);
2019-09-02 11:47:05 -07:00
tc->vvtCamCounter++;
2016-08-20 19:02:12 -07:00
2020-05-10 08:54:21 -07:00
efitick_t offsetNt = nowNt - tc->timeAtVirtualZeroNt;
angle_t currentPosition = NT2US(offsetNt) / oneDegreeUs;
// convert engine cycle angle into trigger cycle angle
currentPosition -= tdcPosition();
// https://github.com/rusefi/rusefi/issues/1713 currentPosition could be negative that's expected
2020-05-10 08:54:21 -07:00
2020-05-10 15:03:11 -07:00
tc->currentVVTEventPosition = currentPosition;
if (engineConfiguration->debugMode == DBG_VVT) {
#if EFI_TUNER_STUDIO
tsOutputChannels.debugFloatField1 = currentPosition;
#endif /* EFI_TUNER_STUDIO */
}
2020-05-10 08:54:21 -07:00
2020-05-10 08:54:04 -07:00
switch(engineConfiguration->vvtMode) {
2020-05-10 15:03:11 -07:00
case VVT_2JZ:
2020-05-15 13:35:18 -07:00
// we do not know if we are in sync or out of sync, so we have to be looking for both possibilities
if ((currentPosition < engineConfiguration->fsio_setting[14] || currentPosition > engineConfiguration->fsio_setting[15]) &&
(currentPosition < engineConfiguration->fsio_setting[14] + 360 || currentPosition > engineConfiguration->fsio_setting[15] + 360)) {
2020-05-10 15:03:11 -07:00
// outside of the expected range
return;
}
2020-05-10 15:10:50 -07:00
break;
2020-05-10 08:54:04 -07:00
case MIATA_NB2:
2020-08-26 22:01:03 -07:00
case VVT_BOSCH_QUICK_START:
2020-05-10 08:54:04 -07:00
{
2020-08-26 22:01:03 -07:00
if (engine->triggerCentral.vvtState.currentCycle.current_index != 0) {
2020-05-10 08:54:21 -07:00
// this is not NB2 sync tooth - exiting
2016-11-11 20:02:49 -08:00
return;
}
2018-08-14 11:19:58 -07:00
if (engineConfiguration->debugMode == DBG_VVT) {
2019-04-12 19:07:03 -07:00
#if EFI_TUNER_STUDIO
2018-08-14 11:19:58 -07:00
tsOutputChannels.debugIntField1++;
#endif /* EFI_TUNER_STUDIO */
2018-08-14 11:19:58 -07:00
}
2016-11-11 20:02:49 -08:00
}
2020-05-10 12:22:50 -07:00
default:
// else, do nothing
break;
2020-05-10 08:54:04 -07:00
}
2016-11-11 20:02:49 -08:00
tc->vvtSyncTimeNt = nowNt;
2016-11-11 20:02:49 -08:00
2020-05-15 18:33:25 -07:00
// we do NOT clamp VVT position into the [0, engineCycle) range - we expect vvtOffset to be configured so that
// it's not necessary
tc->vvtPosition = engineConfiguration->vvtOffset - currentPosition;
if (tc->vvtPosition < 0 || tc->vvtPosition > ENGINE(engineCycle)) {
warning(CUSTOM_ERR_VVT_OUT_OF_RANGE, "Please adjust vvtOffset since position %f", tc->vvtPosition);
}
2016-08-23 20:03:01 -07:00
2020-05-09 21:42:33 -07:00
switch (engineConfiguration->vvtMode) {
case VVT_FIRST_HALF:
{
2016-08-23 20:03:01 -07:00
bool isEven = tc->triggerState.isEvenRevolution();
if (!isEven) {
/**
* we are here if we've detected the cam sensor within the wrong crank phase
* let's increase the trigger event counter, that would adjust the state of
* virtual crank-based trigger
*/
2018-02-05 14:16:34 -08:00
tc->triggerState.incrementTotalEventCounter();
2016-09-17 16:02:34 -07:00
if (engineConfiguration->debugMode == DBG_VVT) {
2019-04-12 19:07:03 -07:00
#if EFI_TUNER_STUDIO
2016-08-23 20:03:01 -07:00
tsOutputChannels.debugIntField1++;
#endif /* EFI_TUNER_STUDIO */
2016-08-23 20:03:01 -07:00
}
}
2020-05-09 21:42:33 -07:00
}
break;
case VVT_SECOND_HALF:
{
2016-08-23 20:03:01 -07:00
bool isEven = tc->triggerState.isEvenRevolution();
if (isEven) {
// see above comment
2018-02-05 14:16:34 -08:00
tc->triggerState.incrementTotalEventCounter();
2016-09-17 16:02:34 -07:00
if (engineConfiguration->debugMode == DBG_VVT) {
2019-04-12 19:07:03 -07:00
#if EFI_TUNER_STUDIO
2016-08-23 20:03:01 -07:00
tsOutputChannels.debugIntField1++;
#endif /* EFI_TUNER_STUDIO */
2016-08-23 20:03:01 -07:00
}
}
2020-05-09 21:42:33 -07:00
}
break;
case MIATA_NB2:
2016-11-14 20:01:47 -08:00
/**
* NB2 is a symmetrical crank, there are four phases total
*/
2020-04-05 08:43:45 -07:00
while (tc->triggerState.getTotalRevolutionCounter() % 4 != miataNbIndex) {
2018-02-05 14:16:34 -08:00
tc->triggerState.incrementTotalEventCounter();
2016-11-14 20:01:47 -08:00
}
2020-05-14 20:13:32 -07:00
break;
default:
case VVT_INACTIVE:
// do nothing
break;
2016-08-20 19:02:12 -07:00
}
}
#if EFI_PROD_CODE || EFI_SIMULATOR
int triggerReentraint = 0;
int maxTriggerReentraint = 0;
uint32_t triggerDuration;
uint32_t triggerMaxDuration = 0;
void hwHandleShaftSignal(trigger_event_e signal, efitick_t timestamp) {
ScopePerf perf(PE::HandleShaftSignal);
2019-10-11 17:43:21 -07:00
2019-07-07 12:22:46 -07:00
#if EFI_TOOTH_LOGGER
// Log to the Tunerstudio tooth logger
// We want to do this before anything else as we
2019-07-07 12:22:46 -07:00
// actually want to capture any noise/jitter that may be occurring
bool logLogicState = CONFIG(displayLogicLevelsInEngineSniffer && engineConfiguration->useOnlyRisingEdgeForTrigger);
if (!logLogicState) {
// we log physical state even if displayLogicLevelsInEngineSniffer if both fronts are used by decoder
LogTriggerTooth(signal, timestamp PASS_ENGINE_PARAMETER_SUFFIX);
}
2019-07-07 12:22:46 -07:00
#endif /* EFI_TOOTH_LOGGER */
// for effective noise filtering, we need both signal edges,
// so we pass them to handleShaftSignal() and defer this test
if (!CONFIG(useNoiselessTriggerDecoder)) {
2020-08-23 23:23:13 -07:00
const TriggerConfiguration * triggerConfiguration = &engine->primaryTriggerConfiguration;
if (!isUsefulSignal(signal, triggerConfiguration)) {
/**
* no need to process VR falls further
*/
return;
}
}
2020-04-17 11:02:10 -07:00
#if EFI_TOOTH_LOGGER
if (logLogicState) {
LogTriggerTooth(signal, timestamp PASS_ENGINE_PARAMETER_SUFFIX);
if (signal == SHAFT_PRIMARY_RISING) {
LogTriggerTooth(SHAFT_PRIMARY_FALLING, timestamp PASS_ENGINE_PARAMETER_SUFFIX);
} else {
LogTriggerTooth(SHAFT_SECONDARY_FALLING, timestamp PASS_ENGINE_PARAMETER_SUFFIX);
}
}
2020-04-17 11:02:10 -07:00
#endif /* EFI_TOOTH_LOGGER */
2019-05-07 16:32:08 -07:00
uint32_t triggerHandlerEntryTime = getTimeNowLowerNt();
2015-07-10 06:01:56 -07:00
if (triggerReentraint > maxTriggerReentraint)
maxTriggerReentraint = triggerReentraint;
triggerReentraint++;
2019-02-23 09:33:49 -08:00
efiAssertVoid(CUSTOM_ERR_6636, getCurrentRemainingStack() > 128, "lowstck#8");
engine->triggerCentral.handleShaftSignal(signal, timestamp PASS_ENGINE_PARAMETER_SUFFIX);
2015-07-10 06:01:56 -07:00
triggerReentraint--;
2019-05-07 16:32:08 -07:00
triggerDuration = getTimeNowLowerNt() - triggerHandlerEntryTime;
2015-07-10 06:01:56 -07:00
if (triggerDuration > triggerMaxDuration)
triggerMaxDuration = triggerDuration;
}
#endif /* EFI_PROD_CODE */
void TriggerCentral::resetCounters() {
memset(hwEventCounters, 0, sizeof(hwEventCounters));
}
static char shaft_signal_msg_index[15];
static const bool isUpEvent[6] = { false, true, false, true, false, true };
static const char *eventId[6] = { PROTOCOL_CRANK1, PROTOCOL_CRANK1, PROTOCOL_CRANK2, PROTOCOL_CRANK2, PROTOCOL_CRANK3, PROTOCOL_CRANK3 };
2015-07-10 06:01:56 -07:00
2017-05-15 20:28:49 -07:00
static ALWAYS_INLINE void reportEventToWaveChart(trigger_event_e ckpSignalType, int index DECLARE_ENGINE_PARAMETER_SUFFIX) {
2017-05-25 20:23:22 -07:00
if (!ENGINE(isEngineChartEnabled)) { // this is here just as a shortcut so that we avoid engine sniffer as soon as possible
return; // engineSnifferRpmThreshold is accounted for inside ENGINE(isEngineChartEnabled)
}
2015-07-10 06:01:56 -07:00
itoa10(&shaft_signal_msg_index[2], index);
2016-01-11 14:01:33 -08:00
bool isUp = isUpEvent[(int) ckpSignalType];
2015-07-10 06:01:56 -07:00
shaft_signal_msg_index[0] = isUp ? 'u' : 'd';
2018-09-10 19:29:43 -07:00
addEngineSnifferEvent(eventId[(int )ckpSignalType], (char* ) shaft_signal_msg_index);
2016-02-27 20:03:34 -08:00
if (engineConfiguration->useOnlyRisingEdgeForTrigger) {
2015-07-10 06:01:56 -07:00
// let's add the opposite event right away
shaft_signal_msg_index[0] = isUp ? 'd' : 'u';
2018-09-10 19:29:43 -07:00
addEngineSnifferEvent(eventId[(int )ckpSignalType], (char* ) shaft_signal_msg_index);
2015-07-10 06:01:56 -07:00
}
}
/**
* This is used to filter noise spikes (interference) in trigger signal. See
* The basic idea is to use not just edges, but the average amount of time the signal stays in '0' or '1'.
* So we update 'accumulated periods' to track where the signal is.
* And then compare between the current period and previous, with some tolerance (allowing for the wheel speed change).
* @return true if the signal is passed through.
*/
2020-01-27 21:16:33 -08:00
bool TriggerNoiseFilter::noiseFilter(efitick_t nowNt,
TriggerState * triggerState,
trigger_event_e signal DECLARE_ENGINE_PARAMETER_SUFFIX) {
// todo: find a better place for these defs
static const trigger_event_e opposite[6] = { SHAFT_PRIMARY_RISING, SHAFT_PRIMARY_FALLING, SHAFT_SECONDARY_RISING, SHAFT_SECONDARY_FALLING,
SHAFT_3RD_RISING, SHAFT_3RD_FALLING };
static const trigger_wheel_e triggerIdx[6] = { T_PRIMARY, T_PRIMARY, T_SECONDARY, T_SECONDARY, T_CHANNEL_3, T_CHANNEL_3 };
// we process all trigger channels independently
trigger_wheel_e ti = triggerIdx[signal];
// falling is opposite to rising, and vise versa
trigger_event_e os = opposite[signal];
// todo: currently only primary channel is filtered, because there are some weird trigger types on other channels
if (ti != T_PRIMARY)
return true;
// update period accumulator: for rising signal, we update '0' accumulator, and for falling - '1'
if (lastSignalTimes[signal] != -1)
accumSignalPeriods[signal] += nowNt - lastSignalTimes[signal];
// save current time for this trigger channel
lastSignalTimes[signal] = nowNt;
// now we want to compare current accumulated period to the stored one
efitick_t currentPeriod = accumSignalPeriods[signal];
// the trick is to compare between different
efitick_t allowedPeriod = accumSignalPrevPeriods[os];
// but first check if we're expecting a gap
2020-01-27 21:16:33 -08:00
bool isGapExpected = TRIGGER_WAVEFORM(isSynchronizationNeeded) && triggerState->shaft_is_synchronized &&
(triggerState->currentCycle.eventCount[ti] + 1) == TRIGGER_WAVEFORM(expectedEventCount[ti]);
if (isGapExpected) {
// usually we need to extend the period for gaps, based on the trigger info
allowedPeriod *= TRIGGER_WAVEFORM(syncRatioAvg);
}
// also we need some margin for rapidly changing trigger-wheel speed,
// that's why we expect the period to be no less than 2/3 of the previous period (this is just an empirical 'magic' coef.)
efitick_t minAllowedPeriod = 2 * allowedPeriod / 3;
// but no longer than 5/4 of the previous 'normal' period
efitick_t maxAllowedPeriod = 5 * allowedPeriod / 4;
// above all, check if the signal comes not too early
if (currentPeriod >= minAllowedPeriod) {
// now we store this period as a reference for the next time,
// BUT we store only 'normal' periods, and ignore too long periods (i.e. gaps)
if (!isGapExpected && (maxAllowedPeriod == 0 || currentPeriod <= maxAllowedPeriod)) {
accumSignalPrevPeriods[signal] = currentPeriod;
}
// reset accumulator
accumSignalPeriods[signal] = 0;
return true;
}
// all premature or extra-long events are ignored - treated as interference
return false;
}
/**
* This method is NOT invoked for VR falls.
*/
void TriggerCentral::handleShaftSignal(trigger_event_e signal, efitick_t timestamp DECLARE_ENGINE_PARAMETER_SUFFIX) {
2018-09-10 19:10:55 -07:00
efiAssertVoid(CUSTOM_CONF_NULL, engine!=NULL, "configuration");
2015-07-10 06:01:56 -07:00
2017-03-01 19:37:10 -08:00
if (triggerShape.shapeDefinitionError) {
2017-02-23 17:24:06 -08:00
// trigger is broken, we cannot do anything here
warning(CUSTOM_ERR_UNEXPECTED_SHAFT_EVENT, "Shaft event while trigger is mis-configured");
// magic value to indicate a problem
hwEventCounters[0] = 155;
2017-02-23 17:24:06 -08:00
return;
}
// This code gathers some statistics on signals and compares accumulated periods to filter interference
if (CONFIG(useNoiselessTriggerDecoder)) {
2020-01-27 21:16:33 -08:00
if (!noiseFilter.noiseFilter(timestamp, &triggerState, signal PASS_ENGINE_PARAMETER_SUFFIX)) {
return;
}
2020-08-23 23:23:13 -07:00
const TriggerConfiguration * triggerConfiguration = &engine->primaryTriggerConfiguration;
// moved here from hwHandleShaftSignal()
2020-08-23 23:23:13 -07:00
if (!isUsefulSignal(signal, triggerConfiguration)) {
return;
}
}
engine->onTriggerSignalEvent(timestamp);
2015-07-10 06:01:56 -07:00
int eventIndex = (int) signal;
2020-01-27 21:16:33 -08:00
efiAssertVoid(CUSTOM_TRIGGER_EVENT_TYPE, eventIndex >= 0 && eventIndex < HW_EVENT_TYPES, "signal type");
2015-07-10 06:01:56 -07:00
hwEventCounters[eventIndex]++;
/**
* This invocation changes the state of triggerState
*/
2020-01-29 22:20:41 -08:00
triggerState.decodeTriggerEvent(&triggerShape,
2020-08-23 22:21:42 -07:00
nullptr,
engine,
&engine->primaryTriggerConfiguration,
2020-08-23 23:01:50 -07:00
signal, timestamp);
2015-07-10 06:01:56 -07:00
/**
* If we only have a crank position sensor with four stroke, here we are extending crank revolutions with a 360 degree
* cycle into a four stroke, 720 degrees cycle.
*/
int triggerIndexForListeners;
operation_mode_e operationMode = engine->getOperationMode(PASS_ENGINE_PARAMETER_SIGNATURE);
2020-01-29 22:20:41 -08:00
if (operationMode == FOUR_STROKE_CAM_SENSOR || operationMode == TWO_STROKE) {
2015-07-10 06:01:56 -07:00
// That's easy - trigger cycle matches engine cycle
triggerIndexForListeners = triggerState.getCurrentIndex();
} else {
int crankDivider = operationMode == FOUR_STROKE_CRANK_SENSOR ? 2 : SYMMETRICAL_CRANK_SENSOR_DIVIDER;
2015-07-10 06:01:56 -07:00
2016-11-13 20:02:33 -08:00
int crankInternalIndex = triggerState.getTotalRevolutionCounter() % crankDivider;
triggerIndexForListeners = triggerState.getCurrentIndex() + (crankInternalIndex * getTriggerSize());
2015-07-10 06:01:56 -07:00
}
2016-08-22 20:04:55 -07:00
if (triggerIndexForListeners == 0) {
timeAtVirtualZeroNt = timestamp;
2016-08-22 20:04:55 -07:00
}
2017-05-15 20:28:49 -07:00
reportEventToWaveChart(signal, triggerIndexForListeners PASS_ENGINE_PARAMETER_SUFFIX);
2015-07-10 06:01:56 -07:00
2015-07-15 17:01:33 -07:00
if (!triggerState.shaft_is_synchronized) {
// we should not propagate event if we do not know where we are
return;
}
2020-01-24 10:42:09 -08:00
if (triggerState.isValidIndex(&ENGINE(triggerCentral.triggerShape))) {
2019-10-13 13:14:08 -07:00
ScopePerf perf(PE::ShaftPositionListeners);
2019-04-12 19:07:03 -07:00
#if TRIGGER_EXTREME_LOGGING
2016-10-31 17:02:09 -07:00
scheduleMsg(logger, "trigger %d %d %d", triggerIndexForListeners, getRevolutionCounter(), (int)getTimeNowUs());
2020-07-20 10:38:33 -07:00
#endif /* TRIGGER_EXTREME_LOGGING */
2016-10-31 17:02:09 -07:00
2015-07-10 06:01:56 -07:00
/**
* Here we invoke all the listeners - the main engine control logic is inside these listeners
*/
for (int i = 0; i < triggerListeneres.currentListenersCount; i++) {
2018-12-27 06:40:40 -08:00
ShaftPositionListener listener = (ShaftPositionListener) (void*) triggerListeneres.callbacks[i];
(listener)(signal, triggerIndexForListeners, timestamp PASS_ENGINE_PARAMETER_SUFFIX);
2015-07-10 06:01:56 -07:00
}
}
}
EXTERN_ENGINE;
2015-07-10 06:01:56 -07:00
static void triggerShapeInfo(void) {
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE || EFI_SIMULATOR
2020-08-24 21:59:07 -07:00
TriggerWaveform *shape = &engine->triggerCentral.triggerShape;
TriggerFormDetails *triggerFormDetails = &engine->triggerCentral.triggerFormDetails;
scheduleMsg(logger, "useRise=%s", boolToString(TRIGGER_WAVEFORM(useRiseEdge)));
scheduleMsg(logger, "gap from %.2f to %.2f", TRIGGER_WAVEFORM(syncronizationRatioFrom[0]), TRIGGER_WAVEFORM(syncronizationRatioTo[0]));
2015-07-10 06:01:56 -07:00
2020-08-24 21:59:07 -07:00
for (size_t i = 0; i < shape->getSize(); i++) {
scheduleMsg(logger, "event %d %.2f", i, triggerFormDetails->eventAngles[i]);
2015-07-10 06:01:56 -07:00
}
#endif
}
2019-04-12 19:07:03 -07:00
#if EFI_UNIT_TEST
2015-07-10 06:01:56 -07:00
#include <stdlib.h>
2015-08-29 10:04:24 -07:00
#define TRIGGERS_FILE_NAME "triggers.txt"
2015-07-10 06:01:56 -07:00
/**
2015-08-29 10:04:24 -07:00
* This is used to generate trigger info which is later used by TriggerImage java class
* to generate images for documentation
2015-07-10 06:01:56 -07:00
*/
2015-09-10 20:01:32 -07:00
extern bool printTriggerDebug;
2015-07-10 06:01:56 -07:00
void printAllTriggers() {
2015-08-29 10:04:24 -07:00
FILE * fp = fopen (TRIGGERS_FILE_NAME, "w+");
2015-07-10 06:01:56 -07:00
2018-11-22 07:25:02 -08:00
fprintf(fp, "# Generated by rusEfi unit test suite\n");
fprintf(fp, "# This file is used by TriggerImage tool\n");
fprintf(fp, "# See 'gen_trigger_images.bat'\n");
2019-08-24 22:15:18 -07:00
//printTriggerDebug = true;
2015-07-10 06:01:56 -07:00
for (int triggerId = 1; triggerId < TT_UNUSED; triggerId++) {
trigger_type_e tt = (trigger_type_e) triggerId;
printf("Exporting %s\r\n", getTrigger_type_e(tt));
persistent_config_s pc;
Engine e(&pc);
Engine *engine = &e;
persistent_config_s *config = &pc;
engine_configuration_s *engineConfiguration = &pc.engineConfiguration;
2015-07-10 06:01:56 -07:00
engineConfiguration->trigger.type = tt;
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
2015-07-10 06:01:56 -07:00
2020-08-24 21:59:07 -07:00
TriggerWaveform *shape = &engine->triggerCentral.triggerShape;
TriggerFormDetails *triggerFormDetails = &engine->triggerCentral.triggerFormDetails;
engine->initializeTriggerWaveform(NULL PASS_ENGINE_PARAMETER_SUFFIX);
2015-07-10 06:01:56 -07:00
2020-08-24 21:59:07 -07:00
if (shape->shapeDefinitionError) {
2018-10-30 02:32:13 -07:00
printf("Trigger error %d\r\n", triggerId);
exit(-1);
}
2018-03-01 03:01:15 -08:00
2020-08-24 21:59:07 -07:00
fprintf(fp, "TRIGGERTYPE %d %d %s %.2f\n", triggerId, shape->getLength(), getTrigger_type_e(tt), shape->tdcPosition);
2015-08-30 10:02:46 -07:00
2020-08-24 21:59:07 -07:00
fprintf(fp, "# duty %.2f %.2f\n", shape->expectedDutyCycle[0], shape->expectedDutyCycle[1]);
2015-08-30 10:02:46 -07:00
2020-08-24 21:59:07 -07:00
for (int i = 0; i < shape->getLength(); i++) {
2015-07-10 06:01:56 -07:00
2020-08-24 21:59:07 -07:00
int triggerDefinitionCoordinate = (shape->getTriggerWaveformSynchPointIndex() + i) % shape->getSize();
2015-07-10 06:01:56 -07:00
2020-08-24 21:59:07 -07:00
fprintf(fp, "event %d %d %.2f\n", i, shape->triggerSignals[triggerDefinitionCoordinate], triggerFormDetails->eventAngles[i]);
2015-07-10 06:01:56 -07:00
}
}
fclose(fp);
2018-02-28 20:31:58 -08:00
printf("All triggers exported to %s\n", TRIGGERS_FILE_NAME);
2015-07-10 06:01:56 -07:00
}
#endif
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE
2015-07-10 06:01:56 -07:00
extern PwmConfig triggerSignal;
#endif /* #if EFI_PROD_CODE */
extern uint32_t hipLastExecutionCount;
2017-05-21 07:25:35 -07:00
extern uint32_t hwSetTimerDuration;
extern uint32_t maxLockedDuration;
extern uint32_t maxEventCallbackDuration;
2018-12-23 21:31:26 -08:00
extern int perSecondIrqDuration;
extern int perSecondIrqCounter;
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE
2017-05-21 07:25:35 -07:00
extern uint32_t maxPrecisionCallbackDuration;
#endif /* EFI_PROD_CODE */
2015-07-10 06:01:56 -07:00
2017-05-21 08:09:47 -07:00
extern uint32_t maxSchedulingPrecisionLoss;
2015-07-10 06:01:56 -07:00
extern uint32_t *cyccnt;
2017-05-19 18:52:10 -07:00
void resetMaxValues() {
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE || EFI_SIMULATOR
2017-05-21 07:25:35 -07:00
maxEventCallbackDuration = triggerMaxDuration = 0;
2017-05-19 19:30:21 -07:00
#endif /* EFI_PROD_CODE || EFI_SIMULATOR */
2017-05-21 07:46:43 -07:00
2017-05-21 08:09:47 -07:00
maxSchedulingPrecisionLoss = 0;
2019-04-12 19:07:03 -07:00
#if EFI_CLOCK_LOCKS
2017-05-21 07:25:35 -07:00
maxLockedDuration = 0;
2017-05-21 07:46:43 -07:00
#endif /* EFI_CLOCK_LOCKS */
2017-05-21 07:25:35 -07:00
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE
2017-05-21 07:25:35 -07:00
maxPrecisionCallbackDuration = 0;
#endif /* EFI_PROD_CODE */
2017-05-19 18:52:10 -07:00
}
#if HAL_USE_ICU == TRUE
extern int icuRisingCallbackCounter;
extern int icuFallingCallbackCounter;
#endif /* HAL_USE_ICU */
2015-07-10 06:01:56 -07:00
void triggerInfo(void) {
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE || EFI_SIMULATOR
2015-07-10 06:01:56 -07:00
TriggerWaveform *ts = &engine->triggerCentral.triggerShape;
2015-07-10 06:01:56 -07:00
2019-08-06 20:56:35 -07:00
#if (HAL_TRIGGER_USE_PAL == TRUE) && (PAL_USE_CALLBACKS == TRUE)
2019-11-11 19:19:35 -08:00
scheduleMsg(logger, "trigger PAL mode %d", engine->hwTriggerInputEnabled);
2019-08-06 20:56:35 -07:00
#else
#if HAL_USE_ICU == TRUE
scheduleMsg(logger, "trigger ICU hw: %d %d %d", icuRisingCallbackCounter, icuFallingCallbackCounter, engine->hwTriggerInputEnabled);
#endif /* HAL_USE_ICU */
2019-08-06 19:17:18 -07:00
#endif /* HAL_TRIGGER_USE_PAL */
2018-01-23 09:05:14 -08:00
scheduleMsg(logger, "Template %s (%d) trigger %s (%d) useRiseEdge=%s onlyFront=%s useOnlyFirstChannel=%s tdcOffset=%.2f",
2015-07-10 06:01:56 -07:00
getConfigurationName(engineConfiguration->engineType), engineConfiguration->engineType,
getTrigger_type_e(engineConfiguration->trigger.type), engineConfiguration->trigger.type,
boolToString(TRIGGER_WAVEFORM(useRiseEdge)), boolToString(engineConfiguration->useOnlyRisingEdgeForTrigger),
boolToString(engineConfiguration->trigger.useOnlyFirstChannel), TRIGGER_WAVEFORM(tdcPosition));
2015-07-10 06:01:56 -07:00
if (engineConfiguration->trigger.type == TT_TOOTHED_WHEEL) {
scheduleMsg(logger, "total %d/skipped %d", engineConfiguration->trigger.customTotalToothCount,
engineConfiguration->trigger.customSkippedToothCount);
}
2015-09-13 14:02:44 -07:00
scheduleMsg(logger, "trigger#1 event counters up=%d/down=%d", engine->triggerCentral.getHwEventCounter(0),
engine->triggerCentral.getHwEventCounter(1));
2015-07-10 06:01:56 -07:00
2017-03-01 19:18:25 -08:00
if (ts->needSecondTriggerInput) {
2015-09-13 14:02:44 -07:00
scheduleMsg(logger, "trigger#2 event counters up=%d/down=%d", engine->triggerCentral.getHwEventCounter(2),
engine->triggerCentral.getHwEventCounter(3));
2015-07-10 06:01:56 -07:00
}
scheduleMsg(logger, "expected cycle events %d/%d/%d", TRIGGER_WAVEFORM(expectedEventCount[0]),
TRIGGER_WAVEFORM(expectedEventCount[1]), TRIGGER_WAVEFORM(expectedEventCount[2]));
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "trigger type=%d/need2ndChannel=%s", engineConfiguration->trigger.type,
boolToString(TRIGGER_WAVEFORM(needSecondTriggerInput)));
scheduleMsg(logger, "expected duty #0=%.2f/#1=%.2f", TRIGGER_WAVEFORM(expectedDutyCycle[0]), TRIGGER_WAVEFORM(expectedDutyCycle[1]));
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "synchronizationNeeded=%s/isError=%s/total errors=%d ord_err=%d/total revolutions=%d/self=%s",
boolToString(ts->isSynchronizationNeeded),
2015-09-13 14:02:44 -07:00
boolToString(isTriggerDecoderError()), engine->triggerCentral.triggerState.totalTriggerErrorCounter,
engine->triggerCentral.triggerState.orderingErrorCounter, engine->triggerCentral.triggerState.getTotalRevolutionCounter(),
boolToString(engine->directSelfStimulation));
2015-07-10 06:01:56 -07:00
if (TRIGGER_WAVEFORM(isSynchronizationNeeded)) {
scheduleMsg(logger, "gap from %.2f to %.2f", TRIGGER_WAVEFORM(syncronizationRatioFrom[0]), TRIGGER_WAVEFORM(syncronizationRatioTo[0]));
2015-07-10 06:01:56 -07:00
}
2017-05-19 18:52:10 -07:00
#endif /* EFI_PROD_CODE || EFI_SIMULATOR */
2015-07-10 06:01:56 -07:00
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE
if (HAVE_CAM_INPUT()) {
scheduleMsg(logger, "VVT input: %s mode %s", hwPortname(engineConfiguration->camInputs[0]),
2017-11-19 19:31:01 -08:00
getVvt_mode_e(engineConfiguration->vvtMode));
2019-09-02 18:02:08 -07:00
scheduleMsg(logger, "VVT event counters: %d/%d", engine->triggerCentral.vvtEventRiseCounter, engine->triggerCentral.vvtEventFallCounter);
2016-08-20 16:02:07 -07:00
}
scheduleMsg(logger, "primary trigger input: %s", hwPortname(CONFIG(triggerInputPins)[0]));
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "primary trigger simulator: %s %s freq=%d",
hwPortname(CONFIG(triggerSimulatorPins)[0]),
getPin_output_mode_e(CONFIG(triggerSimulatorPinModes)[0]),
CONFIG(triggerSimulatorFrequency));
2015-07-10 06:01:56 -07:00
2017-03-01 19:18:25 -08:00
if (ts->needSecondTriggerInput) {
scheduleMsg(logger, "secondary trigger input: %s", hwPortname(CONFIG(triggerInputPins)[1]));
2019-04-12 19:07:03 -07:00
#if EFI_EMULATE_POSITION_SENSORS
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "secondary trigger simulator: %s %s phase=%d",
hwPortname(CONFIG(triggerSimulatorPins)[1]),
getPin_output_mode_e(CONFIG(triggerSimulatorPinModes)[1]), triggerSignal.safe.phaseIndex);
2015-07-10 06:01:56 -07:00
#endif /* EFI_EMULATE_POSITION_SENSORS */
}
// scheduleMsg(logger, "3rd trigger simulator: %s %s", hwPortname(CONFIG(triggerSimulatorPins)[2]),
// getPin_output_mode_e(CONFIG(triggerSimulatorPinModes)[2]));
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "trigger error extra LED: %s %s", hwPortname(CONFIG(triggerErrorPin)),
getPin_output_mode_e(CONFIG(triggerErrorPinMode)));
scheduleMsg(logger, "primary logic input: %s", hwPortname(CONFIG(logicAnalyzerPins)[0]));
scheduleMsg(logger, "secondary logic input: %s", hwPortname(CONFIG(logicAnalyzerPins)[1]));
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "maxSchedulingPrecisionLoss=%d", maxSchedulingPrecisionLoss);
2015-07-10 06:01:56 -07:00
2019-04-12 19:07:03 -07:00
#if EFI_CLOCK_LOCKS
2017-05-21 07:25:35 -07:00
scheduleMsg(logger, "maxLockedDuration=%d / maxTriggerReentraint=%d", maxLockedDuration, maxTriggerReentraint);
2018-12-23 21:31:26 -08:00
scheduleMsg(logger, "perSecondIrqDuration=%d ticks / perSecondIrqCounter=%d", perSecondIrqDuration, perSecondIrqCounter);
2019-01-04 18:33:50 -08:00
scheduleMsg(logger, "IRQ CPU utilization %f%%", perSecondIrqDuration / (float)CORE_CLOCK * 100);
2018-12-23 21:31:26 -08:00
2017-05-21 07:46:43 -07:00
#endif /* EFI_CLOCK_LOCKS */
2017-05-21 07:25:35 -07:00
scheduleMsg(logger, "maxEventCallbackDuration=%d", maxEventCallbackDuration);
2015-07-10 06:01:56 -07:00
2019-04-12 19:07:03 -07:00
#if EFI_HIP_9011
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "hipLastExecutionCount=%d", hipLastExecutionCount);
#endif /* EFI_HIP_9011 */
2017-05-21 07:25:35 -07:00
scheduleMsg(logger, "hwSetTimerDuration=%d", hwSetTimerDuration);
2015-07-10 06:01:56 -07:00
scheduleMsg(logger, "totalTriggerHandlerMaxTime=%d", triggerMaxDuration);
2017-05-21 07:25:35 -07:00
scheduleMsg(logger, "maxPrecisionCallbackDuration=%d", maxPrecisionCallbackDuration);
2017-05-19 18:52:10 -07:00
resetMaxValues();
2015-07-10 06:01:56 -07:00
#endif /* EFI_PROD_CODE */
}
static void resetRunningTriggerCounters() {
2019-04-12 19:07:03 -07:00
#if !EFI_UNIT_TEST
2015-09-13 14:02:44 -07:00
engine->triggerCentral.resetCounters();
2015-07-10 06:01:56 -07:00
triggerInfo();
#endif
}
2019-10-21 20:47:40 -07:00
void onConfigurationChangeTriggerCallback(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
2019-07-12 18:13:24 -07:00
bool changed = false;
for (int i = 0; i < CAM_INPUTS_COUNT; i++) {
2019-10-21 20:47:40 -07:00
changed |= isConfigurationChanged(camInputs[i]);
2019-07-12 18:13:24 -07:00
}
changed |=
2019-10-21 20:47:40 -07:00
isConfigurationChanged(trigger.type) ||
isConfigurationChanged(ambiguousOperationMode) ||
isConfigurationChanged(useOnlyRisingEdgeForTrigger) ||
isConfigurationChanged(globalTriggerAngleOffset) ||
isConfigurationChanged(trigger.customTotalToothCount) ||
isConfigurationChanged(trigger.customSkippedToothCount) ||
isConfigurationChanged(triggerInputPins[0]) ||
isConfigurationChanged(triggerInputPins[1]) ||
isConfigurationChanged(triggerInputPins[2]) ||
2019-10-21 20:47:40 -07:00
isConfigurationChanged(vvtMode) ||
isConfigurationChanged(vvtCamSensorUseRise) ||
2020-05-09 22:34:43 -07:00
isConfigurationChanged(vvtOffset);
if (changed) {
2018-02-03 17:43:31 -08:00
assertEngineReference();
2019-04-12 19:07:03 -07:00
#if EFI_ENGINE_CONTROL
ENGINE(initializeTriggerWaveform(logger PASS_ENGINE_PARAMETER_SUFFIX));
2020-01-27 21:16:33 -08:00
engine->triggerCentral.noiseFilter.resetAccumSignalData();
2018-02-03 17:43:31 -08:00
#endif
}
2018-03-04 17:43:38 -08:00
#if EFI_DEFAILED_LOGGING
scheduleMsg(logger, "isTriggerConfigChanged=%d", engine->isTriggerConfigChanged);
2018-03-04 17:43:38 -08:00
#endif /* EFI_DEFAILED_LOGGING */
2018-02-04 09:46:57 -08:00
// we do not want to miss two updates in a row
engine->isTriggerConfigChanged = engine->isTriggerConfigChanged || changed;
}
2017-07-05 19:22:24 -07:00
/**
* @returns true if configuration just changed, and if that change has affected trigger
*/
bool checkIfTriggerConfigChanged(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
bool result = engine->triggerVersion.isOld(engine->getGlobalConfigurationVersion()) && engine->isTriggerConfigChanged;
engine->isTriggerConfigChanged = false; // whoever has called the method is supposed to react to changes
2018-02-04 09:46:57 -08:00
return result;
}
2019-05-10 18:29:17 -07:00
bool isTriggerConfigChanged(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
return engine->isTriggerConfigChanged;
}
2017-05-15 17:31:16 -07:00
void initTriggerCentral(Logging *sharedLogger) {
2015-07-10 06:01:56 -07:00
logger = sharedLogger;
strcpy((char*) shaft_signal_msg_index, "x_");
2019-04-12 19:07:03 -07:00
#if EFI_ENGINE_SNIFFER
2015-07-10 06:01:56 -07:00
initWaveChart(&waveChart);
2015-07-15 18:01:45 -07:00
#endif /* EFI_ENGINE_SNIFFER */
2015-07-10 06:01:56 -07:00
2019-04-12 19:07:03 -07:00
#if EFI_PROD_CODE || EFI_SIMULATOR
addConsoleAction(CMD_TRIGGERINFO, triggerInfo);
2015-07-10 06:01:56 -07:00
addConsoleAction("trigger_shape_info", triggerShapeInfo);
addConsoleAction("reset_trigger", resetRunningTriggerCounters);
2020-08-23 23:01:50 -07:00
#endif // EFI_PROD_CODE || EFI_SIMULATOR
2015-07-10 06:01:56 -07:00
}
2020-08-23 23:01:50 -07:00
/**
* @return TRUE is something is wrong with trigger decoding
*/
bool isTriggerDecoderError(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
return engine->triggerErrorDetection.sum(6) > 4;
}
#endif // EFI_SHAFT_POSITION_INPUT