From 14abddb5d785d6363642b5d066aa801ca1e0f85d Mon Sep 17 00:00:00 2001 From: rusefillc Date: Sat, 16 Oct 2021 21:22:48 -0400 Subject: [PATCH] Remove engine load acceleration enrichment #3357 --- firmware/CHANGELOG.md | 3 +++ firmware/config/engines/dodge_neon.cpp | 4 ---- firmware/config/engines/ford_festiva.cpp | 3 --- firmware/config/engines/mazda_626.cpp | 5 ----- firmware/tunerstudio/rusefi.input | 17 ++--------------- 5 files changed, 5 insertions(+), 27 deletions(-) diff --git a/firmware/CHANGELOG.md b/firmware/CHANGELOG.md index fe2fb7eeca..b2b045208b 100644 --- a/firmware/CHANGELOG.md +++ b/firmware/CHANGELOG.md @@ -27,6 +27,9 @@ All notable user-facing or behavior-altering changes will be documented in this ## Month 202x Release - "Release Name" +## Removed + - Remove engine load acceleration enrichment #3357 + ## October 2021 Release - "Pierogi Day" ### Added diff --git a/firmware/config/engines/dodge_neon.cpp b/firmware/config/engines/dodge_neon.cpp index 04faceb10a..e872cef27b 100644 --- a/firmware/config/engines/dodge_neon.cpp +++ b/firmware/config/engines/dodge_neon.cpp @@ -383,10 +383,6 @@ void setDodgeNeonNGCEngineConfiguration(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->canNbcType = CAN_BUS_NBC_BMW; // engineConfiguration->canNbcType = CAN_BUS_MAZDA_RX8; - engineConfiguration->engineLoadAccelLength = 12; - engineConfiguration->engineLoadAccelEnrichmentThreshold = 5; // kPa - engineConfiguration->engineLoadAccelEnrichmentMultiplier = 0; - engineConfiguration->tpsAccelLength = 12; engineConfiguration->tpsAccelEnrichmentThreshold = 10; diff --git a/firmware/config/engines/ford_festiva.cpp b/firmware/config/engines/ford_festiva.cpp index 47343d11ce..72e29fa0df 100644 --- a/firmware/config/engines/ford_festiva.cpp +++ b/firmware/config/engines/ford_festiva.cpp @@ -267,9 +267,6 @@ void setFordEscortGt(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->tpsAccelEnrichmentThreshold = 40; - engineConfiguration->engineLoadAccelEnrichmentThreshold = 5.0; - engineConfiguration->engineLoadAccelEnrichmentMultiplier = 1; - engineConfiguration->isSdCardEnabled = true; // engineConfiguration->useFSIO16ForTimingAdjustment = true; diff --git a/firmware/config/engines/mazda_626.cpp b/firmware/config/engines/mazda_626.cpp index 222f1a6bcd..60f6113c85 100644 --- a/firmware/config/engines/mazda_626.cpp +++ b/firmware/config/engines/mazda_626.cpp @@ -72,11 +72,6 @@ void setMazda626EngineConfiguration(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->map.sensor.type = MT_SUBY_DENSO; - // http://s2.micp.ru/vJ9Sd.png - engineConfiguration->engineLoadAccelLength = 12; - engineConfiguration->engineLoadAccelEnrichmentThreshold = 1; - engineConfiguration->engineLoadAccelEnrichmentMultiplier = 0.25; - engineConfiguration->tpsAccelLength = 12; engineConfiguration->tpsAccelEnrichmentThreshold = 10; diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index a738c38646..95abd4605c 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -265,9 +265,9 @@ enable2ndByteCanID = false wallFuelCorrection=scalar, S16, 74, "ms",0.001, 0 ; TPS/load AE - engineLoadDelta = scalar, S16, 76, "value",{1/@@PACK_MULT_PERCENT@@}, 0 + unusedLoadDelta = scalar, S16, 76, "value",{1/@@PACK_MULT_PERCENT@@}, 0 deltaTps = scalar, S16, 78, "ratio",{1/@@PACK_MULT_PERCENT@@}, 0 - engineLoadAccelExtra=scalar,S16, 80, "value",{1/@@PACK_MULT_PERCENT@@}, 0 + unusedLoadAccelExtra=scalar,S16, 80, "value",{1/@@PACK_MULT_PERCENT@@}, 0 tpsAccelFuel = scalar, U16, 82, "ms",{1/@@PACK_MULT_MS@@}, 0 ; Ignition @@ -1066,8 +1066,6 @@ gaugeCategory = Ignition ignitionLoadGauge = ignitionLoad, @@GAUGE_NAME_IGNITION_LOAD@@, "%", 0, 300, 0, 0, 300, 300, 1, 1 gaugeCategory = Acceleration Enrichment - engineLoadDeltaGauge = engineLoadDelta,"AE: load change","value", 0, 120, 10, 10, 100, 100, 1, 1 - engineLoadAccelExtraGauge = engineLoadAccelExtra,"AE: load extra","value", 0, 120, 10, 10, 100, 100, 1, 1 deltaTpsGauge = deltaTps, "AE: TPS change", "", 0, 120, 10, 10, 100, 100, 1, 1 tpsAccelFuelGauge = tpsAccelFuel,"AE: TPS enrich", "ms", 0, 120, 10, 10, 100, 100, 1, 1 wallFuelAmountGauge = wallFuelAmount, "AE: wall amount", "ms", 0, 100, 0, 0, 100, 100, 0, 0 @@ -1310,9 +1308,6 @@ gaugeCategory = DynoView entry = egt7, "EGT7", float,"%.1f", { max31855_cs7 != 0} entry = egt8, "EGT8", float,"%.1f", { max31855_cs8 != 0} - entry = engineLoadAccelExtra, @@GAUGE_NAME_FUEL_EL_EXTRA@@,float, "%.3f" - entry = engineLoadDelta, "fuel: load change",float, "%.3f" - entry = deltaTps, @@GAUGE_NAME_FUEL_TPS_ROC@@,float, "%.3f" entry = tpsAccelFuel, @@GAUGE_NAME_FUEL_TPS_EXTRA@@, float, "%.3f" @@ -3236,13 +3231,6 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@\x00\x31\x00\x00" panel = crankingIAC panel = crankingAdv - dialog = EngineLoadAccelPanel, "Engine Load (alpha version)" - field = "Length", engineLoadAccelLength - field = "Accel threshold", engineLoadAccelEnrichmentThreshold - field = "Accel multiplier", engineLoadAccelEnrichmentMultiplier - field = "Decel threshold", engineLoadDecelEnleanmentThreshold - field = "Decel multiplier", engineLoadDecelEnleanmentMultiplier - dialog = TpsAccelPanel, "TPS" field = "Set 'Debug Mode' to see detailed 'TPS acceleration enrichment' diagnostics" field = "Length", tpsAccelLength @@ -3262,7 +3250,6 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@\x00\x31\x00\x00" dialog = AccelEnrich, "Accel/Decel Enrichment" panel = TpsAccelPanel panel = WallWettingAccelPanel - panel = EngineLoadAccelPanel field = "No accel after RPM hard limit", noAccelAfterHardLimitPeriodSecs