From 1e12cbefd5a8ffebc3376ed6631231d45f03e28a Mon Sep 17 00:00:00 2001 From: rusefi Date: Tue, 5 Feb 2019 23:49:19 -0500 Subject: [PATCH] dwell docs --- firmware/controllers/algo/engine_configuration.cpp | 8 ++++++-- .../algo/engine_configuration_generated_structures.h | 5 +++-- firmware/integration/rusefi_config.txt | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/firmware/controllers/algo/engine_configuration.cpp b/firmware/controllers/algo/engine_configuration.cpp index 1826512dbc..b949ae2f64 100644 --- a/firmware/controllers/algo/engine_configuration.cpp +++ b/firmware/controllers/algo/engine_configuration.cpp @@ -691,8 +691,12 @@ void setDefaultConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { setMazdaMiataNbTpsTps(PASS_ENGINE_PARAMETER_SIGNATURE); - setConstantDwell(4 PASS_ENGINE_PARAMETER_SUFFIX); // 4ms is global default dwell - // disable constant_dwell + /** + * 4ms is global default dwell for the whole RPM range + * if you only have one coil and many cylinders or high RPM you would need lower value at higher RPM + */ + setConstantDwell(4 PASS_ENGINE_PARAMETER_SUFFIX); + // Use angle-based duration during cranking engineConfiguration->useConstantDwellDuringCranking = false; engineConfiguration->ignitionDwellForCrankingMs = 6; diff --git a/firmware/controllers/algo/engine_configuration_generated_structures.h b/firmware/controllers/algo/engine_configuration_generated_structures.h index 489e158ecd..e9ccf4b3ad 100644 --- a/firmware/controllers/algo/engine_configuration_generated_structures.h +++ b/firmware/controllers/algo/engine_configuration_generated_structures.h @@ -1,4 +1,4 @@ -// this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Sat Jan 26 23:18:47 EST 2019 +// this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Tue Feb 05 23:48:04 EST 2019 // begin #ifndef ENGINE_CONFIGURATION_GENERATED_H_ #define ENGINE_CONFIGURATION_GENERATED_H_ @@ -1022,6 +1022,7 @@ typedef struct { */ float primingSquirtDurationMs; /** + * Used if useConstantDwellDuringCranking is TRUE * offset 100 */ float ignitionDwellForCrankingMs; @@ -2480,4 +2481,4 @@ typedef struct { #endif // end -// this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Sat Jan 26 23:18:47 EST 2019 +// this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Tue Feb 05 23:48:04 EST 2019 diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index a18bc376b7..9834c991cd 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -289,7 +289,7 @@ int16_t tpsErrorDetectionTooHigh;+TPS error detection, what TPS % value is unrea cranking_parameters_s cranking float primingSquirtDurationMs;;"*C", 1, 0, -40, 200, 1 - float ignitionDwellForCrankingMs;;"ms", 1, 0, 0, 200, 1 + float ignitionDwellForCrankingMs;Used if useConstantDwellDuringCranking is TRUE;"ms", 1, 0, 0, 200, 1 float crankingChargeAngle;+While cranking (which causes battery voltage to drop) we can calculate dwell time in shaft\ndegrees, not in absolute time as in running mode.\nset cranking_charge_angle X;"deg", 1, 0, 0, 3000.0, 0