From 241258a9de3f87e0d5be4e5d993468558b5fe1e3 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Thu, 8 Sep 2022 14:44:34 -0400 Subject: [PATCH] defaults clean-up: silentTriggerError --- firmware/config/boards/prometheus/board_configuration.cpp | 3 --- firmware/config/boards/subaru_eg33/board_configuration.cpp | 3 --- firmware/config/engines/mazda_miata_1_6.cpp | 1 - firmware/config/engines/mazda_miata_na8.cpp | 2 +- 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/firmware/config/boards/prometheus/board_configuration.cpp b/firmware/config/boards/prometheus/board_configuration.cpp index aba8379d3f..34399d7611 100644 --- a/firmware/config/boards/prometheus/board_configuration.cpp +++ b/firmware/config/boards/prometheus/board_configuration.cpp @@ -232,9 +232,6 @@ void setBoardDefaultConfiguration() { setPrometheusDefaults(); #endif - //!!!!!!!!!!!!!!!!!!! - //engineConfiguration->silentTriggerError = true; - engineConfiguration->is_enabled_spi_1 = true; engineConfiguration->sdCardSpiDevice = SPI_DEVICE_1; engineConfiguration->sdCardCsPin = Gpio::A2; diff --git a/firmware/config/boards/subaru_eg33/board_configuration.cpp b/firmware/config/boards/subaru_eg33/board_configuration.cpp index b899a5ecc5..09d08aed3a 100644 --- a/firmware/config/boards/subaru_eg33/board_configuration.cpp +++ b/firmware/config/boards/subaru_eg33/board_configuration.cpp @@ -238,9 +238,6 @@ void setBoardDefaultConfiguration() { engineConfiguration->triggerSimulatorPinModes[1] = OM_DEFAULT; engineConfiguration->triggerSimulatorPinModes[2] = OM_DEFAULT; - //!!!!!!!!!!!!!!!!!!! - //engineConfiguration->silentTriggerError = true; - if (engineConfiguration->fuelAlgorithm == LM_REAL_MAF) setAlgorithm(LM_SPEED_DENSITY); if (engineConfiguration->fuelAlgorithm == LM_ALPHA_N) diff --git a/firmware/config/engines/mazda_miata_1_6.cpp b/firmware/config/engines/mazda_miata_1_6.cpp index 5e2b8d25ba..fa5aae923f 100644 --- a/firmware/config/engines/mazda_miata_1_6.cpp +++ b/firmware/config/engines/mazda_miata_1_6.cpp @@ -176,7 +176,6 @@ void miataNAcommonEngineSettings() { copyTable(config->ignitionTable, mapBased16IgnitionTable); #endif - engineConfiguration->silentTriggerError = false; engineConfiguration->manIdlePosition = 20; diff --git a/firmware/config/engines/mazda_miata_na8.cpp b/firmware/config/engines/mazda_miata_na8.cpp index b8499e625e..3ab5979bf8 100644 --- a/firmware/config/engines/mazda_miata_na8.cpp +++ b/firmware/config/engines/mazda_miata_na8.cpp @@ -39,7 +39,7 @@ static void commonNA8() { engineConfiguration->iacByTpsTaper = 6; engineConfiguration->useIdleTimingPidControl = true; engineConfiguration->engineChartSize = 300; - engineConfiguration->silentTriggerError = true; + engineConfiguration->wwaeTau = 0.1; engineConfiguration->targetVBatt = 14.2; engineConfiguration->crankingIACposition = 36;