Trigger setup in TS is highly confusing: hide operation mode from users? fix #4031

This commit is contained in:
Andrey 2022-04-03 02:46:00 -04:00
parent 20dbc1ff82
commit 3246e29245
2 changed files with 1 additions and 4 deletions

View File

@ -559,9 +559,7 @@ can_nbc_e canNbcType;set can_mode X
int canSleepPeriodMs;CANbus thread period in ms;"ms", 1, 0, 0, 1000, 2
custom operation_mode_e 4 bits, U32, @OFFSET@, [0:2], "INVALID", "4 stroke without cam sensor", "4 stroke with cam sensor", "2 stroke", "4 stroke with symmetrical crank (requires VVT input)", "INVALID", "INVALID", "INVALID"
operation_mode_e ambiguousOperationMode;+'Some triggers could be mounted differently. Most well-known triggers imply specific sensor setup. 4 stroke with symmetrical crank' is a pretty special case for example on Miata NB2\nSee engineCycle\nset operation_mode X
int weHaveUnusedHere;;"index", 1, 0, 0, 300, 0
custom display_mode_e 4 bits, U32, @OFFSET@, [0:1], "none", "hd44780", "hd44780 over pcf8574", "INVALID"
display_mode_e displayMode;

View File

@ -1906,7 +1906,6 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@\x00\x31\x00\x00"
field = "Missing/skipped tooth count", trigger_customSkippedToothCount, {trigger_type == @@trigger_type_e_TT_TOOTHED_WHEEL@@}, {trigger_type == @@trigger_type_e_TT_TOOTHED_WHEEL@@}
; see also in firmware '[doesTriggerImplyOperationMode]' tag
field = "Operation mode / speed", ambiguousOperationMode
field = "What kind of engine", twoStroke
field = "Skipped wheel location", skippedWheelOnCam, { twoStroke == 0 }
field = "#Please use '4 stroke with cam' only if primary trigger sensor is actually on cam"