Can vss updates (#1345)

* Vss over Can implementation proposal

Working for BMW e46

* fixed Firmware CI?

* kinetis fix.

* minor fixes

* Added W202 + fixed broken configs

- w202 Vel decoded
- added dbc checks

firmware/controllers/algo/obd_error_codes.h

@@ -1086,6 +1086,7 @@ typedef enum {
 	//P2155 Fuel Injector Group D Supply Voltage Circ/Open
 	//P2156 Fuel Injector Group D Supply Voltage Circ Low
 	//P2157 Fuel Injector Group D Supply Voltage Circ High
+	OBD_Vehicle_Speed_SensorB = 2158,
 	//P2158 Vehicle Speed SensorB
 	//P2159 Vehicle Speed SensorB Range/Perf
 	//P2160 Vehicle Speed SensorB Circ Low

firmware/controllers/can/can_vss.cpp

@@ -21,12 +21,26 @@ static bool isInit = false;
 static uint16_t filterCanID = 0;
 static efitick_t frameTime;
 static float vssSpeed = 0;
-/* keep 16 bit address since till now we do not have 28bit address request */
-uint32_t canIDs[] = { 0x01F0 /* BMW e46 ABS Message        */,
-                      0x0200 /* W202 C180 ABS signal       */
-                    };
 
-#define look_up_can_id(X)   canIDs[X]
+
+uint16_t look_up_can_id(can_vss_nbc_e type) {
+    
+    uint16_t retCanID;
+    switch (type) {
+        case BMW_e46:
+            retCanID = 0x01F0; /* BMW e46 ABS Message */
+            break;
+        case W202:
+            retCanID = 0x0200; /* W202 C180 ABS signal */
+            break;
+        default:
+            firmwareError(OBD_Vehicle_Speed_SensorB, "Wrong Can DBC selected: %d", type);
+            retCanID = 0xffff;
+            break;
+    }
+    return retCanID;
+}
+
 
 /* Module specitifc processing functions */
 /* source: http://z4evconversion.blogspot.com/2016/07/completely-forgot-but-it-does-live-on.html */
@@ -45,17 +59,24 @@ void processBMW_e46(const CANRxFrame& frame) {
 
 void processW202(const CANRxFrame& frame) {
 
-    (void)frame;
+    uint16_t tmp;
+    
+    tmp = (frame.data8[2] << 8);
+    tmp |= frame.data8[3];
+    vssSpeed = ((float)tmp) * 0.0277;
 }
 
 /* End of specific processing functions */
 
 void canVssInfo(void) {
     scheduleMsg(logger, "vss using can option selected %x", CONFIG(canVssNbcType));
+    scheduleMsg(logger, "vss filter for %x canID", filterCanID);
+    scheduleMsg(logger, "Vss module is %d", isInit);
+    scheduleMsg(logger, "CONFIG_enableCanVss is %d", CONFIG(enableCanVss));
 }
 
 void processCanRxVss(const CANRxFrame& frame, efitick_t nowNt) {
-    if ((CONFIG(enableCanVss)) || (!isInit)) {
+    if ((!CONFIG(enableCanVss)) || (!isInit)) {
         return;
     }
 
@@ -92,10 +113,17 @@ float getVehicleCanSpeed(void) {
 
 void initCanVssSupport(Logging *logger_ptr) {
 
-    if (CONFIG(enableCanVss)) {
+    addConsoleAction("canvssinfo", canVssInfo);
     logger = logger_ptr;
+
+    if (CONFIG(enableCanVss)) {
+
         isInit = true;
         filterCanID = look_up_can_id(CONFIG(canVssNbcType));
+
+        if (filterCanID == 0xffff) {
+            isInit = false;
+        }
     }
     
 }

firmware/hw_layer/vehicle_speed.cpp

@@ -35,7 +35,7 @@ float getVehicleSpeed(void) {
 	if (mockVehicleSpeed != DEFAULT_MOCK_SPEED)
 		return mockVehicleSpeed;
 #if EFI_CAN_SUPPORT
-	if ( CONFIG(enableCanVss) == true ) {
+	if (CONFIG(enableCanVss)) {
 		return getVehicleCanSpeed();
 	}
 #endif	/* EFI_CAN_SUPPORT */