FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Trigger setup in TS is highly confusing: hide operation mode from users? #4031

This commit is contained in:
Andrey 2022-04-03 01:02:13 -04:00
parent 08fff0816b
commit 4adaf71e18
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unit_tests/tests/actuators/test_tacho.cpp
View File

@ -22,7 +22,7 @@ TEST(Actuators, Tachometer) {
engineConfiguration->trigger.customTotalToothCount = 8;
engineConfiguration->trigger.customSkippedToothCount = 0;
engineConfiguration->useOnlyRisingEdgeForTrigger = false;
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
setCamOperationMode(engineConfiguration);
eth.applyTriggerWaveform();
// get the engine running - 6 revolutions

2
unit_tests/tests/ignition_injection/injection_mode_transition.cpp
View File

@ -39,7 +39,7 @@ TEST(fuelControl, transitionIssue1592) {
engineConfiguration->trigger.customTotalToothCount = 6;
engineConfiguration->trigger.customSkippedToothCount = 1;
eth.setTriggerType(TT_TOOTHED_WHEEL);
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
setCamOperationMode(engineConfiguration);
engineConfiguration->isFasterEngineSpinUpEnabled = true;
setTable(config->injectionPhase, 0.0f);

2
unit_tests/tests/test_engine_math.cpp
View File

@ -26,7 +26,7 @@ TEST(misc, testEngineMath) {
EngineTestHelper eth(FORD_ESCORT_GT);
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
setCamOperationMode(engineConfiguration);
engineConfiguration->fuelAlgorithm = LM_SPEED_DENSITY;
ASSERT_NEAR( 50, getOneDegreeTimeMs(600) * 180, EPS4D) << "600 RPM";

2
unit_tests/tests/test_hpfp_integrated.cpp
View File

@ -20,7 +20,7 @@ TEST(HPFP, IntegratedSchedule) {
engineConfiguration->trigger.customTotalToothCount = 16;
engineConfiguration->trigger.customSkippedToothCount = 0;
eth.setTriggerType(TT_TOOTHED_WHEEL);
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
setCamOperationMode(engineConfiguration);
engineConfiguration->isFasterEngineSpinUpEnabled = true;

2
unit_tests/tests/trigger/test_all_triggers.cpp
View File

@ -58,7 +58,7 @@ TEST_P(AllTriggersFixture, TestTrigger) {
EngineTestHelperBase base(engine, &pc.engineConfiguration, &pc);
engineConfiguration->trigger.type = tt;
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
setCamOperationMode(engineConfiguration);
TriggerWaveform *shape = &engine->triggerCentral.triggerShape;
TriggerFormDetails *triggerFormDetails = &engine->triggerCentral.triggerFormDetails;