Trigger pattern request Škoda Favorit #2302

firmware/controllers/algo/auto_generated_enums.cpp

@@ -1,7 +1,7 @@
 #include "global.h"
 #include "rusefi_enums.h"
 #include "rusefi_hw_enums.h"
-// was generated automatically by rusEfi tool  from rusefi_hw_enums.h // was generated automatically by rusEfi tool  from rusefi_enums.h // by enum2string.jar tool on Sat Feb 06 18:51:30 UTC 2021
+// was generated automatically by rusEfi tool  from rusefi_hw_enums.h // was generated automatically by rusEfi tool  from rusefi_enums.h // by enum2string.jar tool on Sat Feb 06 20:00:28 EST 2021
 // see also gen_config_and_enums.bat
 
 
@@ -1407,6 +1407,8 @@ case TT_RENIX_66_2_2_2:
   return "TT_RENIX_66_2_2_2";
 case TT_ROVER_K:
   return "TT_ROVER_K";
+case TT_SKODA_FAVORIT:
+  return "TT_SKODA_FAVORIT";
 case TT_SUBARU_7_6:
   return "TT_SUBARU_7_6";
 case TT_SUBARU_7_WITHOUT_6:

firmware/controllers/algo/rusefi_enums.h

@@ -371,13 +371,19 @@ typedef enum {
 
 	TT_GM_60_2_2_2 = TT_TT_GM_60_2_2_2,
 
+	/**
+	 * https://rusefi.com/forum/viewtopic.php?f=5&t=1937
+	 * HALL sensor, and can be used on all Skoda's engines (from 1000MB to 130, Favorit, Felicia)
+	 */
+	TT_SKODA_FAVORIT = TT_TT_SKODA_FAVORIT,
+
 	// do not forget to edit "#define trigger_type_e_enum" line in integration/rusefi_config.txt file to propogate new value to rusefi.ini TS project
 	// do not forget to invoke "gen_config.bat" once you make changes to integration/rusefi_config.txt
 	// todo: one day a hero would integrate some of these things into Makefile in order to reduce manual magic
 	//
 	// Another point: once you add a new trigger, run get_trigger_images.bat which would run rusefi_test.exe from unit_tests
 	//
-	TT_UNUSED = 55, // this is used if we want to iterate over all trigger types
+	TT_UNUSED = 56, // this is used if we want to iterate over all trigger types
 
 	Force_4_bytes_size_trigger_type = ENUM_32_BITS,
 } trigger_type_e;

firmware/controllers/trigger/decoders/trigger_structure.cpp

@@ -540,6 +540,7 @@ void TriggerWaveform::initializeTriggerWaveform(Logging *logger, operation_mode_
 		configureFordAspireTriggerWaveform(this);
 		break;
 
+	case TT_SKODA_FAVORIT:
 	case TT_GM_60_2_2_2:
 		configureGm60_2_2_2(this);
 		break;

firmware/controllers/trigger/decoders/trigger_vw.cpp

@@ -9,9 +9,23 @@
 #include "trigger_universal.h"
 #include "error_handling.h"
 
-void setVwConfiguration(TriggerWaveform *s) {
-	efiAssertVoid(CUSTOM_ERR_6660, s != NULL, "TriggerWaveform is NULL");
+void setSkodaFavorit(TriggerWaveform *s) {
+	s->initialize(FOUR_STROKE_CRANK_SENSOR);
 
+	int m = 2;
+
+	s->addEvent720(m * 46, T_PRIMARY, TV_RISE);
+	s->addEvent720(m * 177, T_PRIMARY, TV_FALL);
+
+	s->addEvent720(m * 180, T_PRIMARY, TV_RISE);
+	s->addEvent720(m * 183, T_PRIMARY, TV_FALL);
+
+	s->addEvent720(m * 226, T_PRIMARY, TV_RISE);
+	s->addEvent720(m * 360, T_PRIMARY, TV_FALL);
+
+}
+
+void setVwConfiguration(TriggerWaveform *s) {
 	s->initialize(FOUR_STROKE_CRANK_SENSOR);
 
 	s->isSynchronizationNeeded = true;

firmware/controllers/trigger/decoders/trigger_vw.h

@@ -10,3 +10,7 @@
 #include "trigger_structure.h"
 
 void setVwConfiguration(TriggerWaveform *s);
+/**
+ * I know Skoda was not owned by VAG back than but that's OK
+ */
+void setSkodaFavorit(TriggerWaveform *s);