From 5a68b7a22c5e6bb864d258efd2c4822182831f24 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Tue, 7 Dec 2021 01:23:30 -0500 Subject: [PATCH] test coverage related to https://github.com/rusefi/rusefi/issues/3361#issuecomment-987556760 logging improvements --- .../main/java/com/rusefi/binaryprotocol/IoHelper.java | 2 +- .../src/main/java/com/rusefi/io/can/Elm327Connector.java | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/java_console/io/src/main/java/com/rusefi/binaryprotocol/IoHelper.java b/java_console/io/src/main/java/com/rusefi/binaryprotocol/IoHelper.java index ed58758c48..d9a04edf81 100644 --- a/java_console/io/src/main/java/com/rusefi/binaryprotocol/IoHelper.java +++ b/java_console/io/src/main/java/com/rusefi/binaryprotocol/IoHelper.java @@ -12,7 +12,7 @@ import java.util.zip.CRC32; * 3/6/2015 */ public class IoHelper { - private static final Logging log = Logging.getLogging(IoStream.class); + private static final Logging log = Logging.getLogging(IoHelper.class); static { log.configureDebugEnabled(false); diff --git a/java_console/io/src/main/java/com/rusefi/io/can/Elm327Connector.java b/java_console/io/src/main/java/com/rusefi/io/can/Elm327Connector.java index 0207744fc3..dec20e609d 100644 --- a/java_console/io/src/main/java/com/rusefi/io/can/Elm327Connector.java +++ b/java_console/io/src/main/java/com/rusefi/io/can/Elm327Connector.java @@ -17,6 +17,11 @@ import static com.rusefi.Timeouts.SECOND; public class Elm327Connector implements Closeable { private final static Logging log = Logging.getLogging(Elm327Connector.class); + + static { + log.configureDebugEnabled(false); + } + private static final byte[] HEX_ARRAY = "0123456789ABCDEF".getBytes(); // public final static int ELM327_DEFAULT_BAUDRATE = 115200; // OBDlink SX, 1.3a STN1110 @@ -212,6 +217,10 @@ public class Elm327Connector implements Closeable { } private void sendCanData(byte [] hdr, byte [] data, int offset, int len) { + if (log.debugEnabled()) { + log.debug("sendCanData header " + IoStream.printByteArray(hdr)); + log.debug("sendCanData payload " + IoStream.printByteArray(data) + " len=" + len + " from offset=" + offset); + } //log.info("--------sendData offset="+Integer.toString(offset) + " len=" + Integer.toString(len) + "hdr.len=" + Integer.toString(hdr.length)); byte[] hexData = byteToString(hdr, data, offset, len);