behave yourselves with null previousConfig

This commit is contained in:
Matthew Kennedy 2024-05-03 22:10:42 -07:00
parent 2c8e4277f1
commit 5d0d3fd120
4 changed files with 4 additions and 4 deletions

View File

@ -77,7 +77,7 @@ void AlternatorController::setOutput(expected<percent_t> outputValue) {
} }
void AlternatorController::onConfigurationChange(engine_configuration_s const * previousConfiguration) { void AlternatorController::onConfigurationChange(engine_configuration_s const * previousConfiguration) {
if(!alternatorPid.isSame(&previousConfiguration->alternatorControl)) { if(!previousConfiguration || !alternatorPid.isSame(&previousConfiguration->alternatorControl)) {
alternatorPid.reset(); alternatorPid.reset();
} }
} }

View File

@ -39,7 +39,7 @@ void BoostController::resetLua() {
} }
void BoostController::onConfigurationChange(engine_configuration_s const * previousConfig) { void BoostController::onConfigurationChange(engine_configuration_s const * previousConfig) {
if (!m_pid.isSame(&previousConfig->boostPid)) { if (!previousConfig || !m_pid.isSame(&previousConfig->boostPid)) {
m_shouldResetPid = true; m_shouldResetPid = true;
} }
} }

View File

@ -376,7 +376,7 @@ void IdleController::onSlowCallback() {
void IdleController::onConfigurationChange(engine_configuration_s const * previousConfiguration) { void IdleController::onConfigurationChange(engine_configuration_s const * previousConfiguration) {
#if ! EFI_UNIT_TEST #if ! EFI_UNIT_TEST
shouldResetPid = !getIdlePid()->isSame(&previousConfiguration->idleRpmPid); shouldResetPid = !previousConfig || !getIdlePid()->isSame(&previousConfiguration->idleRpmPid);
mustResetPid = shouldResetPid; mustResetPid = shouldResetPid;
#endif #endif
} }

View File

@ -42,7 +42,7 @@ void VvtController::onFastCallback() {
} }
void VvtController::onConfigurationChange(engine_configuration_s const * previousConfig) { void VvtController::onConfigurationChange(engine_configuration_s const * previousConfig) {
if (!m_pid.isSame(&previousConfig->auxPid[m_cam])) { if (!previousConfig || !m_pid.isSame(&previousConfig->auxPid[m_cam])) {
m_pid.reset(); m_pid.reset();
} }
} }