FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

do not control VVT during cranking fix #3443

This commit is contained in:
rusefillc 2022-04-10 19:22:39 -04:00
parent 7213011353
commit 5f288d88dc
6 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
firmware/CHANGELOG.md
View File

@ -33,6 +33,7 @@ All notable user-facing or behavior-altering changes will be documented in this
- Mitsubishi 3A92 VVT trigger - Mitsubishi 3A92 VVT trigger
- Toyota 4-1 VVT trigger - Toyota 4-1 VVT trigger
- use extra RAM for lua if your microRusEFI unit has stm32f42x microcontroller - use extra RAM for lua if your microRusEFI unit has stm32f42x microcontroller
- VVT activation delay #3443
## March 2022 Release - "Day 22" ## March 2022 Release - "Day 22"

7
firmware/controllers/actuators/vvt.cpp
View File

@ -90,10 +90,11 @@ expected<percent_t> VvtController::getClosedLoop(angle_t target, angle_t observa
void VvtController::setOutput(expected<percent_t> outputValue) { void VvtController::setOutput(expected<percent_t> outputValue) {
float rpm = Sensor::getOrZero(SensorType::Rpm); float rpm = Sensor::getOrZero(SensorType::Rpm);
// todo: make this configurable? bool enabled = rpm > engineConfiguration->cranking.rpm /* todo: make this configurable? */
bool enabledAtCurrentRpm = rpm > engineConfiguration->cranking.rpm; && engine->rpmCalculator.getSecondsSinceEngineStart(getTimeNowNt()) > engineConfiguration->vvtActivationDelayMs / MS_PER_SECOND
;
if (outputValue && enabledAtCurrentRpm) { if (outputValue && enabled) {
m_pwm.setSimplePwmDutyCycle(PERCENT_TO_DUTY(outputValue.Value)); m_pwm.setSimplePwmDutyCycle(PERCENT_TO_DUTY(outputValue.Value));
} else { } else {
m_pwm.setSimplePwmDutyCycle(0); m_pwm.setSimplePwmDutyCycle(0);

2
firmware/controllers/engine_cycle/rpm_calculator.cpp
View File

@ -300,7 +300,7 @@ void rpmShaftPositionCallback(trigger_event_e ckpSignalType,
} }
} }
float RpmCalculator::getTimeSinceEngineStart(efitick_t nowNt) const { float RpmCalculator::getSecondsSinceEngineStart(efitick_t nowNt) const {
return engineStartTimer.getElapsedSeconds(nowNt); return engineStartTimer.getElapsedSeconds(nowNt);
} }

4
firmware/controllers/engine_cycle/rpm_calculator.h
View File

@ -103,8 +103,8 @@ public:
*/ */
float getRpmAcceleration() const; float getRpmAcceleration() const;
// Get elapsed time (seconds) since the engine transitioned to the running state. // Get elapsed time since the engine transitioned to the running state.
float getTimeSinceEngineStart(efitick_t nowNt) const; float getSecondsSinceEngineStart(efitick_t nowNt) const;
/** /**
* this is RPM on previous engine cycle. * this is RPM on previous engine cycle.

2
firmware/controllers/limp_manager.cpp
View File

@ -40,7 +40,7 @@ void LimpManager::updateState(int rpm, efitick_t nowNt) {
// Only check if the setting is enabled // Only check if the setting is enabled
if (minOilPressure > 0) { if (minOilPressure > 0) {
// Has it been long enough we should have pressure? // Has it been long enough we should have pressure?
bool isTimedOut = engine->rpmCalculator.getTimeSinceEngineStart(nowNt) > 5.0f; bool isTimedOut = engine->rpmCalculator.getSecondsSinceEngineStart(nowNt) > 5.0f;
// Only check before timed out // Only check before timed out
if (!isTimedOut) { if (!isTimedOut) {

1
firmware/util/efitime.h
View File

@ -12,6 +12,7 @@
#include "efifeatures.h" #include "efifeatures.h"
#include "rusefi_types.h" #include "rusefi_types.h"
#define MS_PER_SECOND 1000
#define US_PER_SECOND 1000000 #define US_PER_SECOND 1000000
#define US_PER_SECOND_F 1000000.0 #define US_PER_SECOND_F 1000000.0
#define US_PER_SECOND_LL 1000000LL #define US_PER_SECOND_LL 1000000LL