From 60967399ccd0762dad3e7cb812056eb68bab193e Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Tue, 12 Mar 2024 15:29:44 -0700 Subject: [PATCH] set hasFirmwareErrorFlag as early as possible --- firmware/controllers/core/error_handling.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/firmware/controllers/core/error_handling.cpp b/firmware/controllers/core/error_handling.cpp index be02631b0d..4c0446142a 100644 --- a/firmware/controllers/core/error_handling.cpp +++ b/firmware/controllers/core/error_handling.cpp @@ -215,6 +215,8 @@ void firmwareError(ObdCode code, const char *fmt, ...) { #if EFI_PROD_CODE if (hasFirmwareErrorFlag) return; + hasFirmwareErrorFlag = true; + getLimpManager()->fatalError(); engine->engineState.warnings.addWarningCode(code); #ifdef EFI_PRINT_ERRORS_AS_WARNINGS @@ -227,7 +229,6 @@ void firmwareError(ObdCode code, const char *fmt, ...) { turnAllPinsOff(); enginePins.communicationLedPin.setValue(1); - hasFirmwareErrorFlag = true; if (indexOf(fmt, '%') == -1) { /** * in case of simple error message let's reduce stack usage